Re: Review Request 27848: Add friendly error message to the client when lock is held.

[David McLaughlin]

> On Nov. 12, 2014, 1:28 a.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/cli/context.py, line 152
> > 
> >
> > Is this going to produce some redundant output?

See reply below, not sure why it didn't reply inline.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27848/#review60892
---


On Nov. 11, 2014, 12:58 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27848/
> ---
> 
> (Updated Nov. 11, 2014, 12:58 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-885
> https://issues.apache.org/jira/browse/AURORA-885
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add friendly error message to the client when lock is held.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 67cf40365b38b6bf395c697faf0cdb334322bdc3 
>   src/main/python/apache/aurora/client/cli/context.py 
> a5ebbdc2ca37c5fd1813854d0a34f15511e6ca06 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 28f9475c5accb8c73cbc5f7a1010920479a0388e 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1f5cbb616828932742e6482867e2eca9401aad61 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 1dec54c0da2346d4091bb3fda4508836aac0 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 78f5f04507d7fe080a1ed5ddda692e52f66cc18d 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> a8180a3264ac1aa2ade654985755a4dbe262dc47 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 09f6a85aebdbf0ad9c9816684f4574132205ee65 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> a5e59e4924618ab97f18ea056ef8225e864a317d 
>   src/test/python/apache/aurora/client/cli/util.py 
> 154fb3a7170ae81548fcbc9f3cdd6dcf9bf1942d 
> 
> Diff: https://reviews.apache.org/r/27848/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/isort-check
> ./build-support/python/checkstyle-check
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 27848: Add friendly error message to the client when lock is held.

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27848/#review60921
---



src/main/python/apache/aurora/client/cli/context.py


The error message is passed by the handler. It sometimes contains 
additional info or a message from the scheduler. I felt like when it comes to 
errors, more info is better.


- David McLaughlin


On Nov. 11, 2014, 12:58 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27848/
> ---
> 
> (Updated Nov. 11, 2014, 12:58 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-885
> https://issues.apache.org/jira/browse/AURORA-885
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add friendly error message to the client when lock is held.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 67cf40365b38b6bf395c697faf0cdb334322bdc3 
>   src/main/python/apache/aurora/client/cli/context.py 
> a5ebbdc2ca37c5fd1813854d0a34f15511e6ca06 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 28f9475c5accb8c73cbc5f7a1010920479a0388e 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1f5cbb616828932742e6482867e2eca9401aad61 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 1dec54c0da2346d4091bb3fda4508836aac0 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 78f5f04507d7fe080a1ed5ddda692e52f66cc18d 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> a8180a3264ac1aa2ade654985755a4dbe262dc47 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 09f6a85aebdbf0ad9c9816684f4574132205ee65 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> a5e59e4924618ab97f18ea056ef8225e864a317d 
>   src/test/python/apache/aurora/client/cli/util.py 
> 154fb3a7170ae81548fcbc9f3cdd6dcf9bf1942d 
> 
> Diff: https://reviews.apache.org/r/27848/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/isort-check
> ./build-support/python/checkstyle-check
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 27894: Bump commons version.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27894/#review60919
---

Ship it!


This is now on master
```
$ git log -1 origin/master --abbrev-commit
commit 148f427
Author: Zameer Manji 
Date:   Tue Nov 11 17:29:41 2014 -0800

Bump commons version.

Reviewed at https://reviews.apache.org/r/27894/
```

- Bill Farner


On Nov. 12, 2014, 12:26 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27894/
> ---
> 
> (Updated Nov. 12, 2014, 12:26 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bump commons version.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
> 
> Diff: https://reviews.apache.org/r/27894/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python:all
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27892: Fixes for the make pycharm script:

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60918
---

Ship it!


Thanks!

- Bill Farner


On Nov. 11, 2014, 11:11 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27892/
> ---
> 
> (Updated Nov. 11, 2014, 11:11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes for the make pycharm script:
> 
> 1. Escape $'s
> 2. Use root directory name as project name
> 3. Exclude some noisy directories
> 
> 
> Diffs
> -
> 
>   build-support/python/make-pycharm-virtualenv 
> 316ead7c92e0510cd53958f419686e902dc34204 
> 
> Diff: https://reviews.apache.org/r/27892/diff/
> 
> 
> Testing
> ---
> 
> $ cat .idea/incubator-aurora.iml 
> 
> 
>   
> 
>isTestSource="false" />
>   
>   
>   
> 
> 
> 
>   
>   
> 
> 
>   
> 
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 27848: Add friendly error message to the client when lock is held.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27848/#review60892
---

Ship it!



src/main/python/apache/aurora/client/cli/context.py


Is this going to produce some redundant output?


- Bill Farner


On Nov. 11, 2014, 12:58 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27848/
> ---
> 
> (Updated Nov. 11, 2014, 12:58 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-885
> https://issues.apache.org/jira/browse/AURORA-885
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add friendly error message to the client when lock is held.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 67cf40365b38b6bf395c697faf0cdb334322bdc3 
>   src/main/python/apache/aurora/client/cli/context.py 
> a5ebbdc2ca37c5fd1813854d0a34f15511e6ca06 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 28f9475c5accb8c73cbc5f7a1010920479a0388e 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1f5cbb616828932742e6482867e2eca9401aad61 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 1dec54c0da2346d4091bb3fda4508836aac0 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 78f5f04507d7fe080a1ed5ddda692e52f66cc18d 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> a8180a3264ac1aa2ade654985755a4dbe262dc47 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 09f6a85aebdbf0ad9c9816684f4574132205ee65 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> a5e59e4924618ab97f18ea056ef8225e864a317d 
>   src/test/python/apache/aurora/client/cli/util.py 
> 154fb3a7170ae81548fcbc9f3cdd6dcf9bf1942d 
> 
> Diff: https://reviews.apache.org/r/27848/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/isort-check
> ./build-support/python/checkstyle-check
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 27894: Bump commons version.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27894/#review60909
---

Ship it!


Master (7ecb718) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 12, 2014, 12:26 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27894/
> ---
> 
> (Updated Nov. 12, 2014, 12:26 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bump commons version.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
> 
> Diff: https://reviews.apache.org/r/27894/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python:all
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27894: Bump commons version.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27894/#review60908
---

Ship it!


Ship It!

- Bill Farner


On Nov. 12, 2014, 12:26 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27894/
> ---
> 
> (Updated Nov. 12, 2014, 12:26 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bump commons version.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
> 
> Diff: https://reviews.apache.org/r/27894/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python:all
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27894: Bump commons version.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27894/#review60904
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 12, 2014, 12:26 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27894/
> ---
> 
> (Updated Nov. 12, 2014, 12:26 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bump commons version.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
> 
> Diff: https://reviews.apache.org/r/27894/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python:all
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27894: Bump commons version.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27894/#review60903
---

Ship it!


Ship It!

- Joe Smith


On Nov. 11, 2014, 4:26 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27894/
> ---
> 
> (Updated Nov. 11, 2014, 4:26 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bump commons version.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
> 
> Diff: https://reviews.apache.org/r/27894/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python:all
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Review Request 27894: Bump commons version.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27894/
---

Review request for Aurora, Joe Smith and Bill Farner.


Repository: aurora


Description
---

Bump commons version.


Diffs
-

  3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 

Diff: https://reviews.apache.org/r/27894/diff/


Testing
---

./pants build src/test/python:all


Thanks,

Zameer Manji

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27889/
---

(Updated Nov. 12, 2014, 12:08 a.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Bugs: AURORA-913
https://issues.apache.org/jira/browse/AURORA-913


Repository: aurora


Description
---

One step closer to caching host attributes.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
fef76f5069a80959eaba04f1b4b93ff3f6ba43dd 
  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
14c3e3a593f72af696106d948767d85075b8726b 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
9c095d932ada9f42cd473bc5d782883b0522c3cf 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
0ba31ac5b17dd6dfa4e5f58d4e018cdb9b78172f 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
88418e61a371626d2c6390a36d3a3284db8d76be 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
32890f5b390214bfa630dae0445fdde735f98ccf 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
c6250b4a1b4cf168c451f1cfb87a02ef2ce4841d 
  src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
662ebdceff580af0a05f9a89d50ca1c90ddc9070 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
2f525104022448c200bfddc5a88252987fc86d0f 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
7736d4cec260eba0938acaf9f884597a3e35f08e 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
 99fa11ba15f1af9a4fd6fc31bb45020083d11806 
  src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
e884209fd5965e50847f14b09a43f6aba4946b7e 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
c6ff43fdc07183d8e30d3db0a1af7c762255076f 
  
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
 a553c566a14eda29862fe414f348dc071d0e638c 

Diff: https://reviews.apache.org/r/27889/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

[Bill Farner]

> On Nov. 11, 2014, 11:05 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java, 
> > line 56
> > 
> >
> > requireNonNull

Thanks, fixed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27889/#review60890
---


On Nov. 11, 2014, 10:42 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27889/
> ---
> 
> (Updated Nov. 11, 2014, 10:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> One step closer to caching host attributes.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> fef76f5069a80959eaba04f1b4b93ff3f6ba43dd 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 14c3e3a593f72af696106d948767d85075b8726b 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 9c095d932ada9f42cd473bc5d782883b0522c3cf 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> 0ba31ac5b17dd6dfa4e5f58d4e018cdb9b78172f 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> 88418e61a371626d2c6390a36d3a3284db8d76be 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 32890f5b390214bfa630dae0445fdde735f98ccf 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> c6250b4a1b4cf168c451f1cfb87a02ef2ce4841d 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> 662ebdceff580af0a05f9a89d50ca1c90ddc9070 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 2f525104022448c200bfddc5a88252987fc86d0f 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 7736d4cec260eba0938acaf9f884597a3e35f08e 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  99fa11ba15f1af9a4fd6fc31bb45020083d11806 
>   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
> e884209fd5965e50847f14b09a43f6aba4946b7e 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> c6ff43fdc07183d8e30d3db0a1af7c762255076f 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
>  a553c566a14eda29862fe414f348dc071d0e638c 
> 
> Diff: https://reviews.apache.org/r/27889/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27892: Fixes for the make pycharm script:

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60898
---

Ship it!


Master (0774c4e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 11, 2014, 11:11 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27892/
> ---
> 
> (Updated Nov. 11, 2014, 11:11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes for the make pycharm script:
> 
> 1. Escape $'s
> 2. Use root directory name as project name
> 3. Exclude some noisy directories
> 
> 
> Diffs
> -
> 
>   build-support/python/make-pycharm-virtualenv 
> 316ead7c92e0510cd53958f419686e902dc34204 
> 
> Diff: https://reviews.apache.org/r/27892/diff/
> 
> 
> Testing
> ---
> 
> $ cat .idea/incubator-aurora.iml 
> 
> 
>   
> 
>isTestSource="false" />
>   
>   
>   
> 
> 
> 
>   
>   
> 
> 
>   
> 
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 27892: Fixes for the make pycharm script:

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60894
---


@ReviewBot retry

- Joshua Cohen


On Nov. 11, 2014, 11:11 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27892/
> ---
> 
> (Updated Nov. 11, 2014, 11:11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes for the make pycharm script:
> 
> 1. Escape $'s
> 2. Use root directory name as project name
> 3. Exclude some noisy directories
> 
> 
> Diffs
> -
> 
>   build-support/python/make-pycharm-virtualenv 
> 316ead7c92e0510cd53958f419686e902dc34204 
> 
> Diff: https://reviews.apache.org/r/27892/diff/
> 
> 
> Testing
> ---
> 
> $ cat .idea/incubator-aurora.iml 
> 
> 
>   
> 
>isTestSource="false" />
>   
>   
>   
> 
> 
> 
>   
>   
> 
> 
>   
> 
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 27892: Fixes for the make pycharm script:

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60893
---


Master (0774c4e) is red with this patch.
  ./build-support/jenkins/build.sh

  File "/usr/lib/python2.7/sysconfig.py", line 355, in _init_posix
raise IOError(msg)
IOError: invalid Python installation: unable to open 
/x1/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/local/include/python2.7/pyconfig.h
 (No such file or directory)

Build operating on top level addresses: 
set([BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/au
 th/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 base)), PythonLibrary
 
(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/
 workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 job_monitor)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 quota_check)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace
 /AuroraBot/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD,
 util)), 
PythonTests(Bui

Review Request 27892: Fixes for the make pycharm script:

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Repository: aurora


Description
---

Fixes for the make pycharm script:

1. Escape $'s
2. Use root directory name as project name
3. Exclude some noisy directories


Diffs
-

  build-support/python/make-pycharm-virtualenv 
316ead7c92e0510cd53958f419686e902dc34204 

Diff: https://reviews.apache.org/r/27892/diff/


Testing
---

$ cat .idea/incubator-aurora.iml 


  

  
  
  
  



  
  


  



Thanks,

Joshua Cohen

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27889/#review60890
---

Ship it!



src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java


requireNonNull


- Joshua Cohen


On Nov. 11, 2014, 10:42 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27889/
> ---
> 
> (Updated Nov. 11, 2014, 10:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> One step closer to caching host attributes.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> fef76f5069a80959eaba04f1b4b93ff3f6ba43dd 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 14c3e3a593f72af696106d948767d85075b8726b 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 9c095d932ada9f42cd473bc5d782883b0522c3cf 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> 0ba31ac5b17dd6dfa4e5f58d4e018cdb9b78172f 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> 88418e61a371626d2c6390a36d3a3284db8d76be 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 32890f5b390214bfa630dae0445fdde735f98ccf 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> c6250b4a1b4cf168c451f1cfb87a02ef2ce4841d 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> 662ebdceff580af0a05f9a89d50ca1c90ddc9070 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 2f525104022448c200bfddc5a88252987fc86d0f 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 7736d4cec260eba0938acaf9f884597a3e35f08e 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  99fa11ba15f1af9a4fd6fc31bb45020083d11806 
>   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
> e884209fd5965e50847f14b09a43f6aba4946b7e 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> c6ff43fdc07183d8e30d3db0a1af7c762255076f 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
>  a553c566a14eda29862fe414f348dc071d0e638c 
> 
> Diff: https://reviews.apache.org/r/27889/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

[Bill Farner]

> On Nov. 11, 2014, 10:51 p.m., Kevin Sweeney wrote:
> > src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java,
> >  line 73
> > 
> >
> > Is this needed anymore? Maintenance doesn't have a dependency on pubsub 
> > anymore right?

Yes and no.  `MaintenanceControllerImpl` subscribes to task state changes, 
which the test pushes over the event bus.  I'd rather not make direct calls 
since this behavior catches wiring issues like a missing `@Subscribe` 
annotation.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27889/#review60886
---


On Nov. 11, 2014, 10:42 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27889/
> ---
> 
> (Updated Nov. 11, 2014, 10:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> One step closer to caching host attributes.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> fef76f5069a80959eaba04f1b4b93ff3f6ba43dd 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 14c3e3a593f72af696106d948767d85075b8726b 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 9c095d932ada9f42cd473bc5d782883b0522c3cf 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> 0ba31ac5b17dd6dfa4e5f58d4e018cdb9b78172f 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> 88418e61a371626d2c6390a36d3a3284db8d76be 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 32890f5b390214bfa630dae0445fdde735f98ccf 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> c6250b4a1b4cf168c451f1cfb87a02ef2ce4841d 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> 662ebdceff580af0a05f9a89d50ca1c90ddc9070 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 2f525104022448c200bfddc5a88252987fc86d0f 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 7736d4cec260eba0938acaf9f884597a3e35f08e 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  99fa11ba15f1af9a4fd6fc31bb45020083d11806 
>   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
> e884209fd5965e50847f14b09a43f6aba4946b7e 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> c6ff43fdc07183d8e30d3db0a1af7c762255076f 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
>  a553c566a14eda29862fe414f348dc071d0e638c 
> 
> Diff: https://reviews.apache.org/r/27889/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27889/#review60889
---

Ship it!


Master (0774c4e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 11, 2014, 10:42 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27889/
> ---
> 
> (Updated Nov. 11, 2014, 10:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> One step closer to caching host attributes.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> fef76f5069a80959eaba04f1b4b93ff3f6ba43dd 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 14c3e3a593f72af696106d948767d85075b8726b 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 9c095d932ada9f42cd473bc5d782883b0522c3cf 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> 0ba31ac5b17dd6dfa4e5f58d4e018cdb9b78172f 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> 88418e61a371626d2c6390a36d3a3284db8d76be 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 32890f5b390214bfa630dae0445fdde735f98ccf 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> c6250b4a1b4cf168c451f1cfb87a02ef2ce4841d 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> 662ebdceff580af0a05f9a89d50ca1c90ddc9070 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 2f525104022448c200bfddc5a88252987fc86d0f 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 7736d4cec260eba0938acaf9f884597a3e35f08e 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  99fa11ba15f1af9a4fd6fc31bb45020083d11806 
>   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
> e884209fd5965e50847f14b09a43f6aba4946b7e 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> c6ff43fdc07183d8e30d3db0a1af7c762255076f 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
>  a553c566a14eda29862fe414f348dc071d0e638c 
> 
> Diff: https://reviews.apache.org/r/27889/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27852: Ensure run verb returns an exit code.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27852/#review60888
---



src/main/python/apache/aurora/client/cli/task.py


Should we just make this the default behavior?  There's at least 31 
locations that do this, seems like a catch-all would be useful.  If we do this, 
i'd recommend you remove all `return EXIT_OK` lines, so only proceed if you're 
okay with that.

Looks like the relevant changes would be in:
src/main/python/apache/aurora/client/cli/standalone_client.py
src/main/python/apache/aurora/client/cli/client.py


- Bill Farner


On Nov. 11, 2014, 2:50 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27852/
> ---
> 
> (Updated Nov. 11, 2014, 2:50 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-923
> https://issues.apache.org/jira/browse/AURORA-923
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Ensure run verb returns an exit code.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/task.py 
> 91175facdc8c9fd59ab66781f86ee8b5940a 
>   src/test/python/apache/aurora/client/cli/BUILD 
> e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b 
> 
> Diff: https://reviews.apache.org/r/27852/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python/apache/aurora/client/cli::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27889/#review60886
---

Ship it!



src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java


Is this needed anymore? Maintenance doesn't have a dependency on pubsub 
anymore right?


- Kevin Sweeney


On Nov. 11, 2014, 2:42 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27889/
> ---
> 
> (Updated Nov. 11, 2014, 2:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-913
> https://issues.apache.org/jira/browse/AURORA-913
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> One step closer to caching host attributes.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> fef76f5069a80959eaba04f1b4b93ff3f6ba43dd 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 14c3e3a593f72af696106d948767d85075b8726b 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 9c095d932ada9f42cd473bc5d782883b0522c3cf 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> 0ba31ac5b17dd6dfa4e5f58d4e018cdb9b78172f 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> 88418e61a371626d2c6390a36d3a3284db8d76be 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 32890f5b390214bfa630dae0445fdde735f98ccf 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> c6250b4a1b4cf168c451f1cfb87a02ef2ce4841d 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> 662ebdceff580af0a05f9a89d50ca1c90ddc9070 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 2f525104022448c200bfddc5a88252987fc86d0f 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 7736d4cec260eba0938acaf9f884597a3e35f08e 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  99fa11ba15f1af9a4fd6fc31bb45020083d11806 
>   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
> e884209fd5965e50847f14b09a43f6aba4946b7e 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> c6ff43fdc07183d8e30d3db0a1af7c762255076f 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
>  a553c566a14eda29862fe414f348dc071d0e638c 
> 
> Diff: https://reviews.apache.org/r/27889/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27889/
---

Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Bugs: AURORA-913
https://issues.apache.org/jira/browse/AURORA-913


Repository: aurora


Description
---

One step closer to caching host attributes.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
fef76f5069a80959eaba04f1b4b93ff3f6ba43dd 
  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
14c3e3a593f72af696106d948767d85075b8726b 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
9c095d932ada9f42cd473bc5d782883b0522c3cf 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
0ba31ac5b17dd6dfa4e5f58d4e018cdb9b78172f 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
88418e61a371626d2c6390a36d3a3284db8d76be 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
32890f5b390214bfa630dae0445fdde735f98ccf 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
c6250b4a1b4cf168c451f1cfb87a02ef2ce4841d 
  src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
662ebdceff580af0a05f9a89d50ca1c90ddc9070 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
2f525104022448c200bfddc5a88252987fc86d0f 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
7736d4cec260eba0938acaf9f884597a3e35f08e 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
 99fa11ba15f1af9a4fd6fc31bb45020083d11806 
  src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
e884209fd5965e50847f14b09a43f6aba4946b7e 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
c6ff43fdc07183d8e30d3db0a1af7c762255076f 
  
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
 a553c566a14eda29862fe414f348dc071d0e638c 

Diff: https://reviews.apache.org/r/27889/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 27757: Replace bindStartupAction with Service registration

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review60874
---

Ship it!



src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java


How about fully untethering here and doing this work in `SchedulerMain`?



src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java


remove comment



src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java


revert



src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java


remove


- Bill Farner


On Nov. 8, 2014, 12:06 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27757/
> ---
> 
> (Updated Nov. 8, 2014, 12:06 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-920
> https://issues.apache.org/jira/browse/AURORA-920
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This attempts to kill LifecycleModule in favor of service registration.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 72d3d60c602b2cf01445f64f3be7e4ecf53008ca 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> fef76f5069a80959eaba04f1b4b93ff3f6ba43dd 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 
>   src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 
> 8e9a1dc10998a313ad92e365c739b74f892e82ce 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 22c666e28e03f3c1e5a1d89fda55641526b11162 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> cd5aa17b24209b186314f431c65062d6ed9972cb 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 36706f200e245ea08afa4dd36cb3511d0a63b097 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 354844a2540dec6450724acca18c399bc6c01f44 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> 844a38a285f7abf917a844a7f6a4a14749aa9b57 
>   src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 
> a7f9401f70b567002c83f4f56407b4e1d3afa5a5 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> 962aff8f4fa590935773c9fe90b1a6f59bc1c51f 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  1376237efc8f109d5a57bb8bff1c05026f257418 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> 662ebdceff580af0a05f9a89d50ca1c90ddc9070 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> 4d58240234b8e48c1f081a8ae647c54095f9dc1d 
>   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
> e884209fd5965e50847f14b09a43f6aba4946b7e 
> 
> Diff: https://reviews.apache.org/r/27757/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

[Bill Farner]

> On Nov. 11, 2014, 10:04 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java, 
> > line 283
> > 
> >
> > Can you do this in a SchedulingFilter decorator instead?  That way you 
> > can hide a bunch of logic from SchedulingFilterImpl.

Oh, looks like the hard work may already be done - can you consume the `Vetoed` 
pubsub event elsewhere?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review60861
---


On Nov. 6, 2014, 10:23 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 6, 2014, 10:23 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 1a45d08c8854a335161476c8321c751f763dc12e 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> b23457e0e64b490297166131a1b1b51b6d330415 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c37272c9f46c086cb57b79a5202b3bd80e156f07 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> 0533baa5e90ca62b8d35ba05474eaa8e27741a5a 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> c0fa462c0ebe0b06fa354f5f63d5965827c669a1 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  0318179cd70661890f5a53908d1985d54474d476 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  bffbf83653535ecd9bf7b149e1e564c5fba56d17 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  b42f6e2d23eb44605cc84ce01a80f10344a7e43f 
> 
> Diff: https://reviews.apache.org/r/27705/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Verified new stats in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review60861
---



src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java


It's nice when boolean-returning methods have names that self-document what 
the return value is.  In this case, something like `accceptsOffer`.



src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java


odd line break here, don't split up the type parameter.



src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java


Really nice to have this constrained, thanks!



src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java


s/rawReason/reasonParameter/?

Additionally, this should probably be `String...` to avoid a future yak 
shave to support non-unary argument vetoes.



src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java


Can you do this in a SchedulingFilter decorator instead?  That way you can 
hide a bunch of logic from SchedulingFilterImpl.


- Bill Farner


On Nov. 6, 2014, 10:23 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> ---
> 
> (Updated Nov. 6, 2014, 10:23 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
> https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 1a45d08c8854a335161476c8321c751f763dc12e 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> b23457e0e64b490297166131a1b1b51b6d330415 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c37272c9f46c086cb57b79a5202b3bd80e156f07 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> 0533baa5e90ca62b8d35ba05474eaa8e27741a5a 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> c0fa462c0ebe0b06fa354f5f63d5965827c669a1 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  0318179cd70661890f5a53908d1985d54474d476 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  bffbf83653535ecd9bf7b149e1e564c5fba56d17 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  b42f6e2d23eb44605cc84ce01a80f10344a7e43f 
> 
> Diff: https://reviews.apache.org/r/27705/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Verified new stats in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27747/#review60843
---

Ship it!


Ship It!

- David McLaughlin


On Nov. 8, 2014, 12:28 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27747/
> ---
> 
> (Updated Nov. 8, 2014, 12:28 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-917
> https://issues.apache.org/jira/browse/AURORA-917
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> These fail-fast checks finalize the cron/non-cron split in v2 job creation:
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/python/apache/aurora/client/cli/cron.py 
> e0510df2f0e076c96d08e7b8562573e4b487479c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 28f9475c5accb8c73cbc5f7a1010920479a0388e 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 1dec54c0da2346d4091bb3fda4508836aac0 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> 029a0c57c32ad799165099de165328ad7e81369a 
>   src/test/python/apache/aurora/client/cli/util.py 
> 154fb3a7170ae81548fcbc9f3cdd6dcf9bf1942d 
> 
> Diff: https://reviews.apache.org/r/27747/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> ./pants src/tests/python:all
> 
> vagrant@192:~$ aurora2 job create devcluster/vagrant/test/cron_hello_world4 
> aurora/examples/jobs/cron_hello_world.aurora
> Error executing command: Cron jobs may only be scheduled with "aurora cron 
> schedule" command
> 
> vagrant@192:~$ aurora2 cron schedule devcluster/www-data/prod/hello 
> aurora/examples/jobs/hello_world.aurora
> Error executing command: Non-cron jobs may only be created with "aurora job 
> create" command
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27828: Move read-modify-write logic out of AttributeStore.Mutable for simpler layering.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27828/
---

(Updated Nov. 11, 2014, 7:27 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

Rebase + fixup WriteAheadStorageTest.


Bugs: AURORA-913
https://issues.apache.org/jira/browse/AURORA-913


Repository: aurora


Description
---

Simplify `AttributeStore.Mutable` by removing `setMaintenanceMode`, and remove 
the silent merging behavior performed internally.

This change sets the stage for fixing AURORA-913, where i will introduce a thin 
layer over `HostAttributeStore.Mutable` for the purposes of advertising when 
attributes change.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
a7a807dd87bf695cb744891256950c4d4840969a 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
2d382f752fb8d5997ad1f72100a8e032b7625656 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
21cfebdf11e0652e192cf08e35c8581b1246f7b5 
  src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 
8ca0dfdf07852c41dfcf43fad298780d0a45153b 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
c8b3095ef44b3221e8c58f2b2ecd58e3175f13b4 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
5790b84553de6ab7239234fe0030f7cf98766763 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
af15c9543a9be4ad9916423ae650114d2b33aec2 
  
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
 4d96761e04a342ad3564bdba4afdc889f27ac123 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 
c0a1aa5096b507b440d4fe55d68292331c3cd903 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
55a47844aea4c7ced5d7053a62bef29dc97698da 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 ab0d501aac0c187d8fb9791ad43ef586b3aed5e7 
  
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
 792c9fe58c0990180e4f7cac06f793778164b2fe 

Diff: https://reviews.apache.org/r/27828/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 27828: Move read-modify-write logic out of AttributeStore.Mutable for simpler layering.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27828/
---

(Updated Nov. 11, 2014, 7:23 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

Rebase.


Bugs: AURORA-913
https://issues.apache.org/jira/browse/AURORA-913


Repository: aurora


Description
---

Simplify `AttributeStore.Mutable` by removing `setMaintenanceMode`, and remove 
the silent merging behavior performed internally.

This change sets the stage for fixing AURORA-913, where i will introduce a thin 
layer over `HostAttributeStore.Mutable` for the purposes of advertising when 
attributes change.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
a7a807dd87bf695cb744891256950c4d4840969a 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
2d382f752fb8d5997ad1f72100a8e032b7625656 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
21cfebdf11e0652e192cf08e35c8581b1246f7b5 
  src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 
8ca0dfdf07852c41dfcf43fad298780d0a45153b 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
c8b3095ef44b3221e8c58f2b2ecd58e3175f13b4 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
5790b84553de6ab7239234fe0030f7cf98766763 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
af15c9543a9be4ad9916423ae650114d2b33aec2 
  
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
 4d96761e04a342ad3564bdba4afdc889f27ac123 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 
c0a1aa5096b507b440d4fe55d68292331c3cd903 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
55a47844aea4c7ced5d7053a62bef29dc97698da 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 ab0d501aac0c187d8fb9791ad43ef586b3aed5e7 

Diff: https://reviews.apache.org/r/27828/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 27880: Fix missing paren in review bot.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27880/#review60815
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 11, 2014, 6:31 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27880/
> ---
> 
> (Updated Nov. 11, 2014, 6:31 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bug introduced in https://reviews.apache.org/r/27770
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> 25cb951d71a672c6232c11e21938d6192d147ecf 
> 
> Diff: https://reviews.apache.org/r/27880/diff/
> 
> 
> Testing
> ---
> 
> No outstanding reviews for this to build, but this review will become a 
> guinea pig.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27880: Fix missing paren in review bot.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27880/#review60813
---

Ship it!


Master (a8b38b4) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 11, 2014, 6:31 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27880/
> ---
> 
> (Updated Nov. 11, 2014, 6:31 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bug introduced in https://reviews.apache.org/r/27770
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> 25cb951d71a672c6232c11e21938d6192d147ecf 
> 
> Diff: https://reviews.apache.org/r/27880/diff/
> 
> 
> Testing
> ---
> 
> No outstanding reviews for this to build, but this review will become a 
> guinea pig.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27880: Fix missing paren in review bot.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27880/#review60810
---


@ReviewBot retry

- Joshua Cohen


On Nov. 11, 2014, 6:31 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27880/
> ---
> 
> (Updated Nov. 11, 2014, 6:31 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bug introduced in https://reviews.apache.org/r/27770
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> 25cb951d71a672c6232c11e21938d6192d147ecf 
> 
> Diff: https://reviews.apache.org/r/27880/diff/
> 
> 
> Testing
> ---
> 
> No outstanding reviews for this to build, but this review will become a 
> guinea pig.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27880: Fix missing paren in review bot.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27880/#review60809
---

Ship it!


Master (a8b38b4) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 11, 2014, 6:31 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27880/
> ---
> 
> (Updated Nov. 11, 2014, 6:31 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bug introduced in https://reviews.apache.org/r/27770
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> 25cb951d71a672c6232c11e21938d6192d147ecf 
> 
> Diff: https://reviews.apache.org/r/27880/diff/
> 
> 
> Testing
> ---
> 
> No outstanding reviews for this to build, but this review will become a 
> guinea pig.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 27880: Fix missing paren in review bot.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27880/
---

Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
---

Bug introduced in https://reviews.apache.org/r/27770


Diffs
-

  build-support/jenkins/review_feedback.py 
25cb951d71a672c6232c11e21938d6192d147ecf 

Diff: https://reviews.apache.org/r/27880/diff/


Testing
---

No outstanding reviews for this to build, but this review will become a guinea 
pig.


Thanks,

Bill Farner