Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67988 --- src/main/python/apache/aurora/executor/common/resource_manager.py https://reviews.apache.org/r/29866/#comment112103 Is this an unrelated change that snuck in? src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py https://reviews.apache.org/r/29866/#comment112104 same, this doesn't appear to be related to a pants upgrade - Kevin Sweeney On Jan. 13, 2015, 4:15 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 4:15 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67987 --- Ship it! Rad pants https://reviews.apache.org/r/29866/#comment112102 good idea - Joe Smith On Jan. 13, 2015, 4:15 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 4:15 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
On Jan. 14, 2015, 12:49 a.m., Kevin Sweeney wrote: src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 21 https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21 same, this doesn't appear to be related to a pants upgrade this is to fix the test failure brought up by reviewbot. unclear if it's related to the pants upgrade, but it should be fixed regardless. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67988 --- On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 14, 2015, 12:15 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67996 --- Ship it! Master (a350982) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 14, 2015, 12:15 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Review Request 29873: Fixing batched kill task filtering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-996 https://issues.apache.org/jira/browse/AURORA-996 Repository: aurora Description --- Fixed job status quering in client context to return active tasks where needed. Also, dropped active instance validation from both updater calls as it was hiding a legitimate feature: add new job instances with instance_spec. Diffs - src/main/python/apache/aurora/client/cli/context.py 93587c616afb0b7493a509197361cd76af2e2c97 src/main/python/apache/aurora/client/cli/jobs.py 508c9be556998e47bddcec8dee43f1595497b354 src/main/python/apache/aurora/client/cli/update.py a1617325f08ca252bdba38618aef141504ba7272 src/test/python/apache/aurora/client/cli/test_kill.py b475d737ede8ff0a669a9a9229196a76b43b46b6 src/test/python/apache/aurora/client/cli/test_restart.py a532ead256869c620e6bd96886ce9681b3423d0c Diff: https://reviews.apache.org/r/29873/diff/ Testing --- ./pants src/test/python:all vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello INFO] Checking status of devcluster/www-data/prod/hello INFO] No tasks to kill found for job devcluster/www-data/prod/hello Job killall succeeded Thanks, Maxim Khutornenko
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68013 --- Partial review, looks good but some questions on the scheduler side of the code. docs/configuration-reference.md https://reviews.apache.org/r/28920/#comment112145 Qualify that this only applies to the docker containerizer? examples/jobs/docker/hello_docker.aurora https://reviews.apache.org/r/28920/#comment112150 since we're supposedly running in the python2.7 container could we show our version? Bonus points, use a python3 container to prove that this is different from the host version? examples/vagrant/aurorabuild.sh https://reviews.apache.org/r/28920/#comment112151 is this wrapper necessary anymore? src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java https://reviews.apache.org/r/28920/#comment112152 nit: 2sp here. src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java https://reviews.apache.org/r/28920/#comment112153 Use the Guava Splitter class here (but see Bill's comment above re: letting Args do this for us). src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java https://reviews.apache.org/r/28920/#comment112154 no need for this loop - protobuf provides .addAllResources() src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java https://reviews.apache.org/r/28920/#comment112155 boolean - prefer value types to avoid nullability. src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java https://reviews.apache.org/r/28920/#comment112156 boolean here src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java https://reviews.apache.org/r/28920/#comment112157 Why not derive this from the ContainerType enum from the TaskConfig? src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java https://reviews.apache.org/r/28920/#comment112158 How would you feel about removing these suffixes from the scheduler and letting the user specify an executor-per-container-type? I can see a deployment scenario where the executor is baked into the docker containers. src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java https://reviews.apache.org/r/28920/#comment112160 why the wrap/unwrap combination here? src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java https://reviews.apache.org/r/28920/#comment112159 Can the thermos observer detect container checkpoints any other way? IMO that would be preferable to plumbing it in on the scheduler-side. - Kevin Sweeney On Jan. 12, 2015, 5:11 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 12, 2015, 5:11 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126
Re: Review Request 29463: Upgrade pystachio to 0.7.4.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29463/#review67909 --- Ship it! Ship It! - Kevin Sweeney On Dec. 29, 2014, 11:26 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29463/ --- (Updated Dec. 29, 2014, 11:26 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Upgrade pystachio to 0.7.4. This fixes a bug with loading a serialized pystachio config with multiply nested include statements. Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 Diff: https://reviews.apache.org/r/29463/diff/ Testing --- build-support/jenkins/build.sh Thanks, Brian Wickman
Re: Review Request 29463: Upgrade pystachio to 0.7.4.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29463/#review67908 --- @kevints, ping - Brian Wickman On Dec. 29, 2014, 7:26 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29463/ --- (Updated Dec. 29, 2014, 7:26 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Upgrade pystachio to 0.7.4. This fixes a bug with loading a serialized pystachio config with multiply nested include statements. Diffs - 3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 Diff: https://reviews.apache.org/r/29463/diff/ Testing --- build-support/jenkins/build.sh Thanks, Brian Wickman
Re: Review Request 29717: Remove dynamic command hooks and dynamic hook policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29717/#review67912 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 13, 2015, 1:33 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29717/ --- (Updated Jan. 13, 2015, 1:33 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- This patch removes the dynamic hooks functionality and dynamic hook policy mechanism from the client. As far as I can tell they are currently unused and add a lot of complexity to the client. Diffs - docs/design/command-hooks.md cc56218625edfd1b255f1ca18ae91c32e2dcccef src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/test/python/apache/aurora/client/cli/AuroraHooks e27fcc81d6092b3b42f9a2948e3955d8f6963a14 src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks 9a221591250f4d0d3b1b75f90b8b4cf8f95ee4b9 src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks 5dc5907b9ae87632f91084e43be319c6f1b4f437 src/test/python/apache/aurora/client/cli/test_command_hooks.py 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 Diff: https://reviews.apache.org/r/29717/diff/ Testing --- ./pants build --timeout=60 src/test/python/apache/aurora/client/cli:command_hooks -vxs Thanks, Zameer Manji
Review Request 29862: Remove documentation for nonexistent pystachio feature.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29862/ --- Review request for Aurora and Brian Wickman. Summary (updated) - Remove documentation for nonexistent pystachio feature. Bugs: AURORA-1008 https://issues.apache.org/jira/browse/AURORA-1008 Repository: aurora Description (updated) --- Remove documentation for nonexistent pystachio feature. Diffs (updated) - docs/configuration-tutorial.md b64dc14649939083821ac682b08a5d3eb6e8ae41 Diff: https://reviews.apache.org/r/29862/diff/ Testing --- Thanks, Kevin Sweeney
Re: Review Request 29873: Fixing batched kill task filtering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/#review68008 --- Master (a350982) is red with this patch. ./build-support/jenkins/build.sh :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///x1/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage of 0.8929194773338365 exceeds minimum coverage of 0.89. Branch coverage of 0.8393782383419689 exceeds minimum coverage of 0.835. :check :build :api:assemble :api:compileTestJava UP-TO-DATE :api:processTestResources UP-TO-DATE :api:testClasses UP-TO-DATE :api:test UP-TO-DATE :api:check UP-TO-DATE :api:build :buildSrc:compileJava UP-TO-DATE :buildSrc:processResources UP-TO-DATE :buildSrc:classes UP-TO-DATE :buildSrc:jar :buildSrc:assemble :buildSrc:compileTestJava UP-TO-DATE :buildSrc:processTestResources UP-TO-DATE :buildSrc:testClasses UP-TO-DATE :buildSrc:test UP-TO-DATE :buildSrc:check UP-TO-DATE :buildSrc:build BUILD SUCCESSFUL Total time: 2 mins 53.927 secs + export PIP_DEFAULT_TIMEOUT=60 + PIP_DEFAULT_TIMEOUT=60 + mkdir -p third_party + pip install -d third_party -r /dev/fd/63 ++ grep -v mesos.native 3rdparty/python/requirements.txt ./build-support/jenkins/build.sh: line 28: pip: command not found grep: write error: Broken pipe I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 14, 2015, 1:16 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/ --- (Updated Jan. 14, 2015, 1:16 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-996 https://issues.apache.org/jira/browse/AURORA-996 Repository: aurora Description --- Fixed job status quering in client context to return active tasks where needed. Also, dropped active instance validation from both updater calls as it was hiding a legitimate feature: add new job instances with instance_spec. Diffs - src/main/python/apache/aurora/client/cli/context.py 93587c616afb0b7493a509197361cd76af2e2c97 src/main/python/apache/aurora/client/cli/jobs.py 508c9be556998e47bddcec8dee43f1595497b354 src/main/python/apache/aurora/client/cli/update.py a1617325f08ca252bdba38618aef141504ba7272 src/test/python/apache/aurora/client/cli/test_kill.py b475d737ede8ff0a669a9a9229196a76b43b46b6 src/test/python/apache/aurora/client/cli/test_restart.py a532ead256869c620e6bd96886ce9681b3423d0c Diff: https://reviews.apache.org/r/29873/diff/ Testing --- ./pants src/test/python:all vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello INFO] Checking status of devcluster/www-data/prod/hello INFO] No tasks to kill found for job devcluster/www-data/prod/hello Job killall succeeded Thanks, Maxim Khutornenko
Re: Review Request 29866: Upgrade pants to 0.0.27
On Jan. 14, 2015, 12:07 a.m., Maxim Khutornenko wrote: Please, update docs/developing-aurora-client.md as well. derp not sure how i missed that. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67979 --- On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 14, 2015, 12:15 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 28920: Add support for docker containers to aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67985
---
Mostly style and configuration ergonomics remaining. Once these are addressed
my final pass before giving a ship will be assessing for complete test coverage.
docs/configuration-reference.md
https://reviews.apache.org/r/28920/#comment112074
Flag as experimental somehow, here and in other new doc portions.
examples/vagrant/upstart/aurora-scheduler.conf
https://reviews.apache.org/r/28920/#comment112075
remove extra newline
examples/vagrant/upstart/mesos-slave.conf
https://reviews.apache.org/r/28920/#comment112076
Is this afflicted by MESOS-2215? I'm worried (read: certain) people will
copy/paste the example here, and likely be set up for failure. I don't have an
answer, curious what your thoughts are.
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
https://reviews.apache.org/r/28920/#comment112077
The Args system handles multi-valued args, comma-separated. Change to
`ArgListString` and this will Just Work.
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
https://reviews.apache.org/r/28920/#comment112107
Should this instead be a list of allowed `ContainerType`s? If we want this
to support arbitrary container types, seems like a good litmus test for success
is absense of the string 'docker' from code and comments. Of course, there may
be special cases that dictate otherwise.
src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java
https://reviews.apache.org/r/28920/#comment112088
Please grep for 'wrapper' to make sure that code, comments, and docs refer
to this as executor resources.
src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java
https://reviews.apache.org/r/28920/#comment112084
This one is not optional.
src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java
https://reviews.apache.org/r/28920/#comment112083
Feel free to omit A[n] optional from all of these, as the type
self-documents.
src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java
https://reviews.apache.org/r/28920/#comment112078
blank line between wrapped method signature and body.
src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java
https://reviews.apache.org/r/28920/#comment112079
space-pad the colon:
for (String resource : splitResources) {
src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java
https://reviews.apache.org/r/28920/#comment112089
shell=true is default, is there a reason you want to explicitly set it?
I'm not against it, just want to be on the same page.
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
https://reviews.apache.org/r/28920/#comment112115
I would love to see another check for whether the scheduler is configured
to allow docker mounts. In fact, i'm not sure if `allow_docker_mounts` (or its
replacement, based on another comment) should be plumbed anywhere else from
here.
Reasoning here is that only the cluster administrator should need to know
what's on the slave command line.
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
https://reviews.apache.org/r/28920/#comment112090
please break these out and give a separate error message
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
https://reviews.apache.org/r/28920/#comment112092
kick the first arg onto the next line, and use +4 indent for all (so a
method rename doesn't move these out of alignment).
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
https://reviews.apache.org/r/28920/#comment112091
blank line above
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
https://reviews.apache.org/r/28920/#comment112095
Can you include a comment explaining why this is necessary? Will be good
for posterity.
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
https://reviews.apache.org/r/28920/#comment112100
Prefer inserting line breaks to keep the longest continuous statement
unbroken. In this case, i would break after the `=` and put the rest on one
line.
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
https://reviews.apache.org/r/28920/#comment112096
blank line before
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
https://reviews.apache.org/r/28920/#comment112097
blank line before
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
https://reviews.apache.org/r/28920/#comment112098
blank line before
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java
https://reviews.apache.org/r/28920/#comment112101
line break after the paren, +4
Re: Review Request 29717: Remove dynamic command hooks and dynamic hook policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29717/#review67904 --- @ReviewBot retry Also ping Maxim. - Zameer Manji On Jan. 12, 2015, 5:33 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29717/ --- (Updated Jan. 12, 2015, 5:33 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- This patch removes the dynamic hooks functionality and dynamic hook policy mechanism from the client. As far as I can tell they are currently unused and add a lot of complexity to the client. Diffs - docs/design/command-hooks.md cc56218625edfd1b255f1ca18ae91c32e2dcccef src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/test/python/apache/aurora/client/cli/AuroraHooks e27fcc81d6092b3b42f9a2948e3955d8f6963a14 src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks 9a221591250f4d0d3b1b75f90b8b4cf8f95ee4b9 src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks 5dc5907b9ae87632f91084e43be319c6f1b4f437 src/test/python/apache/aurora/client/cli/test_command_hooks.py 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 Diff: https://reviews.apache.org/r/29717/diff/ Testing --- ./pants build --timeout=60 src/test/python/apache/aurora/client/cli:command_hooks -vxs Thanks, Zameer Manji
Re: Review Request 29862: Remove documentation for nonexistent pystachio feature.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29862/#review67926 --- Ship it! Master (a350982) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 13, 2015, 7:45 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29862/ --- (Updated Jan. 13, 2015, 7:45 p.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-1008 https://issues.apache.org/jira/browse/AURORA-1008 Repository: aurora Description --- Remove documentation for nonexistent pystachio feature. Diffs - docs/configuration-tutorial.md b64dc14649939083821ac682b08a5d3eb6e8ae41 Diff: https://reviews.apache.org/r/29862/diff/ Testing --- Thanks, Kevin Sweeney
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67965 --- @ReviewBot retry - Brian Wickman On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 9:51 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
On Jan. 13, 2015, 11:01 p.m., Brian Wickman wrote: @ReviewBot retry n/m this is reproducible. just not caught by end to end test. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67965 --- On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 9:51 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29862: Remove documentation for nonexistent pystachio feature.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29862/#review67937 --- Ship it! Ship It! - Joshua Cohen On Jan. 13, 2015, 7:45 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29862/ --- (Updated Jan. 13, 2015, 7:45 p.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-1008 https://issues.apache.org/jira/browse/AURORA-1008 Repository: aurora Description --- Remove documentation for nonexistent pystachio feature. Diffs - docs/configuration-tutorial.md b64dc14649939083821ac682b08a5d3eb6e8ae41 Diff: https://reviews.apache.org/r/29862/diff/ Testing --- Thanks, Kevin Sweeney
Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67957 --- Master (a350982) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.announcer . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.executor_timeout . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.kill_manager . SUCCESS src.test.python.apache.aurora.executor.common.resource_manager_integration . FAILURE src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.bin.test_thermos . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.common.test_planner . SUCCESS src.test.python.apache.thermos.common.test_task_planner . SUCCESS src.test.python.apache.thermos.config.test_schema . SUCCESS src.test.python.apache.thermos.core.test_angry . SUCCESS src.test.python.apache.thermos.core.test_ephemerals . SUCCESS src.test.python.apache.thermos.core.test_failing_runner . SUCCESS src.test.python.apache.thermos.core.test_failure_limit . SUCCESS src.test.python.apache.thermos.core.test_finalization . SUCCESS src.test.python.apache.thermos.core.test_helper . SUCCESS src.test.python.apache.thermos.core.test_process . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 9:51 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67967 --- build-support/python/make-pycharm-virtualenv https://reviews.apache.org/r/29866/#comment112054 We changed to src/test/python:: in the build script, but we're still using src/test/python:all here. Should they be the same? pants https://reviews.apache.org/r/29866/#comment112055 What if we have a file in the root like pants.version that's sourced by this and by update-pants-requirements rather than having to keep the version in sync between the two? - Joshua Cohen On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 9:51 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 11:20 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- Fix ResourceManager integration test. Start using .pantsversion again. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs (updated) - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67977 --- Ship it! Ship It! - Joshua Cohen On Jan. 13, 2015, 11:20 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 11:20 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67979 --- Ship it! Please, update docs/developing-aurora-client.md as well. - Maxim Khutornenko On Jan. 13, 2015, 11:20 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 11:20 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 14, 2015, 12:15 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- Update developing-aurora-client.md Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs (updated) - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
Re: Review Request 29866: Upgrade pants to 0.0.27
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67982 --- Ship it! Master (a350982) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 13, 2015, 11:20 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/ --- (Updated Jan. 13, 2015, 11:20 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Ports aurora repo to use pants 0.0.27 using the new pants new command processor. Diffs - .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c Diff: https://reviews.apache.org/r/29866/diff/ Testing --- bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Brian Wickman
