Review Request 29971: Fix path to stylesheet in slaves and utilization templates.

2015-01-16 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29971/
---

Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: AURORA-1019
https://issues.apache.org/jira/browse/AURORA-1019


Repository: aurora


Description
---

Fix path to stylesheet in slaves and utilization templates.


Diffs
-

  src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
05541f8f1deabc4b60001ac85b8fffa04b03ebf2 
  src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
73f86d51e9bb0179b774554718ad49ce00ba5487 

Diff: https://reviews.apache.org/r/29971/diff/


Testing
---

Verified styles were present when hitting those endpoints in vagrant.


Thanks,

Joshua Cohen



Re: Review Request 29901: De-flakify resource_manager_integration test

2015-01-16 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29901/
---

(Updated Jan. 16, 2015, 7:10 p.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Changes
---

Assert on call_count.


Repository: aurora


Description
---

De-flakify ResourceManager integration test.


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/resource_manager.py 
bf69e7e60ae4dd857243d8b040a70daca008ea28 
  src/main/python/apache/thermos/monitoring/resource.py 
7b5bbe01810008c4d39b9dfee6521af01021a7ca 
  src/test/python/apache/aurora/executor/common/BUILD 
395ced27998def18eace2cbd46c736404c3d6411 
  
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
 e3c766f9b7bf989c0790281231957947d2cda52a 

Diff: https://reviews.apache.org/r/29901/diff/


Testing
---

./pants goal test --no-test-pytest-fast 
src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman



Re: Review Request 29866: Upgrade pants to 0.0.27

2015-01-16 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/
---

(Updated Jan. 16, 2015, 7:16 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
---

Remove changes to ResourceManager test.


Repository: aurora


Description
---

Ports aurora repo to use pants 0.0.27 using the new pants new command processor.


Diffs (updated)
-

  .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
  build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
  build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
  build-support/python/make-pycharm-virtualenv 
85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
  build-support/python/update-pants-requirements 
523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
  build-support/release/make-python-sdists 
2f437d33928cc429a79aedb00247d472953fbb95 
  docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
  examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
  pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
503e62f4cac872b14f6985b5bccc3e4dfcf81789 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 

Diff: https://reviews.apache.org/r/29866/diff/


Testing
---

bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Brian Wickman



Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.

2015-01-16 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29971/#review68457
---

Ship it!


Ship It!

- David McLaughlin


On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29971/
 ---
 
 (Updated Jan. 16, 2015, 7:08 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Bill Farner.
 
 
 Bugs: AURORA-1019
 https://issues.apache.org/jira/browse/AURORA-1019
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix path to stylesheet in slaves and utilization templates.
 
 
 Diffs
 -
 
   src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 
   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
 73f86d51e9bb0179b774554718ad49ce00ba5487 
 
 Diff: https://reviews.apache.org/r/29971/diff/
 
 
 Testing
 ---
 
 Verified styles were present when hitting those endpoints in vagrant.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.

2015-01-16 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29971/#review68461
---


Master (1346c4f) is red with this patch.
  ./build-support/jenkins/build.sh

  File 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder.py,
 line 43, in build
debug=debug).run()
  File 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
 line 88, in run
rv = self._run_tests([target], stdout, stderr)
  File 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
 line 316, in _run_tests
with self._test_runner(targets, stdout, stderr) as (pex, test_args):
  File /usr/lib/python2.7/contextlib.py, line 17, in __enter__
return self.gen.next()
  File 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
 line 295, in _test_runner
builder = chroot.dump()
  File 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py,
 line 191, in dump
conn_timeout=self._conn_timeout)
  File 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py,
 line 100, in resolve_multi
platform=platform)
  File 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py,
 line 101, in resolve
raise Unsatisfiable('Cannot satisfy requirements: %s' % 
requirement_set[requirement.key])
Unsatisfiable: Cannot satisfy requirements: [PythonRequirement(pytest-cov)]


Usage: 
  pants build (options) [spec] (build args)
  pants build (options) [spec]... -- (build args)

Options:
  --version show program's version number and exit
  --no-pantsrc  Specifies that pantsrc files should be ignored.
  --log-exitLog an exit message on success or failure.
  -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
  -i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use.  Uses
Requirement format from pkg_resources, e.g.
'CPython=2.6,3' or 'PyPy'. By default, no
constraints are used.  Multiple constraints may be
added.  They will be ORed together.
  -v, --verbose Show verbose output.
  -f, --fastRun tests in a single chroot.

Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.


I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29971/
 ---
 
 (Updated Jan. 16, 2015, 7:08 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Bill Farner.
 
 
 Bugs: AURORA-1019
 https://issues.apache.org/jira/browse/AURORA-1019
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix path to stylesheet in slaves and utilization templates.
 
 
 Diffs
 -
 
   src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 
   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
 73f86d51e9bb0179b774554718ad49ce00ba5487 
 
 Diff: https://reviews.apache.org/r/29971/diff/
 
 
 Testing
 ---
 
 Verified styles were present when hitting those endpoints in vagrant.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 29901: De-flakify resource_manager_integration test

2015-01-16 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29901/#review68470
---


This patch does not apply cleanly on master (1346c4f), do you need to rebase?

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Jan. 16, 2015, 7:10 p.m., Brian Wickman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29901/
 ---
 
 (Updated Jan. 16, 2015, 7:10 p.m.)
 
 
 Review request for Aurora, Joshua Cohen and Kevin Sweeney.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 De-flakify ResourceManager integration test.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/executor/common/resource_manager.py 
 bf69e7e60ae4dd857243d8b040a70daca008ea28 
   src/main/python/apache/thermos/monitoring/resource.py 
 7b5bbe01810008c4d39b9dfee6521af01021a7ca 
   src/test/python/apache/aurora/executor/common/BUILD 
 395ced27998def18eace2cbd46c736404c3d6411 
   
 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
  e3c766f9b7bf989c0790281231957947d2cda52a 
 
 Diff: https://reviews.apache.org/r/29901/diff/
 
 
 Testing
 ---
 
 ./pants goal test --no-test-pytest-fast 
 src/test/python/apache/aurora/executor/common::
 
 
 Thanks,
 
 Brian Wickman
 




Re: Review Request 29866: Upgrade pants to 0.0.27

2015-01-16 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review68469
---

Ship it!


Master (1346c4f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Jan. 16, 2015, 7:16 p.m., Brian Wickman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29866/
 ---
 
 (Updated Jan. 16, 2015, 7:16 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Ports aurora repo to use pants 0.0.27 using the new pants new command 
 processor.
 
 
 Diffs
 -
 
   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
   build-support/pants_requirements.txt 
 9a790f973cc7560980d43d5a1097338ff88a0397 
   build-support/python/make-pycharm-virtualenv 
 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
   build-support/python/update-pants-requirements 
 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
   build-support/release/make-python-sdists 
 2f437d33928cc429a79aedb00247d472953fbb95 
   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
   src/test/python/apache/aurora/executor/test_thermos_executor.py 
 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
 f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
 
 Diff: https://reviews.apache.org/r/29866/diff/
 
 
 Testing
 ---
 
 bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 
 Thanks,
 
 Brian Wickman
 




Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.

2015-01-16 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29971/#review68477
---


@ReviewBot retry

- Joshua Cohen


On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29971/
 ---
 
 (Updated Jan. 16, 2015, 7:08 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Bill Farner.
 
 
 Bugs: AURORA-1019
 https://issues.apache.org/jira/browse/AURORA-1019
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix path to stylesheet in slaves and utilization templates.
 
 
 Diffs
 -
 
   src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 
   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
 73f86d51e9bb0179b774554718ad49ce00ba5487 
 
 Diff: https://reviews.apache.org/r/29971/diff/
 
 
 Testing
 ---
 
 Verified styles were present when hitting those endpoints in vagrant.
 
 
 Thanks,
 
 Joshua Cohen
 




Review Request 29984: Minor clean up to mock usage in resource manager integration tests.

2015-01-16 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/
---

Review request for Aurora, Kevin Sweeney and Brian Wickman.


Repository: aurora


Description
---

Minor clean up to mock usage in resource manager integration tests.

We didn't need to wrap the mock disk collector in a lambda, just rather than 
asserting on the mock class, we instead needed to assert on its return value 
(the instance).


Diffs
-

  
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
 bb3045700c2870329e175db44873dcb990226c7a 

Diff: https://reviews.apache.org/r/29984/diff/


Testing
---

./pants build 
src/test/python/apache/aurora/executor/common:resource_manager_integration


Thanks,

Joshua Cohen



Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-16 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29942/#review68486
---

Ship it!


This is now on origin/master:
```
$ git log -1 origin/master
commit 056c35b169874023760edca4fcc222c1ad21d8b1
Author: Joshua Cohen jco...@twopensource.com
Date:   Thu Jan 15 11:49:53 2015 -0800

Updates so client will run in PyCharm.
```

- Bill Farner


On Jan. 15, 2015, 11:58 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29942/
 ---
 
 (Updated Jan. 15, 2015, 11:58 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Updates so client will run in PyCharm.
 
 
 Diffs
 -
 
   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
   docs/images/debug-client-test.png PRE-CREATION 
   docs/images/debugging-client-test.png PRE-CREATION 
   examples/vagrant/clusters.json PRE-CREATION 
   examples/vagrant/provision-dev-cluster.sh 
 7af4b52a6876268a97630279221bb98d9b04efad 
   src/main/python/apache/aurora/client/cli/__init__.py 
 a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 
 
 Diff: https://reviews.apache.org/r/29942/diff/
 
 
 Testing
 ---
 
 Ran/debug client in PyCharm.
 Previewed markdown doc changes here: 
 https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.

2015-01-16 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29971/#review68489
---

Ship it!


Ship It!

- Bill Farner


On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29971/
 ---
 
 (Updated Jan. 16, 2015, 7:08 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Bill Farner.
 
 
 Bugs: AURORA-1019
 https://issues.apache.org/jira/browse/AURORA-1019
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix path to stylesheet in slaves and utilization templates.
 
 
 Diffs
 -
 
   src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 
   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
 73f86d51e9bb0179b774554718ad49ce00ba5487 
 
 Diff: https://reviews.apache.org/r/29971/diff/
 
 
 Testing
 ---
 
 Verified styles were present when hitting those endpoints in vagrant.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.

2015-01-16 Thread Bill Farner


 On Jan. 16, 2015, 10:29 p.m., Bill Farner wrote:
  Ship It!

This is now on master:
```
$ git log -1 origin/master
commit da74e282befa2dcd9e2084120c31a60bcfc5ba33
Author: Joshua Cohen jco...@twopensource.com
Date:   Fri Jan 16 14:29:31 2015 -0800

Fix path to stylesheet in slaves and utilization templates.

Bugs closed: AURORA-1019

Reviewed at https://reviews.apache.org/r/29971/
```


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29971/#review68489
---


On Jan. 16, 2015, 7:08 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29971/
 ---
 
 (Updated Jan. 16, 2015, 7:08 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Bill Farner.
 
 
 Bugs: AURORA-1019
 https://issues.apache.org/jira/browse/AURORA-1019
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fix path to stylesheet in slaves and utilization templates.
 
 
 Diffs
 -
 
   src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
 05541f8f1deabc4b60001ac85b8fffa04b03ebf2 
   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
 73f86d51e9bb0179b774554718ad49ce00ba5487 
 
 Diff: https://reviews.apache.org/r/29971/diff/
 
 
 Testing
 ---
 
 Verified styles were present when hitting those endpoints in vagrant.
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 29866: Upgrade pants to 0.0.27

2015-01-16 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review68494
---

Ship it!


Thanks for doing this! Make sure you send a note to dev@ about the change

- Kevin Sweeney


On Jan. 16, 2015, 11:16 a.m., Brian Wickman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29866/
 ---
 
 (Updated Jan. 16, 2015, 11:16 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Ports aurora repo to use pants 0.0.27 using the new pants new command 
 processor.
 
 
 Diffs
 -
 
   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
   build-support/pants_requirements.txt 
 9a790f973cc7560980d43d5a1097338ff88a0397 
   build-support/python/make-pycharm-virtualenv 
 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
   build-support/python/update-pants-requirements 
 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
   build-support/release/make-python-sdists 
 2f437d33928cc429a79aedb00247d472953fbb95 
   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
   src/test/python/apache/aurora/executor/test_thermos_executor.py 
 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
 f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
 
 Diff: https://reviews.apache.org/r/29866/diff/
 
 
 Testing
 ---
 
 bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 
 Thanks,
 
 Brian Wickman
 




Review Request 30000: Bump the minimum allocation for thermos to 256MB of RAM.

2015-01-16 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-1021
https://issues.apache.org/jira/browse/AURORA-1021


Repository: aurora


Description
---

This increase will prevent jobs with small resource requirements from OOMing if
there is no executor overhead.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
5bf283062c9d119ff91ed45da8b236e36d0fc9aa 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/3/diff/


Testing
---

./gradlew clean test


Thanks,

Zameer Manji



Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-16 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review68523
---

Ship it!


Sorry for the delay on this - i actually thought it was already committed.

Only remaining request is for a markdown doc section calling out the use case 
and solution here.

- Bill Farner


On Jan. 8, 2015, 5:25 p.m., Steve Niemitz wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29464/
 ---
 
 (Updated Jan. 8, 2015, 5:25 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 I've added a new flag for the aurora scheduler, -hostname which can override 
 the scheduler server address published into ZK.
 
 This is useful for cases such as running the scheduler in EC2, where the 
 autodetected local address is actual an interal IP and not the public address 
 of the machine.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
   
 src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
  PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
 cf173850635572c0df38bdd5cb14de8ce2016bf7 
   src/main/python/apache/aurora/executor/common/announcer.py 
 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
   src/main/python/apache/aurora/executor/thermos_task_runner.py 
 5e4bd65537d186459003c0b9434f1b769e04f448 
   src/main/python/apache/thermos/bin/thermos_runner.py 
 647de2771f301b17de33d8b45198c211d2e84367 
   src/main/python/apache/thermos/core/runner.py 
 8aac6b50c66080abbb5308b367e9f74c487f42e3 
   
 src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
  PRE-CREATION 
   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
 5e54364a49a208bd5f19b9649633dc8feca591e9 
   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
 fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
 c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
   src/test/python/apache/aurora/executor/common/test_announcer.py 
 e329a90b8fba43611f5120e2a5ee82220dbe2a91 
 
 Diff: https://reviews.apache.org/r/29464/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Steve Niemitz
 




Re: Review Request 30000: Bump the minimum allocation for thermos to 256MB of RAM.

2015-01-16 Thread Zameer Manji


 On Jan. 16, 2015, 5:14 p.m., Bill Farner wrote:
  LGTM, but i really think we should reject unreasonably-small tasks rather 
  than silently modifying them.  Please file a ticket to address that way.  
  This has the bonus of reducing complexity in our code.

https://issues.apache.org/jira/browse/AURORA-1022


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3/#review68524
---


On Jan. 16, 2015, 5:08 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/3/
 ---
 
 (Updated Jan. 16, 2015, 5:08 p.m.)
 
 
 Review request for Aurora and Bill Farner.
 
 
 Bugs: AURORA-1021
 https://issues.apache.org/jira/browse/AURORA-1021
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This increase will prevent jobs with small resource requirements from OOMing 
 if
 there is no executor overhead.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
 5bf283062c9d119ff91ed45da8b236e36d0fc9aa 
   
 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/3/diff/
 
 
 Testing
 ---
 
 ./gradlew clean test
 
 
 Thanks,
 
 Zameer Manji