Re: Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

2014-06-23 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22894/#review46465
---

Ship it!


Ship It!

- Bill Farner


On June 23, 2014, 10:17 p.m., Brian Wickman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22894/
 ---
 
 (Updated June 23, 2014, 10:17 p.m.)
 
 
 Review request for Aurora and Joe Smith.
 
 
 Bugs: AURORA-543
 https://issues.apache.org/jira/browse/AURORA-543
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Resources should be an allowed dependency of python libraries within 
 src/main/python.
 
 
 Diffs
 -
 
   BUILD 24be125b50a883381dc2f9decd0a70e906b007f5 
 
 Diff: https://reviews.apache.org/r/22894/diff/
 
 
 Testing
 ---
 
 ./pants src/main/python/apache/thermos/observer/bin:thermos_observer  unzip 
 -l dist/thermos_observer.pex to validate contents with .tpl files.
 
 
 Thanks,
 
 Brian Wickman
 




Re: Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

2014-06-23 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22894/
---

(Updated June 23, 2014, 10:38 p.m.)


Review request for Aurora, Joe Smith and Deprecated Use kevints.


Changes
---

+committer


Bugs: AURORA-543
https://issues.apache.org/jira/browse/AURORA-543


Repository: aurora


Description
---

Resources should be an allowed dependency of python libraries within 
src/main/python.


Diffs
-

  BUILD 24be125b50a883381dc2f9decd0a70e906b007f5 

Diff: https://reviews.apache.org/r/22894/diff/


Testing
---

./pants src/main/python/apache/thermos/observer/bin:thermos_observer  unzip 
-l dist/thermos_observer.pex to validate contents with .tpl files.


Thanks,

Brian Wickman



Re: Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

2014-06-23 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22894/
---

(Updated June 23, 2014, 10:38 p.m.)


Review request for Aurora, Joe Smith and Bill Farner.


Changes
---

i am an idiot.


Bugs: AURORA-543
https://issues.apache.org/jira/browse/AURORA-543


Repository: aurora


Description
---

Resources should be an allowed dependency of python libraries within 
src/main/python.


Diffs
-

  BUILD 24be125b50a883381dc2f9decd0a70e906b007f5 

Diff: https://reviews.apache.org/r/22894/diff/


Testing
---

./pants src/main/python/apache/thermos/observer/bin:thermos_observer  unzip 
-l dist/thermos_observer.pex to validate contents with .tpl files.


Thanks,

Brian Wickman



Re: Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

2014-06-23 Thread Joe Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22894/#review46471
---

Ship it!


thanks- I should've also run the end-to-end tests as part of the pants 
migration.

- Joe Smith


On June 23, 2014, 3:38 p.m., Brian Wickman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22894/
 ---
 
 (Updated June 23, 2014, 3:38 p.m.)
 
 
 Review request for Aurora, Joe Smith and Bill Farner.
 
 
 Bugs: AURORA-543
 https://issues.apache.org/jira/browse/AURORA-543
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Resources should be an allowed dependency of python libraries within 
 src/main/python.
 
 
 Diffs
 -
 
   BUILD 24be125b50a883381dc2f9decd0a70e906b007f5 
 
 Diff: https://reviews.apache.org/r/22894/diff/
 
 
 Testing
 ---
 
 ./pants src/main/python/apache/thermos/observer/bin:thermos_observer  unzip 
 -l dist/thermos_observer.pex to validate contents with .tpl files.
 
 
 Thanks,
 
 Brian Wickman