Re: Review Request 23180: Export a stat to track number of LOST gc_executors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23180/#review47019 --- Ship it! Once you post the style fix, i'll proceed with the commit. Thanks! src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java https://reviews.apache.org/r/23180/#comment82626 Pull to previous line per preexisting style. - Bill Farner On June 30, 2014, 10:23 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23180/ --- (Updated June 30, 2014, 10:23 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-562 https://issues.apache.org/jira/browse/AURORA-562 Repository: aurora Description --- Track the number of LOST gc_executors Diffs - src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb Diff: https://reviews.apache.org/r/23180/diff/ Testing --- $ ./gradlew test Thanks, Joe Smith
Re: Review Request 23180: Export a stat to track number of LOST gc_executors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23180/ --- (Updated June 30, 2014, 4:12 p.m.) Review request for Aurora and Bill Farner. Changes --- style fix Bugs: AURORA-562 https://issues.apache.org/jira/browse/AURORA-562 Repository: aurora Description --- Track the number of LOST gc_executors Diffs (updated) - src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb Diff: https://reviews.apache.org/r/23180/diff/ Testing --- $ ./gradlew test Thanks, Joe Smith
Re: Review Request 23180: Export a stat to track number of LOST gc_executors
On June 30, 2014, 3:29 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java, line 113 https://reviews.apache.org/r/23180/diff/1/?file=620659#file620659line113 Pull to previous line per preexisting style. good eyes, thanks! - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23180/#review47019 --- On June 30, 2014, 4:12 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23180/ --- (Updated June 30, 2014, 4:12 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-562 https://issues.apache.org/jira/browse/AURORA-562 Repository: aurora Description --- Track the number of LOST gc_executors Diffs - src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb Diff: https://reviews.apache.org/r/23180/diff/ Testing --- $ ./gradlew test Thanks, Joe Smith
