Re: Review Request 29267: Remove unused 3rdparty dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/#review65667 --- Ship it! Please file an issue to implement the equivalent test_executor_builds functionality into CI. - Brian Wickman On Dec. 19, 2014, 8:04 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/ --- (Updated Dec. 19, 2014, 8:04 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Remove unused 3rdparty dependencies. Wire up tests not linked to src/test/python:all Remove unused tests. Diffs - 3rdparty/python/requirements.txt 9d9e966fbfc2ac9c06e6784d41e83c7971e09895 src/test/python/apache/aurora/client/BUILD e31e434723a8aa884bc528987b8aa98077ec0548 src/test/python/apache/aurora/executor/BUILD 3095f2a148b21365ea2f500039adb5710a187fa1 src/test/python/apache/aurora/executor/common/BUILD 4fa80b82f36afbb8224187c63f7d223750d8b5ea src/test/python/apache/aurora/executor/test_executor_builds.py be6800ffc42fed07ca9171d7f36331e284b224b7 Diff: https://reviews.apache.org/r/29267/diff/ Testing --- Listed leaf dependencies: ```bash for target in $(./pants goal list :: 2/dev/null); do if [[ -z $(./pants goal dependees $target 2/dev/null) ]]; then echo $target fi done ``` Thanks, Kevin Sweeney
Re: Review Request 29267: Remove unused 3rdparty dependencies.
On Dec. 19, 2014, 12:17 p.m., Brian Wickman wrote: Please file an issue to implement the equivalent test_executor_builds functionality into CI. Done - filed https://issues.apache.org/jira/browse/AURORA-977 - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/#review65667 --- On Dec. 19, 2014, 12:04 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/ --- (Updated Dec. 19, 2014, 12:04 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Remove unused 3rdparty dependencies. Wire up tests not linked to src/test/python:all Remove unused tests. Diffs - 3rdparty/python/requirements.txt 9d9e966fbfc2ac9c06e6784d41e83c7971e09895 src/test/python/apache/aurora/client/BUILD e31e434723a8aa884bc528987b8aa98077ec0548 src/test/python/apache/aurora/executor/BUILD 3095f2a148b21365ea2f500039adb5710a187fa1 src/test/python/apache/aurora/executor/common/BUILD 4fa80b82f36afbb8224187c63f7d223750d8b5ea src/test/python/apache/aurora/executor/test_executor_builds.py be6800ffc42fed07ca9171d7f36331e284b224b7 Diff: https://reviews.apache.org/r/29267/diff/ Testing --- Listed leaf dependencies: ```bash for target in $(./pants goal list :: 2/dev/null); do if [[ -z $(./pants goal dependees $target 2/dev/null) ]]; then echo $target fi done ``` Thanks, Kevin Sweeney
Re: Review Request 29267: Remove unused 3rdparty dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/#review65672 --- Ship it! Master (9042c56) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 19, 2014, 8:04 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/ --- (Updated Dec. 19, 2014, 8:04 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Remove unused 3rdparty dependencies. Wire up tests not linked to src/test/python:all Remove unused tests. Diffs - 3rdparty/python/requirements.txt 9d9e966fbfc2ac9c06e6784d41e83c7971e09895 src/test/python/apache/aurora/client/BUILD e31e434723a8aa884bc528987b8aa98077ec0548 src/test/python/apache/aurora/executor/BUILD 3095f2a148b21365ea2f500039adb5710a187fa1 src/test/python/apache/aurora/executor/common/BUILD 4fa80b82f36afbb8224187c63f7d223750d8b5ea src/test/python/apache/aurora/executor/test_executor_builds.py be6800ffc42fed07ca9171d7f36331e284b224b7 Diff: https://reviews.apache.org/r/29267/diff/ Testing --- Listed leaf dependencies: ```bash for target in $(./pants goal list :: 2/dev/null); do if [[ -z $(./pants goal dependees $target 2/dev/null) ]]; then echo $target fi done ``` Thanks, Kevin Sweeney