Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76283 --- src/test/python/apache/aurora/client/test_base.py https://reviews.apache.org/r/31913/#comment123803 Mind adding a host maintenance test instead? I am concerned this may drift over time and will no longer represent how the grouping is actually used. - Maxim Khutornenko On March 11, 2015, 2:53 a.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 11, 2015, 2:53 a.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76298 --- src/test/python/apache/aurora/client/test_base.py https://reviews.apache.org/r/31913/#comment123828 what does this line do? - Joe Smith On March 10, 2015, 7:53 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 10, 2015, 7:53 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Maxim's feedback. Found the grouping tests! Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs (updated) - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76303 --- Ship it! Master (f62e0f1) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 12, 2015, 11:13 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76304 --- Ship it! Thanks! - Maxim Khutornenko On March 12, 2015, 11:13 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76307 --- Thanks, it's now on master. - Maxim Khutornenko On March 12, 2015, 11:13 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76305 --- Ship it! +10 :) - Joe Smith On March 12, 2015, 4:13 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 4:13 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/admin/test_host_maintenance.py bb586700814a96b3e83d11728b462a7765e81bc1 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 11, 2015, 2:53 a.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Maxim's feedback. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs (updated) - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76037 --- Ship it! Master (eb392b3) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 11, 2015, 2:53 a.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 11, 2015, 2:53 a.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review75989 --- Ship it! Master (48dc4c7) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 10, 2015, 10:44 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 10, 2015, 10:44 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson
Re: Review Request 31913: Added 'none' host maintenance grouping function.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review75997 --- src/main/python/apache/aurora/client/base.py https://reviews.apache.org/r/31913/#comment123375 This will actually fail upstream in host_maintenance.py when it tries to sort by group: ``` d = defaultdict(set) d[None].add(1) d[None].add(2) s = sorted(d, key=lambda v: v[0]) Traceback (most recent call last): File stdin, line 1, in module File stdin, line 1, in lambda TypeError: 'NoneType' object has no attribute '__getitem__' ``` Please, add a typed default grouping (e.g. ALL) and a correspondent test in test_host_maintenance.py. - Maxim Khutornenko On March 10, 2015, 10:44 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 10, 2015, 10:44 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1181 https://issues.apache.org/jira/browse/AURORA-1181 Repository: aurora Description --- Added 'none' host maintenance grouping function. Diffs - src/main/python/apache/aurora/client/base.py d550c8eeed91f0967e281957b71fcefb0b4cf3b8 src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 Diff: https://reviews.apache.org/r/31913/diff/ Testing --- [drobinson@x1 aurora-github (drobinson/no_grouping)]$ ./pants test src/test/python/apache/aurora/client:base 15:43:40 00:00 [main] (To run a reporting server: ./pants server) 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [setup] 15:43:40 00:00 [parse] Executing tasks in goals: bootstrap - imports - unpack-jars - deferred-sources - gen - resolve - compile - resources - test 15:43:40 00:00 [bootstrap] 15:43:40 00:00 [bootstrap-jvm-tools] 15:43:40 00:00 [imports] 15:43:40 00:00 [ivy-imports] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [unpack-jars] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [deferred-sources] 15:43:40 00:00 [gen] 15:43:40 00:00 [thrift] 15:43:40 00:00 [scrooge] 15:43:40 00:00 [protoc] 15:43:40 00:00 [antlr] 15:43:40 00:00 [ragel] 15:43:40 00:00 [jaxb] 15:43:40 00:00 [wire] 15:43:40 00:00 [aapt] 15:43:40 00:00 [resolve] 15:43:40 00:00 [ivy] 15:43:40 00:00 [compile] 15:43:40 00:00 [compile] 15:43:40 00:00 [jvm] 15:43:40 00:00 [jvm-compilers] 15:43:40 00:00 [resources] 15:43:40 00:00 [prepare] 15:43:40 00:00 [test] 15:43:40 00:00 [run_prep_command] 15:43:40 00:00 [test] 15:43:40 00:00 [pytest] 15:43:40 00:00 [run] == test session starts === platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson