Re: Review Request 32175: Add a test to ensure annotations exist for AuroraSchedulerManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/#review77113 --- Ship it! Ship It! - Bill Farner On March 17, 2015, 9:59 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/ --- (Updated March 17, 2015, 9:59 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1187 https://issues.apache.org/jira/browse/AURORA-1187 Repository: aurora Description --- This addresses review feedback from https://reviews.apache.org/r/32141/ and prevents divergence when api.thrift changes. Diffs - src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32175/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 32175: Add a test to ensure annotations exist for AuroraSchedulerManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/#review76825 --- Master (a419863) is red with this patch. ./build-support/jenkins/build.sh :api:compileJava UP-TO-DATE :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :startScripts :distTar :distZip :assemble :compileJmhJava :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJava :processTestResources :testClasses :checkstyleTest :findbugsJmh :findbugsMain :findbugsTest FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':findbugsTest'. FindBugs rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/findbugs/test.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 2 mins 54.393 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 17, 2015, 9:42 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/ --- (Updated March 17, 2015, 9:42 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1187 https://issues.apache.org/jira/browse/AURORA-1187 Repository: aurora Description --- This addresses review feedback from https://reviews.apache.org/r/32141/ and prevents divergence when api.thrift changes. Diffs - src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32175/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 32175: Add a test to ensure annotations exist for AuroraSchedulerManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/ --- (Updated March 17, 2015, 2:59 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes --- Appease the bot. Bugs: AURORA-1187 https://issues.apache.org/jira/browse/AURORA-1187 Repository: aurora Description --- This addresses review feedback from https://reviews.apache.org/r/32141/ and prevents divergence when api.thrift changes. Diffs (updated) - src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32175/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 32175: Add a test to ensure annotations exist for AuroraSchedulerManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/#review76827 --- Ship it! Master (a419863) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 17, 2015, 9:59 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/ --- (Updated March 17, 2015, 9:59 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1187 https://issues.apache.org/jira/browse/AURORA-1187 Repository: aurora Description --- This addresses review feedback from https://reviews.apache.org/r/32141/ and prevents divergence when api.thrift changes. Diffs - src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32175/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 32175: Add a test to ensure annotations exist for AuroraSchedulerManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/#review76828 --- Ship it! Ship It! - Joshua Cohen On March 17, 2015, 9:59 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/ --- (Updated March 17, 2015, 9:59 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1187 https://issues.apache.org/jira/browse/AURORA-1187 Repository: aurora Description --- This addresses review feedback from https://reviews.apache.org/r/32141/ and prevents divergence when api.thrift changes. Diffs - src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32175/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney
