Re: Review Request 21459: Database-backed implementation of QuotaStore.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/#review46681 --- Ping - needing a review from Kevin. - Bill Farner On June 23, 2014, 9:23 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/ --- (Updated June 23, 2014, 9:23 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-421 https://issues.apache.org/jira/browse/AURORA-421 Repository: aurora Description --- Patched on top of https://reviews.apache.org/r/21132/, not valid until that review is on master. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e365cd6bc256e22ecd9558f5d80f2ef09ec407e5 src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 41755c3344cac66fb1d8f91a55bcde2132950f5c src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 7e98ebf5237b6408824cd1ea0eb562139d1a5d2e src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 49a1ba793673803aff2f06e9ac5a99e9fa77c00a src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 90d9a65ac5e35c77c3b7475ca6e897aff196e60f src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java acafd40b1869904cdd40ad2c89c17ffda94e6920 src/main/resources/org/apache/aurora/scheduler/storage/db/QuotaMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 405fda5e89b8610838d75a33e0e2e449420afccd src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java PRE-CREATION Diff: https://reviews.apache.org/r/21459/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 21459: Database-backed implementation of QuotaStore.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/#review46686 --- Ship it! Ship It! - Kevin Sweeney On June 23, 2014, 2:23 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/ --- (Updated June 23, 2014, 2:23 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-421 https://issues.apache.org/jira/browse/AURORA-421 Repository: aurora Description --- Patched on top of https://reviews.apache.org/r/21132/, not valid until that review is on master. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e365cd6bc256e22ecd9558f5d80f2ef09ec407e5 src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 41755c3344cac66fb1d8f91a55bcde2132950f5c src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 7e98ebf5237b6408824cd1ea0eb562139d1a5d2e src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 49a1ba793673803aff2f06e9ac5a99e9fa77c00a src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 90d9a65ac5e35c77c3b7475ca6e897aff196e60f src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java acafd40b1869904cdd40ad2c89c17ffda94e6920 src/main/resources/org/apache/aurora/scheduler/storage/db/QuotaMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 405fda5e89b8610838d75a33e0e2e449420afccd src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java PRE-CREATION Diff: https://reviews.apache.org/r/21459/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 21459: Database-backed implementation of QuotaStore.
On May 15, 2014, 10:44 p.m., David McLaughlin wrote: src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java, lines 28-36 https://reviews.apache.org/r/21459/diff/1/?file=581909#file581909line28 Please add docs, particularly to merge. Thanks for the nudge, added. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/#review43170 --- On May 14, 2014, 9:22 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/ --- (Updated May 14, 2014, 9:22 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-421 https://issues.apache.org/jira/browse/AURORA-421 Repository: aurora Description --- Patched on top of https://reviews.apache.org/r/21132/, not valid until that review is on master. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 9c6da081e98e26f33bc556566eafac996732cb62 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 283976ab0554dbe6700bb0d2a1b7702c969227e8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 53923627c827131ee4bd93e5c4865d042aee501b src/main/resources/org/apache/aurora/scheduler/storage/db/QuotaMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java PRE-CREATION Diff: https://reviews.apache.org/r/21459/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 21459: Database-backed implementation of QuotaStore.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/ --- (Updated June 23, 2014, 9:23 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-421 https://issues.apache.org/jira/browse/AURORA-421 Repository: aurora Description --- Patched on top of https://reviews.apache.org/r/21132/, not valid until that review is on master. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e365cd6bc256e22ecd9558f5d80f2ef09ec407e5 src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 41755c3344cac66fb1d8f91a55bcde2132950f5c src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 7e98ebf5237b6408824cd1ea0eb562139d1a5d2e src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 49a1ba793673803aff2f06e9ac5a99e9fa77c00a src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 90d9a65ac5e35c77c3b7475ca6e897aff196e60f src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java acafd40b1869904cdd40ad2c89c17ffda94e6920 src/main/resources/org/apache/aurora/scheduler/storage/db/QuotaMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 405fda5e89b8610838d75a33e0e2e449420afccd src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java PRE-CREATION Diff: https://reviews.apache.org/r/21459/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 21459: Database-backed implementation of QuotaStore.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/#review43170 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java https://reviews.apache.org/r/21459/#comment77236 Please add docs, particularly to merge. - David McLaughlin On May 14, 2014, 9:22 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/ --- (Updated May 14, 2014, 9:22 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-421 https://issues.apache.org/jira/browse/AURORA-421 Repository: aurora Description --- Patched on top of https://reviews.apache.org/r/21132/, not valid until that review is on master. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 9c6da081e98e26f33bc556566eafac996732cb62 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 283976ab0554dbe6700bb0d2a1b7702c969227e8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 53923627c827131ee4bd93e5c4865d042aee501b src/main/resources/org/apache/aurora/scheduler/storage/db/QuotaMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java PRE-CREATION Diff: https://reviews.apache.org/r/21459/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Review Request 21459: Database-backed implementation of QuotaStore.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/ --- Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-421 https://issues.apache.org/jira/browse/AURORA-421 Repository: aurora Description --- Patched on top of https://reviews.apache.org/r/21132/, not valid until that review is on master. Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 9c6da081e98e26f33bc556566eafac996732cb62 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 283976ab0554dbe6700bb0d2a1b7702c969227e8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 53923627c827131ee4bd93e5c4865d042aee501b src/main/resources/org/apache/aurora/scheduler/storage/db/QuotaMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java PRE-CREATION Diff: https://reviews.apache.org/r/21459/diff/ Testing --- ./gradlew build Thanks, Bill Farner
