Re: Review Request 22032: first draft of a developing client v2 document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44415 --- docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78793 The executor is an important part of aurora - but how is it part of the client? The executor is entirely a cluster-side thing running on the slaves. docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78794 I think it's worth being complete here. - Mark Chu-Carroll On May 29, 2014, 3:30 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- (Updated May 29, 2014, 3:30 p.m.) Review request for Aurora, David McLaughlin and Henry Saputra. Bugs: aurora-20 https://issues.apache.org/jira/browse/aurora-20 Repository: aurora Description --- first draft of a developing client v2 document. Diffs - docs/developing-aurora-client.md PRE-CREATION Diff: https://reviews.apache.org/r/22032/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 22032: first draft of a developing client v2 document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- (Updated May 30, 2014, 3:40 p.m.) Review request for Aurora, David McLaughlin and Henry Saputra. Changes --- Address reviews. Bugs: aurora-20 https://issues.apache.org/jira/browse/aurora-20 Repository: aurora Description --- first draft of a developing client v2 document. Diffs (updated) - docs/developing-aurora-client.md PRE-CREATION Diff: https://reviews.apache.org/r/22032/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 22032: first draft of a developing client v2 document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- (Updated May 30, 2014, 4:14 p.m.) Review request for Aurora, David McLaughlin and Henry Saputra. Changes --- More changes. Bugs: aurora-20 https://issues.apache.org/jira/browse/aurora-20 Repository: aurora Description --- first draft of a developing client v2 document. Diffs (updated) - docs/developing-aurora-client.md PRE-CREATION Diff: https://reviews.apache.org/r/22032/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 22032: first draft of a developing client v2 document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44436 --- Ship it! Ship It! - Kevin Sweeney On May 30, 2014, 1:14 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- (Updated May 30, 2014, 1:14 p.m.) Review request for Aurora, David McLaughlin and Henry Saputra. Bugs: aurora-20 https://issues.apache.org/jira/browse/aurora-20 Repository: aurora Description --- first draft of a developing client v2 document. Diffs - docs/developing-aurora-client.md PRE-CREATION Diff: https://reviews.apache.org/r/22032/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Review Request 22032: first draft of a developing client v2 document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- Review request for Aurora, David McLaughlin and Henry Saputra. Bugs: aurora-20 https://issues.apache.org/jira/browse/aurora-20 Repository: aurora Description --- first draft of a developing client v2 document. Diffs - docs/developing-aurora-client.md PRE-CREATION Diff: https://reviews.apache.org/r/22032/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 22032: first draft of a developing client v2 document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44291 --- docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78642 The executor is a non-trivial big piece that one will need to be aware of when working on the client. - Kevin Sweeney On May 29, 2014, 12:30 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- (Updated May 29, 2014, 12:30 p.m.) Review request for Aurora, David McLaughlin and Henry Saputra. Bugs: aurora-20 https://issues.apache.org/jira/browse/aurora-20 Repository: aurora Description --- first draft of a developing client v2 document. Diffs - docs/developing-aurora-client.md PRE-CREATION Diff: https://reviews.apache.org/r/22032/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 22032: first draft of a developing client v2 document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44289 --- Ship it! Small nits but looks good overall. Will also you add remote debugging info for the scheduler in the developing-aurora-scheduler.md doc? docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78640 I think Kevin said that the gist already published to Pants's website/doc? docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78639 Missing space between Client and v2 - Henry Saputra On May 29, 2014, 7:30 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- (Updated May 29, 2014, 7:30 p.m.) Review request for Aurora, David McLaughlin and Henry Saputra. Bugs: aurora-20 https://issues.apache.org/jira/browse/aurora-20 Repository: aurora Description --- first draft of a developing client v2 document. Diffs - docs/developing-aurora-client.md PRE-CREATION Diff: https://reviews.apache.org/r/22032/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
Re: Review Request 22032: first draft of a developing client v2 document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44295 --- docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78647 I'd suggest prepending the target with './pants' to give a ready to paste build command. docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78648 s/an/a docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78649 Suggest rewording. It's already obvious from the previous sentence that client API is on top of the primitive API. docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78650 s/client/command line client? docs/developing-aurora-client.md https://reviews.apache.org/r/22032/#comment78651 Perhaps just referencing the vagrant.md instead? - Maxim Khutornenko On May 29, 2014, 7:30 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- (Updated May 29, 2014, 7:30 p.m.) Review request for Aurora, David McLaughlin and Henry Saputra. Bugs: aurora-20 https://issues.apache.org/jira/browse/aurora-20 Repository: aurora Description --- first draft of a developing client v2 document. Diffs - docs/developing-aurora-client.md PRE-CREATION Diff: https://reviews.apache.org/r/22032/diff/ Testing --- n/a Thanks, Mark Chu-Carroll
