Review Request 25913: HTML Grid Fixes in Scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
Re: Review Request 25913: HTML Grid Fixes in Scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- (Updated Sept. 22, 2014, 11:23 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Changes --- Added JIRA. Bugs: AURORA-436 https://issues.apache.org/jira/browse/AURORA-436 Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
Re: Review Request 25913: HTML Grid Fixes in Scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/#review54208 --- Ship it! Ship It! - Bill Farner On Sept. 22, 2014, 11:23 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- (Updated Sept. 22, 2014, 11:23 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-436 https://issues.apache.org/jira/browse/AURORA-436 Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
Re: Review Request 25913: HTML Grid Fixes in Scheduler UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/#review54209 --- Ship it! I'm sure it's fine, but in the future it might be helpful to include screenshots comparable to those in the ticket showing the proper alignment? - Joshua Cohen On Sept. 22, 2014, 11:23 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- (Updated Sept. 22, 2014, 11:23 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-436 https://issues.apache.org/jira/browse/AURORA-436 Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
Re: Review Request 25913: HTML Grid Fixes in Scheduler UI
On Sept. 23, 2014, 12:08 a.m., Joshua Cohen wrote: I'm sure it's fine, but in the future it might be helpful to include screenshots comparable to those in the ticket showing the proper alignment? Ack. Will add before/after screenshots for this type of work in the future. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/#review54209 --- On Sept. 22, 2014, 11:23 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- (Updated Sept. 22, 2014, 11:23 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: AURORA-436 https://issues.apache.org/jira/browse/AURORA-436 Repository: aurora Description --- HTML Grid Fixes in Scheduler UI. Got rid of custom self-closing (void) tags: https://github.com/angular/angular.js/issues/1953. Got rid of nested container-fluids (caused inconsistent margins on role/env pages). Got rid of redundant nested if/else on errors. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 5c4fe96e9c6cb816e497f9dc145f99b6568de887 src/main/resources/org/apache/aurora/scheduler/http/ui/error.html 5b03acaf593ee9d0c32e70f7178fb0e54162c7b8 src/main/resources/org/apache/aurora/scheduler/http/ui/job.html ca1a0f666a1eea7c225f017918f4755c28c57502 src/main/resources/org/apache/aurora/scheduler/http/ui/role.html c3a2fd9f12fe6b99a5253f123002a7a02e51a9ec src/main/resources/org/apache/aurora/scheduler/http/ui/update.html b6cf4f0ed44f33bd5048c5ba9267eabb837dab84 Diff: https://reviews.apache.org/r/25913/diff/ Testing --- Manual testing. These are effectively code cleanup no-ops. The main goal is to avoid people cargo-culting existing bad practices in the name of consistency (which I did with the time-display directives). Thanks, David McLaughlin
