Re: Review Request 32131: Get CI to build python sdists.

2015-03-16 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32131/#review76665
---


Master (1b2a343) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On March 16, 2015, 10:18 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/32131/
 ---
 
 (Updated March 16, 2015, 10:18 p.m.)
 
 
 Review request for Aurora and Brian Wickman.
 
 
 Bugs: AURORA-1174
 https://issues.apache.org/jira/browse/AURORA-1174
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Get CI to build python sdists.
 
 
 Diffs
 -
 
   build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 
   src/main/python/apache/thermos/BUILD 
 0dc035f759dd9949997f0c979b3556a350cf8df7 
   src/main/python/apache/thermos/bin/BUILD 
 669f9930a3590184dc0f8b5c15c36168e715eb03 
 
 Diff: https://reviews.apache.org/r/32131/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 
 Thanks,
 
 Zameer Manji
 




Re: Review Request 32131: Get CI to build python sdists.

2015-03-16 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32131/#review76684
---



src/main/python/apache/thermos/bin/BUILD
https://reviews.apache.org/r/32131/#comment124315

only a minor concern that people depend on this, but it's probably ok to 
remove.


- Brian Wickman


On March 16, 2015, 10:18 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/32131/
 ---
 
 (Updated March 16, 2015, 10:18 p.m.)
 
 
 Review request for Aurora and Brian Wickman.
 
 
 Bugs: AURORA-1174
 https://issues.apache.org/jira/browse/AURORA-1174
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Get CI to build python sdists.
 
 
 Diffs
 -
 
   build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 
   src/main/python/apache/thermos/BUILD 
 0dc035f759dd9949997f0c979b3556a350cf8df7 
   src/main/python/apache/thermos/bin/BUILD 
 669f9930a3590184dc0f8b5c15c36168e715eb03 
 
 Diff: https://reviews.apache.org/r/32131/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 
 Thanks,
 
 Zameer Manji
 




Re: Review Request 32131: Get CI to build python sdists.

2015-03-16 Thread Joe Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32131/#review76713
---

Ship it!


Ship It!

- Joe Smith


On March 16, 2015, 3:18 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/32131/
 ---
 
 (Updated March 16, 2015, 3:18 p.m.)
 
 
 Review request for Aurora and Brian Wickman.
 
 
 Bugs: AURORA-1174
 https://issues.apache.org/jira/browse/AURORA-1174
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Get CI to build python sdists.
 
 
 Diffs
 -
 
   build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 
   src/main/python/apache/thermos/BUILD 
 0dc035f759dd9949997f0c979b3556a350cf8df7 
   src/main/python/apache/thermos/bin/BUILD 
 669f9930a3590184dc0f8b5c15c36168e715eb03 
 
 Diff: https://reviews.apache.org/r/32131/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 
 Thanks,
 
 Zameer Manji
 




Review Request 32131: Get CI to build python sdists.

2015-03-16 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32131/
---

Review request for Aurora and Brian Wickman.


Bugs: AURORA-1174
https://issues.apache.org/jira/browse/AURORA-1174


Repository: aurora


Description
---

Get CI to build python sdists.


Diffs
-

  build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 
  src/main/python/apache/thermos/BUILD 0dc035f759dd9949997f0c979b3556a350cf8df7 
  src/main/python/apache/thermos/bin/BUILD 
669f9930a3590184dc0f8b5c15c36168e715eb03 

Diff: https://reviews.apache.org/r/32131/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Zameer Manji