Re: Review Request 32323: DRY up PMD configuration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32323/#review77261 --- Ship it! Thanks! Good find! - Bill Farner On March 20, 2015, 6:56 p.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32323/ > --- > > (Updated March 20, 2015, 6:56 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Repository: aurora > > > Description > --- > > DRY up PMD configuration. > > > Diffs > - > > build.gradle 4a13e5c4281de53d0ea991235502943a439d1310 > config/pmd/custom.xml 7026d04d8e5c2f185a19c7c44d44698b2fb846c9 > config/pmd/design.xml 2741e407e35826e73bd4dc8335c0ef6294086398 > config/pmd/imports.xml 40dc2260a3c27fd66be352a5974427dcf165ab34 > config/pmd/logging-java.xml 66fecbf14aa61f340678dc23d57a1c074cad824a > config/pmd/naming.xml 233352d57857a0fe09ddbfe9228b48d4c09bb624 > > Diff: https://reviews.apache.org/r/32323/diff/ > > > Testing > --- > > ./gradlew -Pq pmdMain -d > > diffed the "Using rule" log lines from before and after: > > ``` > % diff -u <(sort -u old-rules.txt) <(sort -u new-rules.txt) > % > ``` > > > Thanks, > > Kevin Sweeney > >
Re: Review Request 32323: DRY up PMD configuration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32323/#review77260 --- Ship it! Master (91aec8c) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 20, 2015, 6:56 p.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32323/ > --- > > (Updated March 20, 2015, 6:56 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Repository: aurora > > > Description > --- > > DRY up PMD configuration. > > > Diffs > - > > build.gradle 4a13e5c4281de53d0ea991235502943a439d1310 > config/pmd/custom.xml 7026d04d8e5c2f185a19c7c44d44698b2fb846c9 > config/pmd/design.xml 2741e407e35826e73bd4dc8335c0ef6294086398 > config/pmd/imports.xml 40dc2260a3c27fd66be352a5974427dcf165ab34 > config/pmd/logging-java.xml 66fecbf14aa61f340678dc23d57a1c074cad824a > config/pmd/naming.xml 233352d57857a0fe09ddbfe9228b48d4c09bb624 > > Diff: https://reviews.apache.org/r/32323/diff/ > > > Testing > --- > > ./gradlew -Pq pmdMain -d > > diffed the "Using rule" log lines from before and after: > > ``` > % diff -u <(sort -u old-rules.txt) <(sort -u new-rules.txt) > % > ``` > > > Thanks, > > Kevin Sweeney > >
Review Request 32323: DRY up PMD configuration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32323/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- DRY up PMD configuration. Diffs - build.gradle 4a13e5c4281de53d0ea991235502943a439d1310 config/pmd/custom.xml 7026d04d8e5c2f185a19c7c44d44698b2fb846c9 config/pmd/design.xml 2741e407e35826e73bd4dc8335c0ef6294086398 config/pmd/imports.xml 40dc2260a3c27fd66be352a5974427dcf165ab34 config/pmd/logging-java.xml 66fecbf14aa61f340678dc23d57a1c074cad824a config/pmd/naming.xml 233352d57857a0fe09ddbfe9228b48d4c09bb624 Diff: https://reviews.apache.org/r/32323/diff/ Testing --- ./gradlew -Pq pmdMain -d diffed the "Using rule" log lines from before and after: ``` % diff -u <(sort -u old-rules.txt) <(sort -u new-rules.txt) % ``` Thanks, Kevin Sweeney
