Review Request 20782: AURORA-278:Review Incubator release check list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20782/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-278 https://issues.apache.org/jira/browse/AURORA-278 Repository: aurora Description --- AURORA-278:Review Incubator release check list Updating LICENSE file for new JS additions. Diffs - LICENSE 720805eff74008a71bb5febd6d13996b341f23cd Diff: https://reviews.apache.org/r/20782/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41616 --- src/main/python/apache/aurora/client/cli/__init__.py https://reviews.apache.org/r/20687/#comment75150 No. This logging is for the log server; from the perspective of the log server, this is a routine, acceptable event. It was an error for the user, but not an error for the system. src/main/python/apache/aurora/client/cli/command_hooks.py https://reviews.apache.org/r/20687/#comment75151 No, neither. We're following the model of Vagrantfile or Makefile. Hooks affect the behavior of the system, so they should not be hidden. src/main/python/apache/aurora/client/cli/command_hooks.py https://reviews.apache.org/r/20687/#comment75149 Can't. print_err is a context method. There is no context here. src/main/python/apache/aurora/client/cli/command_hooks.py https://reviews.apache.org/r/20687/#comment75154 Can't. These two variables are used for visible side-effects - we need to have variable to reference them after the exec returns. - Mark Chu-Carroll On April 24, 2014, 8:17 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 24, 2014, 8:17 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-270 https://issues.apache.org/jira/browse/aurora-270 Repository: aurora Description --- Stage 1 of implementing command hooks for aurora v2. This change includes: (1) The ability to add hard-wired hooks, by registering them in ConfigurationPlugins compiled into a pex; (2) Dynamically loaded plugins, loaded from plugin files. The dynamically loaded plugins are *not* currently active outside of tests. The second stage of this change will activate dynamically loaded plugins, and provide a mechanism to allow privileged users to override hooks. Diffs - src/main/python/apache/aurora/client/cli/BUILD 17cdc287875b5f0832064a6441f33fc9837fc79b src/main/python/apache/aurora/client/cli/__init__.py 5a10328e49f0128965aed73b9c167324dfcfde0f src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION src/main/python/apache/aurora/client/cli/jobs.py 0534bdf72a332caa606dd3a7ca743a59e03738ef src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 34fdb47baa647b9c3bd149ff2710b175c7435dae src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION Diff: https://reviews.apache.org/r/20687/diff/ Testing --- [sun-wukong incubator-aurora (command_hooks)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.03 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_command_hooks.py === 4 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.52 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 36 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ...
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 28, 2014, 3 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Changes --- Address most of Suman's review comments. (Haven't updated the tests yet; trying to figure out how to do that without mock-a-palooza. Maybe that can wait until the second half of the command-hooks impl?) Bugs: aurora-270 https://issues.apache.org/jira/browse/aurora-270 Repository: aurora Description --- Stage 1 of implementing command hooks for aurora v2. This change includes: (1) The ability to add hard-wired hooks, by registering them in ConfigurationPlugins compiled into a pex; (2) Dynamically loaded plugins, loaded from plugin files. The dynamically loaded plugins are *not* currently active outside of tests. The second stage of this change will activate dynamically loaded plugins, and provide a mechanism to allow privileged users to override hooks. Diffs (updated) - docs/design/command-hooks.md PRE-CREATION src/main/python/apache/aurora/client/cli/BUILD 17cdc287875b5f0832064a6441f33fc9837fc79b src/main/python/apache/aurora/client/cli/__init__.py 5a10328e49f0128965aed73b9c167324dfcfde0f src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION src/main/python/apache/aurora/client/cli/jobs.py 0534bdf72a332caa606dd3a7ca743a59e03738ef src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 34fdb47baa647b9c3bd149ff2710b175c7435dae src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION Diff: https://reviews.apache.org/r/20687/diff/ Testing --- [sun-wukong incubator-aurora (command_hooks)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.03 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_command_hooks.py === 4 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.52 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 36 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 36 passed in 1.87 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/cli/test_logging.py . === 1 passed in 0.62 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. === 2 passed in 0.53 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 --
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 28, 2014, 3:01 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Changes --- Responding to review comments. Bugs: aurora-270 https://issues.apache.org/jira/browse/aurora-270 Repository: aurora Description --- Stage 1 of implementing command hooks for aurora v2. This change includes: (1) The ability to add hard-wired hooks, by registering them in ConfigurationPlugins compiled into a pex; (2) Dynamically loaded plugins, loaded from plugin files. The dynamically loaded plugins are *not* currently active outside of tests. The second stage of this change will activate dynamically loaded plugins, and provide a mechanism to allow privileged users to override hooks. Diffs - docs/design/command-hooks.md PRE-CREATION src/main/python/apache/aurora/client/cli/BUILD 17cdc287875b5f0832064a6441f33fc9837fc79b src/main/python/apache/aurora/client/cli/__init__.py 5a10328e49f0128965aed73b9c167324dfcfde0f src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION src/main/python/apache/aurora/client/cli/jobs.py 0534bdf72a332caa606dd3a7ca743a59e03738ef src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 34fdb47baa647b9c3bd149ff2710b175c7435dae src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION Diff: https://reviews.apache.org/r/20687/diff/ Testing --- [sun-wukong incubator-aurora (command_hooks)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.03 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_command_hooks.py === 4 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.52 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 36 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 36 passed in 1.87 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/cli/test_logging.py . === 1 passed in 0.62 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. === 2 passed in 0.53 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_quota.py === 4 passed in 0.55 seconds
Re: Review Request 20782: AURORA-278:Review Incubator release check list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20782/#review41619 --- Ship it! Mind adding Suman to the reviewers line? - Kevin Sweeney On April 28, 2014, 10:03 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20782/ --- (Updated April 28, 2014, 10:03 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-278 https://issues.apache.org/jira/browse/AURORA-278 Repository: aurora Description --- AURORA-278:Review Incubator release check list Updating LICENSE file for new JS additions. Diffs - LICENSE 720805eff74008a71bb5febd6d13996b341f23cd Diff: https://reviews.apache.org/r/20782/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 20744: Upgrade Mesos to 0.18.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20744/#review41624 --- Ship it! Ship It! - Kevin Sweeney On April 27, 2014, 6:34 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20744/ --- (Updated April 27, 2014, 6:34 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-322 https://issues.apache.org/jira/browse/AURORA-322 Repository: aurora Description --- Upgrade Mesos to 0.18.0. Unblocks AURORA-14 from switching to an apache.org source for building the Mesos .egg. Diffs - 3rdparty/python/BUILD 72e896dff8f9cdb5d797082740432b4faa4e536c build.gradle cb04661ecdbb17cac34f52167494bf08286c0841 docs/deploying-aurora-scheduler.md d50e9b8a3adf08d9d2e0b900cc9541768332715d examples/scheduler/scheduler-local.sh 8b69a4554ab00b96c15fdadb4cd50dbbf2b1016c examples/vagrant/provision-dev-cluster.sh 2b2ab0d93532bc4fdb3425aac4b306055067c6fe Diff: https://reviews.apache.org/r/20744/diff/ Testing --- Ran e2e test locally: + RETCODE=0 + collect_result + [[ 0 = 0 ]] + echo '***' *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 Thanks, Dan Norris
Re: Review Request 20782: AURORA-278:Review Incubator release check list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20782/ --- (Updated April 28, 2014, 7:39 p.m.) Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Bill Farner. Changes --- Added Bugs: AURORA-278 https://issues.apache.org/jira/browse/AURORA-278 Repository: aurora Description --- AURORA-278:Review Incubator release check list Updating LICENSE file for new JS additions. Diffs - LICENSE 720805eff74008a71bb5febd6d13996b341f23cd Diff: https://reviews.apache.org/r/20782/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 20394: Add return code to task/process pages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/ --- (Updated April 28, 2014, 10:48 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Add return code to task/process pages Diffs (updated) - src/main/python/apache/thermos/observer/http/http_observer.py 118bd2f4889c520683ba04b554d699ecf0bc20ce src/main/python/apache/thermos/observer/http/templates/process.tpl a7fb90d4decec01cb95f9e5d42288eaae9d71edf src/main/python/apache/thermos/observer/http/templates/task.tpl b71c80d11255c111873a46b99478c36d39cc8733 src/main/python/apache/thermos/observer/task_observer.py ea40bfa610e2af90904487c809bc83b8b5f214d9 Diff: https://reviews.apache.org/r/20394/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review41646 --- FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way. - Maxim Khutornenko On April 24, 2014, 4:22 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/ --- (Updated April 24, 2014, 4:22 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-340 https://issues.apache.org/jira/browse/AURORA-340 Repository: aurora Description --- Remove IsolatedSchedulerModule and surrounding code. Diffs - build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 1bfd4b69584122f62616ce93098a56fe3cf195d8 src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 9186aebef2babc4a76fe05eb3b412be26d7de3c6 src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java cc31187607e89a9daebe071a8a180d56d873e4c5 Diff: https://reviews.apache.org/r/20648/diff/ Testing --- ./gradlew build sh examples/vagrant/test_tutorial.sh Thanks, Bill Farner
Re: Review Request 20726: Removing client HTTP health checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20726/#review41649 --- Ping, Brian. - Maxim Khutornenko On April 25, 2014, 7:41 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20726/ --- (Updated April 25, 2014, 7:41 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-361 https://issues.apache.org/jira/browse/AURORA-361 Repository: aurora Description --- Dropping client http health checks in favor of status checks only. Diffs - src/main/python/apache/aurora/client/api/health_check.py e3bbf71a37c3137d580378ac185eaf65f4b056af src/main/python/apache/aurora/client/api/instance_watcher.py 530868348142c73708fa7f0d7296a3fb5b6ebb5d src/test/python/apache/aurora/client/api/test_health_check.py f59fe42cc4808aeece34f55978ca34e62404ac58 src/test/python/apache/aurora/client/cli/test_restart.py 43412c44edba19e8c7d753118d7ad0be78a4fd39 src/test/python/apache/aurora/client/cli/test_update.py e3e433262f354ed0573273bd0c28746c3cef902b src/test/python/apache/aurora/client/commands/test_restart.py 526c501869b7ae22550e5d84613ca38f8071b9b7 src/test/python/apache/aurora/client/commands/test_update.py f90783779805313f529487509f7d457ba8ee138c Diff: https://reviews.apache.org/r/20726/diff/ Testing --- ./pants src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.
On April 28, 2014, 11 p.m., Maxim Khutornenko wrote: FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way. The time sink is not inherent to running in vagrant, but that we have not yet invested time in streamlining the code iteration process in the vagrant environment (i.e. rather than destroy/up). Keeping the isolated mode around doesn't nudge us to define that process. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review41646 --- On April 24, 2014, 4:22 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/ --- (Updated April 24, 2014, 4:22 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-340 https://issues.apache.org/jira/browse/AURORA-340 Repository: aurora Description --- Remove IsolatedSchedulerModule and surrounding code. Diffs - build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 1bfd4b69584122f62616ce93098a56fe3cf195d8 src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 9186aebef2babc4a76fe05eb3b412be26d7de3c6 src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java cc31187607e89a9daebe071a8a180d56d873e4c5 Diff: https://reviews.apache.org/r/20648/diff/ Testing --- ./gradlew build sh examples/vagrant/test_tutorial.sh Thanks, Bill Farner
Re: Review Request 20620: Add machine maintainer auth capability.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20620/#review41665 --- Ship it! Ship It! - Suman Karumuri On April 23, 2014, 7:39 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20620/ --- (Updated April 23, 2014, 7:39 p.m.) Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Bugs: AURORA-348 https://issues.apache.org/jira/browse/AURORA-348 Repository: aurora Description --- Add machine maintainer auth capability. Diffs - src/main/java/org/apache/aurora/auth/CapabilityValidator.java a2e215eeebd3f8fc2a5a62b6c6f6dc1c92611a3a src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 84151a5308c12b3bee7cf5fd662776e574e8fadf src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f530c530548444c57d9aeb5ed100a5fda5bd2953 Diff: https://reviews.apache.org/r/20620/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 20782: AURORA-278:Review Incubator release check list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20782/#review41667 --- Ship it! Ship It! - Suman Karumuri On April 28, 2014, 7:39 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20782/ --- (Updated April 28, 2014, 7:39 p.m.) Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Bill Farner. Bugs: AURORA-278 https://issues.apache.org/jira/browse/AURORA-278 Repository: aurora Description --- AURORA-278:Review Incubator release check list Updating LICENSE file for new JS additions. Diffs - LICENSE 720805eff74008a71bb5febd6d13996b341f23cd Diff: https://reviews.apache.org/r/20782/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41669 --- lgtm. Please cut a separate ticket for the tests. The only ship it blocker is answer to 2.6 compatibility? - Suman Karumuri On April 28, 2014, 7:01 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/ --- (Updated April 28, 2014, 7:01 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-270 https://issues.apache.org/jira/browse/aurora-270 Repository: aurora Description --- Stage 1 of implementing command hooks for aurora v2. This change includes: (1) The ability to add hard-wired hooks, by registering them in ConfigurationPlugins compiled into a pex; (2) Dynamically loaded plugins, loaded from plugin files. The dynamically loaded plugins are *not* currently active outside of tests. The second stage of this change will activate dynamically loaded plugins, and provide a mechanism to allow privileged users to override hooks. Diffs - docs/design/command-hooks.md PRE-CREATION src/main/python/apache/aurora/client/cli/BUILD 17cdc287875b5f0832064a6441f33fc9837fc79b src/main/python/apache/aurora/client/cli/__init__.py 5a10328e49f0128965aed73b9c167324dfcfde0f src/main/python/apache/aurora/client/cli/command_hooks.py PRE-CREATION src/main/python/apache/aurora/client/cli/jobs.py 0534bdf72a332caa606dd3a7ca743a59e03738ef src/test/python/apache/aurora/client/cli/AuroraHooks PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 34fdb47baa647b9c3bd149ff2710b175c7435dae src/test/python/apache/aurora/client/cli/test_command_hooks.py PRE-CREATION Diff: https://reviews.apache.org/r/20687/diff/ Testing --- [sun-wukong incubator-aurora (command_hooks)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.03 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_command_hooks.py === 4 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.52 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 36 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 36 passed in 1.87 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/cli/test_logging.py . === 1 passed in 0.62 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py
Re: Review Request 20726: Removing client HTTP health checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20726/#review41671 --- Ship it! Ship It! - Brian Wickman On April 25, 2014, 7:41 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20726/ --- (Updated April 25, 2014, 7:41 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-361 https://issues.apache.org/jira/browse/AURORA-361 Repository: aurora Description --- Dropping client http health checks in favor of status checks only. Diffs - src/main/python/apache/aurora/client/api/health_check.py e3bbf71a37c3137d580378ac185eaf65f4b056af src/main/python/apache/aurora/client/api/instance_watcher.py 530868348142c73708fa7f0d7296a3fb5b6ebb5d src/test/python/apache/aurora/client/api/test_health_check.py f59fe42cc4808aeece34f55978ca34e62404ac58 src/test/python/apache/aurora/client/cli/test_restart.py 43412c44edba19e8c7d753118d7ad0be78a4fd39 src/test/python/apache/aurora/client/cli/test_update.py e3e433262f354ed0573273bd0c28746c3cef902b src/test/python/apache/aurora/client/commands/test_restart.py 526c501869b7ae22550e5d84613ca38f8071b9b7 src/test/python/apache/aurora/client/commands/test_update.py f90783779805313f529487509f7d457ba8ee138c Diff: https://reviews.apache.org/r/20726/diff/ Testing --- ./pants src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Review Request 20824: AURORA-278: Review Incubator release check list - missing license headers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20824/
---
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-278
https://issues.apache.org/jira/browse/AURORA-278
Repository: aurora
Description
---
AURORA-278: Review Incubator release check list
Adds missing license headers in python files.
Diffs
-
src/main/python/apache/aurora/common/shellify.py
67d81f0983a343d5527ce6152bad2d591e5f08dd
src/test/python/apache/aurora/common/test_shellify.py
8ecce7ff98769cd17cc016bee30750c5841fa942
Diff: https://reviews.apache.org/r/20824/diff/
Testing
---
Since there is no checkstyle yet for py code ran following check to see which
py files where missing headers still
Dir['src/**/*.py'].each { |f| content = File.open(f).read(); next if
content.empty? ; puts f unless File.open(f).read().include?(Apache Software
Foundation) }
Thanks,
Jake Farrell
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated April 29, 2014, 3:15 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Fix whitespace, print with a variable set to be in line with comment. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs (updated) - build-support/pex 19c33210da7c390523b5890e20a137006345a62a build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
