Review Request 28170: AURORA-933 - python missing license headers

2014-11-18 Thread Jake Farrell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28170/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-933
https://issues.apache.org/jira/browse/AURORA-933


Repository: aurora


Description
---

Adds missing license headers to .py files


Diffs
-

  src/main/python/apache/aurora/executor/thermos_statuses.py 
634185a7f8b33858a6f3ae7b1e5722c18ee51bf0 
  src/test/python/apache/aurora/client/api/api_util.py 
6e12154fcd6609b763935b9fb7458946efd7d3d6 

Diff: https://reviews.apache.org/r/28170/diff/


Testing
---


Thanks,

Jake Farrell



Re: Review Request 28170: AURORA-933 - python missing license headers

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28170/#review61931
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh

Uninstalling setuptools:
  Successfully uninstalled setuptools
Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile 
pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon 
requests twitter.common.collections twitter.common.config 
twitter.common.confluence twitter.common.contextutil twitter.common.decorators 
twitter.common.dirutil twitter.common.lang twitter.common.log 
twitter.common.options twitter.common.process twitter.common.string 
twitter.common.threading twitter.common.util setuptools
Cleaning up...
Build operating on top level addresses: 
set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au
 rora/common/auth/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/
 BUILD, base)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(B
 
uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 shellify)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 job_monitor)), 

Re: Review Request 28170: AURORA-933 - python missing license headers

2014-11-18 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28170/#review61950
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 18, 2014, 3:46 p.m., Jake Farrell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28170/
 ---
 
 (Updated Nov. 18, 2014, 3:46 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-933
 https://issues.apache.org/jira/browse/AURORA-933
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Adds missing license headers to .py files
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/executor/thermos_statuses.py 
 634185a7f8b33858a6f3ae7b1e5722c18ee51bf0 
   src/test/python/apache/aurora/client/api/api_util.py 
 6e12154fcd6609b763935b9fb7458946efd7d3d6 
 
 Diff: https://reviews.apache.org/r/28170/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jake Farrell
 




Re: Review Request 28170: AURORA-933 - python missing license headers

2014-11-18 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28170/#review61952
---

Ship it!


Ship It!

- Kevin Sweeney


On Nov. 18, 2014, 7:46 a.m., Jake Farrell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28170/
 ---
 
 (Updated Nov. 18, 2014, 7:46 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-933
 https://issues.apache.org/jira/browse/AURORA-933
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Adds missing license headers to .py files
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/executor/thermos_statuses.py 
 634185a7f8b33858a6f3ae7b1e5722c18ee51bf0 
   src/test/python/apache/aurora/client/api/api_util.py 
 6e12154fcd6609b763935b9fb7458946efd7d3d6 
 
 Diff: https://reviews.apache.org/r/28170/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jake Farrell
 




Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Kevin Sweeney


 On Nov. 11, 2014, 2:34 p.m., Bill Farner wrote:
  src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java, line 103
  https://reviews.apache.org/r/27757/diff/1/?file=755113#file755113line103
 
  remove

fixed.


 On Nov. 11, 2014, 2:34 p.m., Bill Farner wrote:
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java, 
  line 74
  https://reviews.apache.org/r/27757/diff/1/?file=755101#file755101line74
 
  remove comment

Done.


 On Nov. 11, 2014, 2:34 p.m., Bill Farner wrote:
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 251
  https://reviews.apache.org/r/27757/diff/1/?file=755103#file755103line251
 
  revert

Fixed.


 On Nov. 11, 2014, 2:34 p.m., Bill Farner wrote:
  src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java, 
  line 72
  https://reviews.apache.org/r/27757/diff/1/?file=755101#file755101line72
 
  How about fully untethering here and doing this work in `SchedulerMain`?

nowhere immediately jumps out as the right place to put this and I'd like to 
minimize the ripple here.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review60874
---


On Nov. 7, 2014, 4:06 p.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27757/
 ---
 
 (Updated Nov. 7, 2014, 4:06 p.m.)
 
 
 Review request for Aurora and Bill Farner.
 
 
 Bugs: AURORA-920
 https://issues.apache.org/jira/browse/AURORA-920
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This attempts to kill LifecycleModule in favor of service registration.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 72d3d60c602b2cf01445f64f3be7e4ecf53008ca 
   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
 fef76f5069a80959eaba04f1b4b93ff3f6ba43dd 
   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 
   src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 
 8e9a1dc10998a313ad92e365c739b74f892e82ce 
   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
 22c666e28e03f3c1e5a1d89fda55641526b11162 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
 cd5aa17b24209b186314f431c65062d6ed9972cb 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 36706f200e245ea08afa4dd36cb3511d0a63b097 
   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
 354844a2540dec6450724acca18c399bc6c01f44 
   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
 844a38a285f7abf917a844a7f6a4a14749aa9b57 
   src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 
 a7f9401f70b567002c83f4f56407b4e1d3afa5a5 
   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
 962aff8f4fa590935773c9fe90b1a6f59bc1c51f 
   
 src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
  1376237efc8f109d5a57bb8bff1c05026f257418 
   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
 662ebdceff580af0a05f9a89d50ca1c90ddc9070 
   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
 4d58240234b8e48c1f081a8ae647c54095f9dc1d 
   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
 e884209fd5965e50847f14b09a43f6aba4946b7e 
 
 Diff: https://reviews.apache.org/r/27757/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Kevin Sweeney
 




Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review61999
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth
  Found existing installation: setuptools 3.6
Uninstalling setuptools:
  Successfully uninstalled setuptools
Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile 
pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon 
requests twitter.common.collections twitter.common.config 
twitter.common.confluence twitter.common.contextutil twitter.common.decorators 
twitter.common.dirutil twitter.common.lang twitter.common.log 
twitter.common.options twitter.common.process twitter.common.string 
twitter.common.threading twitter.common.util setuptools
Cleaning up...
Build operating on top level addresses: 
set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au
 rora/common/auth/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/
 BUILD, base)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(B
 
uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 shellify)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 

Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62001
---


@ReviewBot retry

- Kevin Sweeney


On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27757/
 ---
 
 (Updated Nov. 18, 2014, 12:26 p.m.)
 
 
 Review request for Aurora and Bill Farner.
 
 
 Bugs: AURORA-920
 https://issues.apache.org/jira/browse/AURORA-920
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This attempts to kill LifecycleModule in favor of service registration.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 72d3d60c602b2cf01445f64f3be7e4ecf53008ca 
   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
 19bf162586b90329e764cacf992df37ca68b0dc0 
   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 
   src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 
 8e9a1dc10998a313ad92e365c739b74f892e82ce 
   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
 22c666e28e03f3c1e5a1d89fda55641526b11162 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
 9e8ba658144c92eea6d24725ec47a8c0710c69c9 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 36706f200e245ea08afa4dd36cb3511d0a63b097 
   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
 354844a2540dec6450724acca18c399bc6c01f44 
   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a 
   src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 
 a7f9401f70b567002c83f4f56407b4e1d3afa5a5 
   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
 962aff8f4fa590935773c9fe90b1a6f59bc1c51f 
   
 src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
  1376237efc8f109d5a57bb8bff1c05026f257418 
   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
 e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 
   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
 4d58240234b8e48c1f081a8ae647c54095f9dc1d 
   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
 48b3d886844622288be4131dfe8f2a77f7e316e7 
 
 Diff: https://reviews.apache.org/r/27757/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Kevin Sweeney
 




Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62005
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth
  Found existing installation: setuptools 3.6
Uninstalling setuptools:
  Successfully uninstalled setuptools
Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile 
pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon 
requests twitter.common.collections twitter.common.config 
twitter.common.confluence twitter.common.contextutil twitter.common.decorators 
twitter.common.dirutil twitter.common.lang twitter.common.log 
twitter.common.options twitter.common.process twitter.common.string 
twitter.common.threading twitter.common.util setuptools
Cleaning up...
Build operating on top level addresses: 
set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au
 rora/common/auth/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/
 BUILD, base)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(B
 
uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 shellify)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 

Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62007
---


@ReviewBot retry

- Kevin Sweeney


On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27757/
 ---
 
 (Updated Nov. 18, 2014, 12:26 p.m.)
 
 
 Review request for Aurora and Bill Farner.
 
 
 Bugs: AURORA-920
 https://issues.apache.org/jira/browse/AURORA-920
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This attempts to kill LifecycleModule in favor of service registration.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 72d3d60c602b2cf01445f64f3be7e4ecf53008ca 
   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
 19bf162586b90329e764cacf992df37ca68b0dc0 
   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 
   src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 
 8e9a1dc10998a313ad92e365c739b74f892e82ce 
   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
 22c666e28e03f3c1e5a1d89fda55641526b11162 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
 9e8ba658144c92eea6d24725ec47a8c0710c69c9 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 36706f200e245ea08afa4dd36cb3511d0a63b097 
   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
 354844a2540dec6450724acca18c399bc6c01f44 
   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a 
   src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 
 a7f9401f70b567002c83f4f56407b4e1d3afa5a5 
   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
 962aff8f4fa590935773c9fe90b1a6f59bc1c51f 
   
 src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
  1376237efc8f109d5a57bb8bff1c05026f257418 
   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
 e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 
   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
 4d58240234b8e48c1f081a8ae647c54095f9dc1d 
   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
 48b3d886844622288be4131dfe8f2a77f7e316e7 
 
 Diff: https://reviews.apache.org/r/27757/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Kevin Sweeney
 




Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62010
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth
  Found existing installation: setuptools 3.6
Uninstalling setuptools:
  Successfully uninstalled setuptools
Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile 
pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon 
requests twitter.common.collections twitter.common.config 
twitter.common.confluence twitter.common.contextutil twitter.common.decorators 
twitter.common.dirutil twitter.common.lang twitter.common.log 
twitter.common.options twitter.common.process twitter.common.string 
twitter.common.threading twitter.common.util setuptools
Cleaning up...
Build operating on top level addresses: 
set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au
 rora/common/auth/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/
 BUILD, base)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(B
 
uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 shellify)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 

Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62011
---


@ReviewBot retry

- Kevin Sweeney


On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27757/
 ---
 
 (Updated Nov. 18, 2014, 12:26 p.m.)
 
 
 Review request for Aurora and Bill Farner.
 
 
 Bugs: AURORA-920
 https://issues.apache.org/jira/browse/AURORA-920
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This attempts to kill LifecycleModule in favor of service registration.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 72d3d60c602b2cf01445f64f3be7e4ecf53008ca 
   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
 19bf162586b90329e764cacf992df37ca68b0dc0 
   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 
   src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 
 8e9a1dc10998a313ad92e365c739b74f892e82ce 
   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
 22c666e28e03f3c1e5a1d89fda55641526b11162 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
 9e8ba658144c92eea6d24725ec47a8c0710c69c9 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 36706f200e245ea08afa4dd36cb3511d0a63b097 
   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
 354844a2540dec6450724acca18c399bc6c01f44 
   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a 
   src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 
 a7f9401f70b567002c83f4f56407b4e1d3afa5a5 
   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
 962aff8f4fa590935773c9fe90b1a6f59bc1c51f 
   
 src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
  1376237efc8f109d5a57bb8bff1c05026f257418 
   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
 e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 
   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
 4d58240234b8e48c1f081a8ae647c54095f9dc1d 
   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
 48b3d886844622288be4131dfe8f2a77f7e316e7 
 
 Diff: https://reviews.apache.org/r/27757/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Kevin Sweeney
 




Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62012
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh

Uninstalling setuptools:
  Successfully uninstalled setuptools
Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile 
pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon 
requests twitter.common.collections twitter.common.config 
twitter.common.confluence twitter.common.contextutil twitter.common.decorators 
twitter.common.dirutil twitter.common.lang twitter.common.log 
twitter.common.options twitter.common.process twitter.common.string 
twitter.common.threading twitter.common.util setuptools
Cleaning up...
Build operating on top level addresses: 
set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au
 rora/common/auth/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/
 BUILD, base)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(B
 
uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 shellify)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 job_monitor)), 

Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62015
---


@Reviewbot retry please?

- Kevin Sweeney


On Nov. 18, 2014, 12:26 p.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27757/
 ---
 
 (Updated Nov. 18, 2014, 12:26 p.m.)
 
 
 Review request for Aurora and Bill Farner.
 
 
 Bugs: AURORA-920
 https://issues.apache.org/jira/browse/AURORA-920
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This attempts to kill LifecycleModule in favor of service registration.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/AppStartup.java PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 72d3d60c602b2cf01445f64f3be7e4ecf53008ca 
   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
 19bf162586b90329e764cacf992df37ca68b0dc0 
   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
 4e37f4c9c8d4cde477a96a9b8cca7a075f170919 
   src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java 
 8e9a1dc10998a313ad92e365c739b74f892e82ce 
   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
 22c666e28e03f3c1e5a1d89fda55641526b11162 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
 9e8ba658144c92eea6d24725ec47a8c0710c69c9 
   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
 36706f200e245ea08afa4dd36cb3511d0a63b097 
   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
 354844a2540dec6450724acca18c399bc6c01f44 
   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
 1c9904ca0c0f93b0d6b999e77a81a3f10d65bb9a 
   src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 
 a7f9401f70b567002c83f4f56407b4e1d3afa5a5 
   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
 962aff8f4fa590935773c9fe90b1a6f59bc1c51f 
   
 src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
  1376237efc8f109d5a57bb8bff1c05026f257418 
   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
 e4e252e8a7bd4e113a2e3dcc32712ac224dd9956 
   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
 4d58240234b8e48c1f081a8ae647c54095f9dc1d 
   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java 
 48b3d886844622288be4131dfe8f2a77f7e316e7 
 
 Diff: https://reviews.apache.org/r/27757/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Kevin Sweeney
 




Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62017
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth
  Found existing installation: setuptools 3.6
Uninstalling setuptools:
  Successfully uninstalled setuptools
Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile 
pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon 
requests twitter.common.collections twitter.common.config 
twitter.common.confluence twitter.common.contextutil twitter.common.decorators 
twitter.common.dirutil twitter.common.lang twitter.common.log 
twitter.common.options twitter.common.process twitter.common.string 
twitter.common.threading twitter.common.util setuptools
Cleaning up...
Build operating on top level addresses: 
set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au
 rora/common/auth/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/
 BUILD, base)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(B
 
uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 shellify)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-18 Thread Maxim Khutornenko


 On Nov. 14, 2014, 1:48 a.m., Zameer Manji wrote:
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
   line 1787
  https://reviews.apache.org/r/28026/diff/1/?file=763222#file763222line1787
 
  Can you file a JIRA for this?

This is now tracked by https://issues.apache.org/jira/browse/AURORA-937


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61371
---


On Nov. 14, 2014, 1:30 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28026/
 ---
 
 (Updated Nov. 14, 2014, 1:30 a.m.)
 
 
 Review request for Aurora, David McLaughlin and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
 branch coverage.  The remaining pieces are legitimately difficult to capture.
 
 I also uncovered a few minor bugs along the way, most noteworthy being AOP 
 interceptor ordering leading to the standard API response not always being 
 applied.
 
 Additionally, i removed a bunch of unnecessary exception handling that is now 
 done by an AOP interceptor.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/auth/SessionValidator.java 
 eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
 4744dc9f202969906113ccb610bf17c94d188c43 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  b2b66acee9c0789f3660469d6d504b4510af5e79 
   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
 dca855c522d21924821fc47e636da39689aec4b7 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
 
 Diff: https://reviews.apache.org/r/28026/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 




Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

2014-11-18 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-928
https://issues.apache.org/jira/browse/AURORA-928


Repository: aurora


Description
---

Mesos rejects tasks and executors that are zero sized. This patch reconfigures 
Aurora to ensure no zero sized tasks and executors are created.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
40b652c679d8e340f585e28cbed066335d9d760d 
  src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
65c4b526c89a4d5607af4424ebe49bb48e296ae9 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
d6febb8998e05257cabe8d193cefa0b6c79f197e 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
953c1edb6802d8983ab324aa56361e5c8fbe2e68 

Diff: https://reviews.apache.org/r/28193/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji



Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62060
---

Ship it!


Master (c44aa5c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Nov. 18, 2014, 11:33 p.m., Zameer Manji wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28193/
 ---
 
 (Updated Nov. 18, 2014, 11:33 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Bugs: AURORA-928
 https://issues.apache.org/jira/browse/AURORA-928
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Mesos rejects tasks and executors that are zero sized. This patch 
 reconfigures Aurora to ensure no zero sized tasks and executors are created.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
 ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
 40b652c679d8e340f585e28cbed066335d9d760d 
   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
 bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
 899416fceae498353880012b8a93491cff461064 
   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
 d6febb8998e05257cabe8d193cefa0b6c79f197e 
   
 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
 
 Diff: https://reviews.apache.org/r/28193/diff/
 
 
 Testing
 ---
 
 ./gradlew clean build -Pq
 
 
 Thanks,
 
 Zameer Manji
 




Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/
---

Review request for Aurora.


Repository: aurora


Description
---

Add an example on how to build with Docker.


Diffs
-

  README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
  examples/docker/Dockerfile PRE-CREATION 

Diff: https://reviews.apache.org/r/28198/diff/


Testing
---


Thanks,

Tony Dong



Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/
---

(Updated Nov. 19, 2014, 12:35 a.m.)


Review request for Aurora and Benjamin Staffin.


Repository: aurora


Description
---

Add an example on how to build with Docker.


Diffs
-

  README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
  examples/docker/Dockerfile PRE-CREATION 

Diff: https://reviews.apache.org/r/28198/diff/


Testing
---


Thanks,

Tony Dong



Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62078
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh


Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.decorators-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.dirutil
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.dirutil-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.lang
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.lang-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.log
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.log-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.options
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.options-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.process
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.process-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.string
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.string-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.threading
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.threading-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.util
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62079
---


@ReviewBot retry

- Tony Dong


On Nov. 19, 2014, 12:35 a.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 19, 2014, 12:35 a.m.)
 
 
 Review request for Aurora and Benjamin Staffin.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/
---

(Updated Nov. 19, 2014, 12:54 a.m.)


Review request for Aurora, Benjamin Staffin and Zameer Manji.


Repository: aurora


Description
---

Add an example on how to build with Docker.


Diffs
-

  README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
  examples/docker/Dockerfile PRE-CREATION 

Diff: https://reviews.apache.org/r/28198/diff/


Testing
---


Thanks,

Tony Dong



Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62083
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh

  File /usr/lib/python2.7/sysconfig.py, line 355, in _init_posix
raise IOError(msg)
IOError: invalid Python installation: unable to open 
/x1/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/local/include/python2.7/pyconfig.h
 (No such file or directory)

Build operating on top level addresses: 
set([BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/au
 th/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 base)), PythonLibrary
 
(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/
 workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 job_monitor)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 quota_check)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace
 /AuroraBot/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD,
 util)), 

Re: Review Request 28140: Drop argparse dependency; it's part of python 2.7

2014-11-18 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28140/#review62091
---

Ship it!


Ship It!

- David McLaughlin


On Nov. 18, 2014, 12:29 a.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28140/
 ---
 
 (Updated Nov. 18, 2014, 12:29 a.m.)
 
 
 Review request for Aurora, David McLaughlin and Kevin Sweeney.
 
 
 Bugs: AURORA-891
 https://issues.apache.org/jira/browse/AURORA-891
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Drop argparse dependency; it's part of python 2.7
 
 
 Diffs
 -
 
   3rdparty/python/BUILD 63ae77f4632db158109e8d562488ce4e84da0438 
   src/main/python/apache/aurora/client/cli/BUILD 
 995570325bbb09ecbcc2ace5d223760c5d49367f 
 
 Diff: https://reviews.apache.org/r/28140/diff/
 
 
 Testing
 ---
 
 ./pants build src/test/python:all
 bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62098
---


Please add a committer to this so it can be committed. I suggest Kevin.

- Zameer Manji


On Nov. 18, 2014, 4:54 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 18, 2014, 4:54 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong