i3wangyi opened a new pull request #417: Move partition heatlh check method into dataAccessor layer URL: https://github.com/apache/helix/pull/417 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR title: fixes #416 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: (Write a concise description including what, why, how) Move the method `generateClusterPartitionHealth` method into HelixDataAcessorWrapper, which is an ideal place to hide the complexity of ZK related operations. ### Tests - [ ] The following tests are written for this issue: (List the names of added unit/integration tests) Moved the test method in TestInstanceService to a new test class called `TestHelixDataAccessorWrapper` - [ ] The following is the result of the "mvn test" command on the appropriate module: (Copy & paste the result of "mvn test") ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [ ] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org