[GitHub] [helix] narendly commented on issue #684: Add zookeeper-api module to Apache Helix
narendly commented on issue #684: Add zookeeper-api module to Apache Helix URL: https://github.com/apache/helix/pull/684#issuecomment-584874889 This PR is ready to be merged, approved by @dasahcc @jiajunwang Add metrics-common, zookeeper-api, helix-common modules We want to create a new module called zookeeper-api in order to decouple Helix's ZooKeeper APIs from helix-core. The goal is to enable non-Helix applications to use Helix's ZooKeeper APIs to use ZooKeeper. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
[GitHub] [helix] narendly commented on issue #684: Add zookeeper-api module to Apache Helix
narendly commented on issue #684: Add zookeeper-api module to Apache Helix URL: https://github.com/apache/helix/pull/684#issuecomment-584873707 > LGTM! Thanks for working on this huge task. > > One concern is the ivy file helix-core/helix-core-0.9.2-SNAPSHOT.ivy. 'commons-math3" is used by the WAGED rebalancer, I think we need to keep it in the ivy file. Updated the .ivy file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
