[GitHub] [helix] nikhilvavs commented on issue #748: Huge CPU spike after upgrading from 0.8.2 to 0.8.4 (0.8.3)
nikhilvavs commented on issue #748: Huge CPU spike after upgrading from 0.8.2 to 0.8.4 (0.8.3) URL: https://github.com/apache/helix/issues/748#issuecomment-602420386 I tested once again and found that this started in 0.8.3. The flame graph showed that it was taking a lot of time in the deserializer, but I don't see any major changes that can cause this b/w 0.8.2 and 0.8.3 - [Diff](https://github.com/apache/helix/compare/helix-0.8.2...helix-0.8.3?diff=unified) I would be happy to help debug this further, but if you can give me some steps that I can take. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
[GitHub] [helix] nikhilvavs commented on issue #748: Huge CPU spike after upgrading from 0.8.2 to 0.8.4
nikhilvavs commented on issue #748: Huge CPU spike after upgrading from 0.8.2 to 0.8.4 URL: https://github.com/apache/helix/issues/748#issuecomment-585063817 We took flame graphs of the CPU with and without the upgraded version. The upgraded version had 25.7% samples from `org/apache/helix/common/DedupEventProcessor.run` compared to 3.23% in the normal revision. **Flame graph from 0.8.2:** Although not very clear from this image, the small box next to `java/lang/Thread.run` (second row from bottom) is the box corresponding to helix code ![image](https://user-images.githubusercontent.com/5173634/74310773-f0943f00-4d93-11ea-9fe3-8c238feb340b.png) **Flame graph from the upgraded version (0.8.4):** You can see a significant increase in the number of samples in `DedupEventProcessor.run` ![image](https://user-images.githubusercontent.com/5173634/74310380-1b31c800-4d93-11ea-9b3d-b72c8f27f9c6.png) **Flame graph zoomed in on details with helix (version 0.8.4):** ![image](https://user-images.githubusercontent.com/5173634/74310985-70baa480-4d94-11ea-9e94-0f6b8c895d80.png) Apologies for not being able to attach the complete svg. We checked the commits in `DedupEventProcessor.java` and saw that the commit was introduced in 0.8.3. (It may have been some other function inside as well.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org