[Impala-ASF-CR] IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15214 ) Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre .. Patch Set 7: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5560/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9690a926953a8d3c3872277680b4be0551546c68 Gerrit-Change-Number: 15214 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 23 Mar 2020 06:43:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5904: (part 3) Fix more TSAN bugs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15363 ) Change subject: IMPALA-5904: (part 3) Fix more TSAN bugs .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5559/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b7b119e256085d1ba6977e1161fc658273b242 Gerrit-Change-Number: 15363 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Mar 2020 05:47:52 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-3343 (part 4), IMPALA-9489: Impala-shell on python 3.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: WIP: IMPALA-3343 (part 4), IMPALA-9489: Impala-shell on python 3. .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5516/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb004d352fe230a890a6b6356496ba76c2fab615 Gerrit-Change-Number: 15524 Gerrit-PatchSet: 1 Gerrit-Owner: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 23 Mar 2020 05:00:51 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-3343 (part 4), IMPALA-9489: Impala-shell on python 3.
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15524 Change subject: WIP: IMPALA-3343 (part 4), IMPALA-9489: Impala-shell on python 3. .. WIP: IMPALA-3343 (part 4), IMPALA-9489: Impala-shell on python 3. Change-Id: Idb004d352fe230a890a6b6356496ba76c2fab615 --- M bin/impala-shell.sh M bin/set-pythonpath.sh M shell/TSSLSocketWithWildcardSAN.py M shell/compatibility.py M shell/impala_client.py M shell/impala_shell.py M shell/impala_shell_config_defaults.py M shell/make_shell_tarball.sh M shell/option_parser.py M shell/packaging/make_python_package.sh M shell/packaging/requirements.txt M shell/packaging/setup.py M shell/pkg_resources.py M shell/shell_output.py M tests/conftest.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py M tests/shell/util.py 18 files changed, 363 insertions(+), 148 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/15524/1 -- To view, visit http://gerrit.cloudera.org:8080/15524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idb004d352fe230a890a6b6356496ba76c2fab615 Gerrit-Change-Number: 15524 Gerrit-PatchSet: 1 Gerrit-Owner: David Knupp
[Impala-ASF-CR] IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15214 ) Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre .. Patch Set 7: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5558/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9690a926953a8d3c3872277680b4be0551546c68 Gerrit-Change-Number: 15214 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 23 Mar 2020 03:20:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5904: (part 3) Fix more TSAN bugs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15363 ) Change subject: IMPALA-5904: (part 3) Fix more TSAN bugs .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5515/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b7b119e256085d1ba6977e1161fc658273b242 Gerrit-Change-Number: 15363 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Mar 2020 02:47:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5904: (part 3) Fix more TSAN bugs
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15363 to look at the new patch set (#3). Change subject: IMPALA-5904: (part 3) Fix more TSAN bugs .. IMPALA-5904: (part 3) Fix more TSAN bugs As of this commit, all backend tests are TSAN clean (or suppressions exist for any races that are considered benign). TSAN Fixes: * Fixes IMPALA-9374: Possible data race in TupleDescriptor::GetLlvmStruct * Replaces the assignment of llvm_field_idx_ with slot_idx_, since they are the same; added a DCHECK to enforce this * Data race in be/src/exprs/scalar-expr-evaluator.cc:285:26 impala::ScalarExprEvaluator::GetValue(...) * This race seems specific to data-stream-test, and does not occur during any other tests * I made some changes to DataStreamTest to fix the sharing of TupleRowComparators between threads Suppresions: * Added a suppresion for IMPALA-9455: Possible data race in kudu::security::InitKerberosForServer * Added suppresions for hs2-http-test since it uses the ThriftServer, which is known to be racey (IMPALA-9314) Testing: * Ran exhaustive tests * Re-ran TSAN tests and confirmed the data races have been fixed Change-Id: I99b7b119e256085d1ba6977e1161fc658273b242 --- M be/src/rpc/hs2-http-test.cc M be/src/runtime/data-stream-test.cc M be/src/runtime/descriptors.cc M be/src/runtime/descriptors.h M bin/tsan-suppressions.txt 5 files changed, 47 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/15363/3 -- To view, visit http://gerrit.cloudera.org:8080/15363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I99b7b119e256085d1ba6977e1161fc658273b242 Gerrit-Change-Number: 15363 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15253 ) Change subject: IMPALA-9406 Add some new packages to download .. Patch Set 1: Thank you for watching this, Laszlo. Because now, there are no valid and released kudu versions which support aarch64, I need to build it from source code which have been modified for adapting aarch64. Anyway, this commit is not very critical, I can download and install the packages myself. Maybe in future when there is a aarch64 version kudu, this commit is useless, we can just abandon it. -- To view, visit http://gerrit.cloudera.org:8080/15253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e Gerrit-Change-Number: 15253 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Mon, 23 Mar 2020 01:51:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15214 ) Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre .. Patch Set 7: I rebased this patch against the latest asf-master. Will verify whether it could pass the exhaustive tests. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/15214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9690a926953a8d3c3872277680b4be0551546c68 Gerrit-Change-Number: 15214 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 23 Mar 2020 00:21:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre
Fang-Yu Rao has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15214 ) Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre .. IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre This patch bumps up the version of Guava libraries from 14.0.1 to 28.1-jre. Due to some changes in Guava's API's, we modify the call sites accordingly. Note that in order to instruct the Java classes under the directory of $IMPALA_HOME/common/yarn-extras to use the new Guava libraries, we also explicitly added a dependency in the corresponding pom.xml file. Change-Id: I9690a926953a8d3c3872277680b4be0551546c68 --- M common/yarn-extras/pom.xml M common/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java M fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java M fe/src/main/java/org/apache/impala/analysis/AggregateInfoBase.java M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java M fe/src/main/java/org/apache/impala/analysis/BoolLiteral.java M fe/src/main/java/org/apache/impala/analysis/CaseExpr.java M fe/src/main/java/org/apache/impala/analysis/CastExpr.java M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java M fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java M fe/src/main/java/org/apache/impala/analysis/NullLiteral.java M fe/src/main/java/org/apache/impala/analysis/NumericLiteral.java M fe/src/main/java/org/apache/impala/analysis/Path.java M fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java M fe/src/main/java/org/apache/impala/analysis/SlotRef.java M fe/src/main/java/org/apache/impala/analysis/StringLiteral.java M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java M fe/src/main/java/org/apache/impala/catalog/Column.java M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java M fe/src/main/java/org/apache/impala/catalog/DataSource.java M fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/catalog/TableLoader.java M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java M fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java M fe/src/main/java/org/apache/impala/planner/DataPartition.java M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java M fe/src/main/java/org/apache/impala/planner/HashJoinNode.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/NestedLoopJoinNode.java M fe/src/main/java/org/apache/impala/planner/ScanNode.java M fe/src/main/java/org/apache/impala/planner/SortNode.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/util/JvmPauseMonitor.java M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java M impala-parent/pom.xml 47 files changed, 102 insertions(+), 92 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/15214/7 -- To view, visit http://gerrit.cloudera.org:8080/15214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9690a926953a8d3c3872277680b4be0551546c68 Gerrit-Change-Number: 15214 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9107 (part 1): Add scripts to produce an m2 archive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 15 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 22 Mar 2020 21:08:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107 (part 1): Add scripts to produce an m2 archive
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive .. IMPALA-9107 (part 1): Add scripts to produce an m2 archive The maven build downloads a large number of artifacts from various maven repositories. When starting with an empty .m2 directory (like most upstream Jenkins jobs), downloading all the artifacts can take up to 30 minutes. This has been slowing down our precommit builds by 15-20 minutes. This adds a script to archive the .m2 directory into a tarball while excluding artifacts from impala.cdp.repo and impala.cdh.repo. This will later be used to prepopulate the .m2 directory for Jenkins jobs. This adds a script to parse the maven log and output how many maven artifacts are downloaded from each repository. It also prints how many downloads were attempted for each repository. This might aid in diagnosing slowness. This also changes mvn-quiet.sh to add logging that prints a timestamp. It also adds the -B flag to mvn, which causes maven to run in batch mode. This makes the output easier to parse, because maven omits special console formatting characters such as ^M (carriange return). This changes build-all-flag-combinations.sh to print the maven statistics after each part of the build and call the script to produce an m2 archive at the end. Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Reviewed-on: http://gerrit.cloudera.org:8080/14562 Reviewed-by: Laszlo Gaal Tested-by: Impala Public Jenkins --- A bin/jenkins/archive_m2_directory.sh M bin/jenkins/build-all-flag-combinations.sh A bin/jenkins/get_maven_statistics.sh M bin/mvn-quiet.sh M impala-parent/pom.xml 5 files changed, 155 insertions(+), 1 deletion(-) Approvals: Laszlo Gaal: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 16 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 ) Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5557/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28eeccd7f9ccae39e31972391f971901bcbfe986 Gerrit-Change-Number: 15511 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: David Rorke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Sun, 22 Mar 2020 18:13:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107 (part 1): Add scripts to produce an m2 archive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive .. Patch Set 15: -Verified -Code-Review Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5556/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 15 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 22 Mar 2020 16:48:03 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-9434: Implement Robin Hood Hash Table.
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15511 Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. .. WIP IMPALA-9434: Implement Robin Hood Hash Table. Robin hood hashing reduces the variances of probe lengths by continually rebalancing elements. This commit implement robin hood hashing behavior into exec/hash-table.h with small modification to the robin hood algorithm to keep probe function of hash-table intact. Instead of proactively swapping elements during insertion, the algorithm does the rebalancing by first letting the new element probe an empty bucket and claim it through PrepareBucketForInsert(). After the bucket at index curr_idx claimed, the rebalancing algorithm in function Rebalance() walk through the probe sequence again to find richer or empty bucket to swap with bucket[curr_idx]. The search and swapping continue until it swap with empty bucket or does not find any richer bucket along the probe sequence. It effectively treat bucket[curr_idx] as temporary variable during the rebalancing process. Rebalance() return the new index of the recently claimed bucket after rebalancing process done. The decision to not swap elements proactively is because the probe function is used for both insertion and lookup-only. Keeping probing routine decoupled from insertion routine allow us to invoke rebalance only after bucket claim, not on lookup-only. Insert into an already filed bucket (duplicates), or insert using hash-table iterator does not trigger rebalance. Testing: - Pass core tests Change-Id: I28eeccd7f9ccae39e31972391f971901bcbfe986 --- M be/src/exec/hash-table.h M be/src/exec/hash-table.inline.h 2 files changed, 94 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/15511/3 -- To view, visit http://gerrit.cloudera.org:8080/15511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I28eeccd7f9ccae39e31972391f971901bcbfe986 Gerrit-Change-Number: 15511 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: David Rorke Gerrit-Reviewer: Riza Suminto
[Impala-ASF-CR] IMPALA-9406 Add some new packages to download
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15253 ) Change subject: IMPALA-9406 Add some new packages to download .. Patch Set 1: Hey Zhao, I wonder if this is still necessary. You mention that you need these packages for building Kudu, so I assume you need to build Kudu because the CDH_KUDU and CDP_KUDU are not provided on ARM for you ARM efforts. However, since commit 14ae6eae1e3e0ff78040ae2bad92d36d745cf365 on master (commit title: "IMPALA-9279: Update the Kudu version to include VARCHAR support") Kudu can be integrated (again) via the toolchain, which may be a cleaner way for you. Please note that I have no problems adding the packages, I'm just curious about the use case that requires them. Thanks, - Laszlo -- To view, visit http://gerrit.cloudera.org:8080/15253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b3404b7c067a78689197c774b3b63115ea4339e Gerrit-Change-Number: 15253 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sun, 22 Mar 2020 14:59:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107 (part 1): Add scripts to produce an m2 archive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive .. Patch Set 15: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5513/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 15 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 22 Mar 2020 14:48:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107 (part 1): Add scripts to produce an m2 archive
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive .. Patch Set 15: Code-Review+2 Rebased, no change in the files, carry +2 from Tim -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 15 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 22 Mar 2020 14:48:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107 (part 1): Add scripts to produce an m2 archive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive .. Patch Set 14: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5512/ -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 14 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 22 Mar 2020 14:47:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107 (part 1): Add scripts to produce an m2 archive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 14 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 22 Mar 2020 14:46:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9107 (part 1): Add scripts to produce an m2 archive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 ) Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive .. Patch Set 14: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5512/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 14 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 22 Mar 2020 14:46:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 4: Code-Review+1 LGTM. Tim or Zoltan, do you want to take a look? -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sun, 22 Mar 2020 14:35:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15297 ) Change subject: IMPALA-9426 Download Python dependencies even skipping bootstrap toolchain .. Patch Set 1: Code-Review+2 LGTM. Thanks for fixing this; it has bothered me for some time too. -- To view, visit http://gerrit.cloudera.org:8080/15297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I012314793ffb521001951ab7ec3d7a3ba737c405 Gerrit-Change-Number: 15297 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sun, 22 Mar 2020 14:34:14 + Gerrit-HasComments: No
