[Impala-ASF-CR] IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21455 ) Change subject: IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc@373 PS2, Line 373: mem_for_64_entries Looks like the 64 is the sampling number, can we give the 64 a const, and rename the mem_for_64_entries to mem_for_sampling_entries? http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc@378 PS2, Line 378: if (capacity_ > 1) Should "if (capacity_ > 0)" also hold the DCHECK? Or is it possible that the mem_usage can exceed the MAX_EXPR_VALUES_CACHE_BYTES in that case? Maybe we can log something if mem_usage can exceed MAX_EXPR_VALUES_CACHE_BYTES and the case is rare -- To view, visit http://gerrit.cloudera.org:8080/21455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee27cbbe8d3100301d05a6516b62c45975a8d0e0 Gerrit-Change-Number: 21455 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 25 May 2024 16:53:42 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11871: Skip permissions loading and check on HDFS if Ranger is enabled
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20221 ) Change subject: IMPALA-11871: Skip permissions loading and check on HDFS if Ranger is enabled .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/20221/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/20221/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@931 PS11, Line 931: nit. unnecessary newline http://gerrit.cloudera.org:8080/#/c/20221/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@3241 PS11, Line 3241: nit. unnecessary newline http://gerrit.cloudera.org:8080/#/c/20221/11/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/20221/11/tests/authorization/test_ranger.py@87 PS11, Line 87: Impala does not throw an AnalysisException Am I right in saying that if a ranger user doesn't have write permissions, this patch will allow the analysis check to pass but eventually result in another exception in this insertion case because the user lacks the necessary rights? -- To view, visit http://gerrit.cloudera.org:8080/20221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id33c400fbe0c918b6b65d713b09009512835a4c9 Gerrit-Change-Number: 20221 Gerrit-PatchSet: 11 Gerrit-Owner: Halim Kim Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Halim Kim Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Sat, 25 May 2024 16:05:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13108: Update version to 4.5.0-SNAPSHOT
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21460 ) Change subject: IMPALA-13108: Update version to 4.5.0-SNAPSHOT .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16221/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7803fe523406dbdd1ac066a35bb31d21765a244 Gerrit-Change-Number: 21460 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Sat, 25 May 2024 08:55:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13108: Update version to 4.5.0-SNAPSHOT
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21460 Change subject: IMPALA-13108: Update version to 4.5.0-SNAPSHOT .. IMPALA-13108: Update version to 4.5.0-SNAPSHOT Updated IMPALA_VERSION in impala-config.sh Executed the followings for Java: cd java mvn versions:set -DnewVersion=4.5.0-SNAPSHOT Change-Id: Ie7803fe523406dbdd1ac066a35bb31d21765a244 --- M bin/impala-config.sh M fe/pom.xml M java/TableFlattener/pom.xml M java/calcite-planner/pom.xml M java/datagenerator/pom.xml M java/executor-deps/pom.xml M java/ext-data-source/api/pom.xml M java/ext-data-source/jdbc/pom.xml M java/ext-data-source/pom.xml M java/ext-data-source/sample/pom.xml M java/ext-data-source/test/pom.xml M java/external-frontend/pom.xml M java/pom.xml M java/query-event-hook-api/pom.xml M java/shaded-deps/hive-exec/pom.xml M java/shaded-deps/s3a-aws-sdk/pom.xml M java/test-corrupt-hive-udfs/pom.xml M java/test-hive-udfs/pom.xml M java/yarn-extras/pom.xml 19 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21460/1 -- To view, visit http://gerrit.cloudera.org:8080/21460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie7803fe523406dbdd1ac066a35bb31d21765a244 Gerrit-Change-Number: 21460 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
[Impala-ASF-CR](asf-site) Add documentation, update links for 4.4.0
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21311 ) Change subject: Add documentation, update links for 4.4.0 .. Add documentation, update links for 4.4.0 Change-Id: Ibb93f7ba80b7a065ea83660fc75be9b065138ad9 Reviewed-on: http://gerrit.cloudera.org:8080/21311 Reviewed-by: Zoltan Borok-Nagy Tested-by: Zoltan Borok-Nagy --- M docs/build/asf-site-html/index.html M docs/build/asf-site-html/shared/ImpalaVariables.html M docs/build/asf-site-html/shared/impala_common.html M docs/build/asf-site-html/topics/impala_abort_on_error.html M docs/build/asf-site-html/topics/impala_adls.html M docs/build/asf-site-html/topics/impala_admin.html M docs/build/asf-site-html/topics/impala_admission.html M docs/build/asf-site-html/topics/impala_admission_config.html M docs/build/asf-site-html/topics/impala_aggregate_functions.html M docs/build/asf-site-html/topics/impala_aliases.html M docs/build/asf-site-html/topics/impala_allow_erasure_coded_files.html M docs/build/asf-site-html/topics/impala_allow_unsupported_formats.html M docs/build/asf-site-html/topics/impala_alter_database.html M docs/build/asf-site-html/topics/impala_alter_table.html M docs/build/asf-site-html/topics/impala_alter_view.html M docs/build/asf-site-html/topics/impala_analytic_functions.html M docs/build/asf-site-html/topics/impala_appx_count_distinct.html M docs/build/asf-site-html/topics/impala_appx_median.html M docs/build/asf-site-html/topics/impala_array.html M docs/build/asf-site-html/topics/impala_auditing.html M docs/build/asf-site-html/topics/impala_authentication.html M docs/build/asf-site-html/topics/impala_authorization.html M docs/build/asf-site-html/topics/impala_avg.html M docs/build/asf-site-html/topics/impala_avro.html M docs/build/asf-site-html/topics/impala_batch_size.html M docs/build/asf-site-html/topics/impala_bigint.html M docs/build/asf-site-html/topics/impala_bit_functions.html M docs/build/asf-site-html/topics/impala_boolean.html M docs/build/asf-site-html/topics/impala_breakpad.html M docs/build/asf-site-html/topics/impala_broadcast_bytes_limit.html M docs/build/asf-site-html/topics/impala_buffer_pool_limit.html M docs/build/asf-site-html/topics/impala_char.html M docs/build/asf-site-html/topics/impala_client.html M docs/build/asf-site-html/topics/impala_comment.html M docs/build/asf-site-html/topics/impala_comments.html M docs/build/asf-site-html/topics/impala_complex_types.html M docs/build/asf-site-html/topics/impala_components.html M docs/build/asf-site-html/topics/impala_compression_codec.html M docs/build/asf-site-html/topics/impala_compute_stats.html M docs/build/asf-site-html/topics/impala_compute_stats_min_sample_size.html M docs/build/asf-site-html/topics/impala_concepts.html M docs/build/asf-site-html/topics/impala_conditional_functions.html M docs/build/asf-site-html/topics/impala_config.html M docs/build/asf-site-html/topics/impala_config_options.html M docs/build/asf-site-html/topics/impala_config_performance.html M docs/build/asf-site-html/topics/impala_connecting.html M docs/build/asf-site-html/topics/impala_conversion_functions.html M docs/build/asf-site-html/topics/impala_count.html M docs/build/asf-site-html/topics/impala_create_database.html M docs/build/asf-site-html/topics/impala_create_function.html M docs/build/asf-site-html/topics/impala_create_role.html M docs/build/asf-site-html/topics/impala_create_table.html M docs/build/asf-site-html/topics/impala_create_view.html M docs/build/asf-site-html/topics/impala_custom_timezones.html M docs/build/asf-site-html/topics/impala_data_cache.html M docs/build/asf-site-html/topics/impala_databases.html M docs/build/asf-site-html/topics/impala_datatypes.html M docs/build/asf-site-html/topics/impala_date.html M docs/build/asf-site-html/topics/impala_datetime_functions.html M docs/build/asf-site-html/topics/impala_ddl.html M docs/build/asf-site-html/topics/impala_debug_action.html M docs/build/asf-site-html/topics/impala_decimal.html M docs/build/asf-site-html/topics/impala_decimal_v2.html M docs/build/asf-site-html/topics/impala_dedicated_coordinator.html M docs/build/asf-site-html/topics/impala_default_file_format.html M docs/build/asf-site-html/topics/impala_default_hints_insert_statement.html M docs/build/asf-site-html/topics/impala_default_join_distribution_mode.html M docs/build/asf-site-html/topics/impala_default_spillable_buffer_size.html M docs/build/asf-site-html/topics/impala_default_transactional_type.html M docs/build/asf-site-html/topics/impala_delegation.html M docs/build/asf-site-html/topics/impala_delete.html M docs/build/asf-site-html/topics/impala_delete_stats_in_truncate.html M docs/build/asf-site-html/topics/impala_describe.html M docs/build/asf-site-html/topics/impala_development.html M docs/build/asf-site-html/topics/impala_disable_codegen.html M docs/build/asf-site-html/topics/impala_disable_codegen_rows_threshold.html M docs
[Impala-ASF-CR](asf-site) Update download links for release 4.4.0
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21307 ) Change subject: Update download links for release 4.4.0 .. Update download links for release 4.4.0 Change-Id: Ie0e8736154e5289e02d5ec5cf5f664cd4de2739d Reviewed-on: http://gerrit.cloudera.org:8080/21307 Reviewed-by: Laszlo Gaal Tested-by: Zoltan Borok-Nagy --- M downloads.html 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Laszlo Gaal: Looks good to me, approved Zoltan Borok-Nagy: Verified -- To view, visit http://gerrit.cloudera.org:8080/21307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: merged Gerrit-Change-Id: Ie0e8736154e5289e02d5ec5cf5f664cd4de2739d Gerrit-Change-Number: 21307 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR](asf-site) Add documentation, update links for 4.4.0
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21311 ) Change subject: Add documentation, update links for 4.4.0 .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ibb93f7ba80b7a065ea83660fc75be9b065138ad9 Gerrit-Change-Number: 21311 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 25 May 2024 08:03:01 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Update download links for release 4.4.0
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21307 ) Change subject: Update download links for release 4.4.0 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e8736154e5289e02d5ec5cf5f664cd4de2739d Gerrit-Change-Number: 21307 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 25 May 2024 08:02:53 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add documentation, update links for 4.4.0
Zoltan Borok-Nagy has removed a vote on this change. Change subject: Add documentation, update links for 4.4.0 .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/21311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ibb93f7ba80b7a065ea83660fc75be9b065138ad9 Gerrit-Change-Number: 21311 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins
