[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12800 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell The change handles the exception thrown by shlex while parsing a malformed query. This patch was tested by adding both commandline and interactive shell tests. Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Reviewed-on: http://gerrit.cloudera.org:8080/10876 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/12800 Reviewed-by: Fredy Wijaya --- M shell/impala_shell.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py 3 files changed, 25 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Verified Fredy Wijaya: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Gerrit-Change-Number: 12800 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12800 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Gerrit-Change-Number: 12800 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 21 Mar 2019 14:07:52 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12800 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Gerrit-Change-Number: 12800 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 21 Mar 2019 08:30:49 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12800 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3933/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/12800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Gerrit-Change-Number: 12800 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 21 Mar 2019 04:40:00 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12800 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2473/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Gerrit-Change-Number: 12800 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 20 Mar 2019 02:44:48 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12800 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 1: This is a clean pick. -- To view, visit http://gerrit.cloudera.org:8080/12800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Gerrit-Change-Number: 12800 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 20 Mar 2019 02:26:33 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12800 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12800/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/12800/1/shell/impala_shell.py@1153 PS1, Line 1153: : flake8: E701 multiple statements on one line (colon) http://gerrit.cloudera.org:8080/#/c/12800/1/shell/impala_shell.py@1155 PS1, Line 1155: e flake8: F841 local variable 'e' is assigned to but never used -- To view, visit http://gerrit.cloudera.org:8080/12800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Gerrit-Change-Number: 12800 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 20 Mar 2019 02:06:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12800 to review the following change. Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell The change handles the exception thrown by shlex while parsing a malformed query. This patch was tested by adding both commandline and interactive shell tests. Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Reviewed-on: http://gerrit.cloudera.org:8080/10876 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M shell/impala_shell.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py 3 files changed, 25 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12800/1 -- To view, visit http://gerrit.cloudera.org:8080/12800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Gerrit-Change-Number: 12800 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar
