[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Reviewed-on: http://gerrit.cloudera.org:8080/13773 Tested-by: Impala Public Jenkins Reviewed-by: Joe McDonnell --- M docs/topics/impala_txtfile.xml 1 file changed, 28 insertions(+), 23 deletions(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. Patch Set 2: Code-Review+2 I looked up the sqoop documentation, and this change is correct. https://sqoop.apache.org/docs/1.4.6/SqoopUserGuide.html#_importing_data_into_hive Thanks for making this change. -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 02 Jul 2019 23:55:37 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/369/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 02 Jul 2019 18:44:51 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/369/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 02 Jul 2019 18:21:46 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13773 to look at the new patch set (#2). Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null Change-Id: I581f532c2f865e93d8922661c389791f41805b64 --- M docs/topics/impala_txtfile.xml 1 file changed, 28 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/13773/2 -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml@308 PS1, Line 308: --null-string '\\N' --null-non-string : '\\N' > On the commandline, there is a difference between single and double quotes: In Impala shell, only \\N worked both with single and double quotes. http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml@392 PS1, Line 392: specify : to represent > The "\N" in the old version got dropped, so this is curren Done http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml@394 PS1, Line 394: needs to be escaped as '\\N' when : used in a string. > I'm a bit confused about what this is trying to get across. In the actual t Done -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 02 Jul 2019 18:21:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. Patch Set 1: (3 comments) What is the origin of this change? Did someone complain about this? http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml@308 PS1, Line 308: --null-string '\\N' --null-non-string : '\\N' On the commandline, there is a difference between single and double quotes: $ echo "\\N" \N $ echo '\\N' \\N In this case, I believe it should be either double quotes with the escaping or single quotes without the escaping. i.e. "\\N" or '\N' http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml@392 PS1, Line 392: specify : to represent The "\N" in the old version got dropped, so this is currently: "specify to represent" I think it should be: "specify \N to represent" http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml@394 PS1, Line 394: needs to be escaped as '\\N' when : used in a string. I'm a bit confused about what this is trying to get across. In the actual text file, it should be \N. Users can write text files several different ways. Some require escaping, some don't. I think I would rather leave this paragraph the way it was. -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 02 Jul 2019 18:10:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/362/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 01 Jul 2019 21:54:21 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 ) Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/362/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 01 Jul 2019 21:32:05 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13773 Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null .. [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null Change-Id: I581f532c2f865e93d8922661c389791f41805b64 --- M docs/topics/impala_txtfile.xml 1 file changed, 21 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/13773/1 -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
