[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..

[DOCS] DECIMAL_V2 default value is now TRUE

Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Reviewed-on: http://gerrit.cloudera.org:8080/12870
Tested-by: Impala Public Jenkins 
Reviewed-by: Greg Rahn 
---
M docs/topics/impala_decimal_v2.xml
M docs/topics/impala_upgrading.xml
2 files changed, 11 insertions(+), 13 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Greg Rahn: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 4: Code-Review+2

LGTM


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 29 Mar 2019 00:20:14 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 4: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/295/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 28 Mar 2019 23:49:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12870/3/docs/topics/impala_decimal_v2.xml
File docs/topics/impala_decimal_v2.xml:

http://gerrit.cloudera.org:8080/#/c/12870/3/docs/topics/impala_decimal_v2.xml@36
PS3, Line 36: Impala 2.11
> I think this can be generalized to just 2.x behavior since V1 behavior is t
Done



--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 28 Mar 2019 23:33:20 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/295/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 28 Mar 2019 23:33:16 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12870

to look at the new patch set (#4).

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..

[DOCS] DECIMAL_V2 default value is now TRUE

Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
---
M docs/topics/impala_decimal_v2.xml
M docs/topics/impala_upgrading.xml
2 files changed, 11 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/12870/4
--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12870/3/docs/topics/impala_decimal_v2.xml
File docs/topics/impala_decimal_v2.xml:

http://gerrit.cloudera.org:8080/#/c/12870/3/docs/topics/impala_decimal_v2.xml@36
PS3, Line 36: Impala 2.11
I think this can be generalized to just 2.x behavior since V1 behavior is the 
default in all of 2.x, even in the releases that had V2 as an opt in.



--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 28 Mar 2019 21:29:28 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 3: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/294/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 28 Mar 2019 20:48:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/294/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 28 Mar 2019 20:28:45 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-28 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12870

to look at the new patch set (#3).

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..

[DOCS] DECIMAL_V2 default value is now TRUE

Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
---
M docs/topics/impala_decimal_v2.xml
M docs/topics/impala_upgrading.xml
2 files changed, 12 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/12870/3
--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 2: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/292/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 27 Mar 2019 20:02:52 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 1: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/291/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Greg Rahn 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 27 Mar 2019 20:01:14 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-27 Thread Alex Rodoni (Code Review)
Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12870

to look at the new patch set (#2).

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..

[DOCS] DECIMAL_V2 default value is now TRUE

Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
---
M docs/topics/impala_decimal_v2.xml
1 file changed, 7 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/12870/2
--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-27 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 27 Mar 2019 19:41:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/292/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 27 Mar 2019 19:46:15 +
Gerrit-HasComments: No


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-27 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12870


Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..

[DOCS] DECIMAL_V2 default value is now TRUE

Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
---
M docs/topics/impala_decimal_v2.xml
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/12870/1
--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 


[Impala-ASF-CR] [DOCS] DECIMAL V2 default value is now TRUE

2019-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12870 )

Change subject: [DOCS] DECIMAL_V2 default value is now TRUE
..


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/291/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/12870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eaa144a49e1d72a20982e0b8cf4f4a36142c578
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 27 Mar 2019 19:40:50 +
Gerrit-HasComments: No