[Impala-ASF-CR] Added timeout to run-all-tests
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/12086/7/bin/run-all-tests-timeout-check.sh File bin/run-all-tests-timeout-check.sh: http://gerrit.cloudera.org:8080/#/c/12086/7/bin/run-all-tests-timeout-check.sh@40 PS7, Line 40: every 60 seconds the call to "sleep 1" below sleeps for one second, not one minute. -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 7 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 10 Jan 2019 22:48:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Added timeout to run-all-tests Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Reviewed-on: http://gerrit.cloudera.org:8080/12086 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/impala-config.sh A bin/run-all-tests-timeout-check.sh M bin/run-all-tests.sh 3 files changed, 85 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 7 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 6 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 03 Jan 2019 22:30:50 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3609/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 6 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 03 Jan 2019 18:09:36 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 6 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 03 Jan 2019 18:09:35 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 03 Jan 2019 18:08:39 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 20 Dec 2018 22:31:50 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3592/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 20 Dec 2018 18:21:43 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1653/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 20 Dec 2018 17:48:51 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Hello Lars Volker, Michael Brown, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12086 to look at the new patch set (#4). Change subject: Added timeout to run-all-tests .. Added timeout to run-all-tests Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b --- M bin/impala-config.sh A bin/run-all-tests-timeout-check.sh M bin/run-all-tests.sh 3 files changed, 85 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/12086/4 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 20 Dec 2018 16:55:48 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 2: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/1650/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 20 Dec 2018 01:33:36 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 20 Dec 2018 00:50:47 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 20 Dec 2018 00:48:00 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Hello Lars Volker, Michael Brown, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12086 to look at the new patch set (#2). Change subject: Added timeout to run-all-tests .. Added timeout to run-all-tests Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b --- M bin/impala-config.sh A bin/run-all-tests-timeout-check.sh M bin/run-all-tests.sh 3 files changed, 67 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/12086/2 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] Added timeout to run-all-tests
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/12086 )
Change subject: Added timeout to run-all-tests
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh
File bin/run-all-tests-timeout-check.sh:
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@8
PS1, Line 8: echo "Expected timeout value as an argument"
> add exit 1?
Done
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@22
PS1, Line 22: SECONDS=0
> This confused me!
Done
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@24
PS1, Line 24: sleep 60
> I think you can reasonably just sleep 1 here and avoid the complication of
Done
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@25
PS1, Line 25: [[ -z "$(ps -p $PPID -o pid=)" ]] && exit
> This is just:
Done
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@45
PS1, Line 45: gdb -ex "set pagination 0" -ex "thread apply all bt" --batch
-p $pid > \
> I'm surprised we need "set pagination" in addition to --batch.
Done
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@52
PS1, Line 52: "Test run timed out"
> Explain where to find information? ($IMPALA_TIMEOUT_LOGS_DIR)
Done
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests.sh@34
PS1, Line 34: : ${TIMEOUT_FOR_RUN_ALL_TESTS_MINS:=0}
> Any reason not to default this to something high, like 20 hours?
no particular reason, just did not want to modify the current behavior. will
change the default to 20hrs as you suggested.
--
To view, visit http://gerrit.cloudera.org:8080/12086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b
Gerrit-Change-Number: 12086
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig
Gerrit-Reviewer: Bikramjeet Vig
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Michael Brown
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:43:02 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] Added timeout to run-all-tests
Michael Brown has posted comments on this change. (
http://gerrit.cloudera.org:8080/12086 )
Change subject: Added timeout to run-all-tests
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh
File bin/run-all-tests-timeout-check.sh:
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@52
PS1, Line 52: "Test run timed out"
Explain where to find information? ($IMPALA_TIMEOUT_LOGS_DIR)
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests.sh@34
PS1, Line 34: : ${TIMEOUT_FOR_RUN_ALL_TESTS_MINS:=0}
Any reason not to default this to something high, like 20 hours?
--
To view, visit http://gerrit.cloudera.org:8080/12086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b
Gerrit-Change-Number: 12086
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Michael Brown
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Mon, 17 Dec 2018 17:50:21 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] Added timeout to run-all-tests
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 1: (5 comments) Thanks! This is just below my threshold for asking you to write it in python, but I think it'd be shorter there if you wanted to go that route. If you wanted to avoid writing the loop to wait for a process to finish, you could do: timeout 60 bash -c 'while true; do ps 15796 &> /dev/null || exit 0; sleep 1; done' (Making the pid there a variable is an exercise.) Once that timeout is done, you have to figure out whether or not you need to do the gdb business. http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh File bin/run-all-tests-timeout-check.sh: http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@8 PS1, Line 8: echo "Expected timeout value as an argument" add exit 1? http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@22 PS1, Line 22: SECONDS=0 This confused me! SECONDS is a built-in, as you know, but someone who doesn't know, (or even somebody like me who knew and was about to tell you) is super confused because you're treating it like a normal variable not not resetting it. Anyway, I don't think you need "SECONDS=0" here at all, but you need a comment that "$SECONDS is a bash built-in that counts seconds since bash started. http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@24 PS1, Line 24: sleep 60 I think you can reasonably just sleep 1 here and avoid the complication of repeating yourself in lines 28-30. http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@25 PS1, Line 25: [[ -z "$(ps -p $PPID -o pid=)" ]] && exit This is just: ps $PPID &> /dev/null || exit i.e., you can use the exit code of ps to check for a process. http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-tests-timeout-check.sh@45 PS1, Line 45: gdb -ex "set pagination 0" -ex "thread apply all bt" --batch -p $pid > \ I'm surprised we need "set pagination" in addition to --batch. -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 14 Dec 2018 18:04:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Added timeout to run-all-tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/1605/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Fri, 14 Dec 2018 17:28:46 + Gerrit-HasComments: No
[Impala-ASF-CR] Added timeout to run-all-tests
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12086 Change subject: Added timeout to run-all-tests .. Added timeout to run-all-tests Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b --- M bin/impala-config.sh A bin/run-all-tests-timeout-check.sh M bin/run-all-tests.sh 3 files changed, 72 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/12086/1 -- To view, visit http://gerrit.cloudera.org:8080/12086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iefd3e16a973709f27aeffc7a15bcab8fcdbb349b Gerrit-Change-Number: 12086 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
