[Impala-ASF-CR] Allow CMake to find JNI libraries from JDK
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12580 ) Change subject: Allow CMake to find JNI libraries from JDK .. Allow CMake to find JNI libraries from JDK JNI libraries can be in JAVA_HOME/jre/lib/amd64 or JAVA_HOME/lib/amd64. We were missing one entry in the list of places to look. This came up when I built a custom OpenJDK for myself and wanted to use it for building. Change-Id: I6e9f9e5b96e2a1c3c0b0ad6cae1a34ca22c1ec19 Reviewed-on: http://gerrit.cloudera.org:8080/12580 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M cmake_modules/FindJNI.cmake 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6e9f9e5b96e2a1c3c0b0ad6cae1a34ca22c1ec19 Gerrit-Change-Number: 12580 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Allow CMake to find JNI libraries from JDK
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12580 ) Change subject: Allow CMake to find JNI libraries from JDK .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e9f9e5b96e2a1c3c0b0ad6cae1a34ca22c1ec19 Gerrit-Change-Number: 12580 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 26 Feb 2019 04:25:57 + Gerrit-HasComments: No
[Impala-ASF-CR] Allow CMake to find JNI libraries from JDK
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12580 ) Change subject: Allow CMake to find JNI libraries from JDK .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e9f9e5b96e2a1c3c0b0ad6cae1a34ca22c1ec19 Gerrit-Change-Number: 12580 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 26 Feb 2019 00:16:39 + Gerrit-HasComments: No
[Impala-ASF-CR] Allow CMake to find JNI libraries from JDK
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12580 ) Change subject: Allow CMake to find JNI libraries from JDK .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3827/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e9f9e5b96e2a1c3c0b0ad6cae1a34ca22c1ec19 Gerrit-Change-Number: 12580 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 26 Feb 2019 00:20:50 + Gerrit-HasComments: No
[Impala-ASF-CR] Allow CMake to find JNI libraries from JDK
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12580 ) Change subject: Allow CMake to find JNI libraries from JDK .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e9f9e5b96e2a1c3c0b0ad6cae1a34ca22c1ec19 Gerrit-Change-Number: 12580 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 26 Feb 2019 00:20:49 + Gerrit-HasComments: No
[Impala-ASF-CR] Allow CMake to find JNI libraries from JDK
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12580 ) Change subject: Allow CMake to find JNI libraries from JDK .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2238/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e9f9e5b96e2a1c3c0b0ad6cae1a34ca22c1ec19 Gerrit-Change-Number: 12580 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 26 Feb 2019 00:15:08 + Gerrit-HasComments: No
[Impala-ASF-CR] Allow CMake to find JNI libraries from JDK
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12580 Change subject: Allow CMake to find JNI libraries from JDK .. Allow CMake to find JNI libraries from JDK JNI libraries can be in JAVA_HOME/jre/lib/amd64 or JAVA_HOME/lib/amd64. We were missing one entry in the list of places to look. This came up when I built a custom OpenJDK for myself and wanted to use it for building. Change-Id: I6e9f9e5b96e2a1c3c0b0ad6cae1a34ca22c1ec19 --- M cmake_modules/FindJNI.cmake 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/12580/1 -- To view, visit http://gerrit.cloudera.org:8080/12580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6e9f9e5b96e2a1c3c0b0ad6cae1a34ca22c1ec19 Gerrit-Change-Number: 12580 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger
