[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1235229

2019-07-09 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13799 )

Change subject: Bump CDP_BUILD_NUMBER to 1235229
..

Bump CDP_BUILD_NUMBER to 1235229

The newer CDP build includes fix for HIVE-21932 which is required to fix
test failures on CDP builds.

Also, this patch fixes two test failures on CDP.

1 Fixes the MetastoreEventsProcessorTest on CDP caused due to the
serialization difference of the event messages between CDH and CDP
builds.
2. Fixes the Ranger audit test failure caused due to the missing cluster
name paramter from the Audit events from Ranger. This is needed a change
in the ranger-hive-audit.xml due to RANGER-2458

Testing:
1. Build against CDP and CDH builds
2. Run the previously failing tests on CDP which were caused by
HIVE-21932
3. Run full tests with CDP and CDH builds

Change-Id: I6d0fa856fa6c7cb1f4c9ee0e4250cfa1e8a14595
Reviewed-on: http://gerrit.cloudera.org:8080/13799
Reviewed-by: Zoltan Borok-Nagy 
Tested-by: Impala Public Jenkins 
---
M bin/impala-config.sh
M fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/resources/ranger-hive-audit.xml
6 files changed, 37 insertions(+), 19 deletions(-)

Approvals:
  Zoltan Borok-Nagy: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/13799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d0fa856fa6c7cb1f4c9ee0e4250cfa1e8a14595
Gerrit-Change-Number: 13799
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1235229

2019-07-09 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13799 )

Change subject: Bump CDP_BUILD_NUMBER to 1235229
..


Patch Set 3:

> > Lgtm, is it only WIP because the testing is in progress?
 >
 > Yes, I noticed that Ranger audit test was failing since the new CDP
 > build has fix for RANGER-2458 which required additional change to
 > ranger-hive-audit.xml. Now this updated patch has a green run on
 > CDP build.

Let me correct my statement above. The CDP full-tests is not green but it fixes 
the MetastoreEventsProcessorTest which was failing earlier. There are some Kudu 
tests which are still failing on CDP builds. But I think they are unrelated to 
this. The CDH build is successful. So I am going to go ahead and submit this 
patch. The Kudu tests will need a separate patch to really get to a green build 
on Hive-3


--
To view, visit http://gerrit.cloudera.org:8080/13799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d0fa856fa6c7cb1f4c9ee0e4250cfa1e8a14595
Gerrit-Change-Number: 13799
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 10 Jul 2019 04:46:59 +
Gerrit-HasComments: No


[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1235229

2019-07-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13799 )

Change subject: Bump CDP_BUILD_NUMBER to 1235229
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d0fa856fa6c7cb1f4c9ee0e4250cfa1e8a14595
Gerrit-Change-Number: 13799
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 09 Jul 2019 21:56:33 +
Gerrit-HasComments: No


[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1235229

2019-07-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13799 )

Change subject: Bump CDP_BUILD_NUMBER to 1235229
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3849/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d0fa856fa6c7cb1f4c9ee0e4250cfa1e8a14595
Gerrit-Change-Number: 13799
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 09 Jul 2019 16:12:02 +
Gerrit-HasComments: No


[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1235229

2019-07-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13799 )

Change subject: Bump CDP_BUILD_NUMBER to 1235229
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d0fa856fa6c7cb1f4c9ee0e4250cfa1e8a14595
Gerrit-Change-Number: 13799
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 09 Jul 2019 15:58:46 +
Gerrit-HasComments: No


[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1235229

2019-07-09 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/13799 )

Change subject: Bump CDP_BUILD_NUMBER to 1235229
..

Bump CDP_BUILD_NUMBER to 1235229

The newer CDP build includes fix for HIVE-21932 which is required to fix
test failures on CDP builds.

Also, this patch fixes two test failures on CDP.

1 Fixes the MetastoreEventsProcessorTest on CDP caused due to the
serialization difference of the event messages between CDH and CDP
builds.
2. Fixes the Ranger audit test failure caused due to the missing cluster
name paramter from the Audit events from Ranger. This is needed a change
in the ranger-hive-audit.xml due to RANGER-2458

Testing:
1. Build against CDP and CDH builds
2. Run the previously failing tests on CDP which were caused by
HIVE-21932
3. Run full tests with CDP and CDH builds

Change-Id: I6d0fa856fa6c7cb1f4c9ee0e4250cfa1e8a14595
---
M bin/impala-config.sh
M fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/resources/ranger-hive-audit.xml
6 files changed, 37 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/13799/3
--
To view, visit http://gerrit.cloudera.org:8080/13799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d0fa856fa6c7cb1f4c9ee0e4250cfa1e8a14595
Gerrit-Change-Number: 13799
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1235229

2019-07-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13799 )

Change subject: Bump CDP_BUILD_NUMBER to 1235229
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4589/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d0fa856fa6c7cb1f4c9ee0e4250cfa1e8a14595
Gerrit-Change-Number: 13799
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 09 Jul 2019 15:32:56 +
Gerrit-HasComments: No