[Impala-ASF-CR] Clean up stress tests in core
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14002 ) Change subject: Clean up stress tests in core .. Clean up stress tests in core All stress tests in core were skipped or xfailed. Delete the tests and avoid pytest startup overhead (starting up the 64 workers took a significant amount of time) Change-Id: Icc8d948a3a95bd964a7acbe5722f01891a248f11 Reviewed-on: http://gerrit.cloudera.org:8080/14002 Tested-by: Impala Public Jenkins Reviewed-by: David Knupp --- M bin/run-all-tests.sh D tests/stress/test_mini_stress.py 2 files changed, 5 insertions(+), 104 deletions(-) Approvals: Impala Public Jenkins: Verified David Knupp: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icc8d948a3a95bd964a7acbe5722f01891a248f11 Gerrit-Change-Number: 14002 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Clean up stress tests in core
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14002 ) Change subject: Clean up stress tests in core .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14002/1/tests/stress/test_mini_stress.py File tests/stress/test_mini_stress.py: http://gerrit.cloudera.org:8080/#/c/14002/1/tests/stress/test_mini_stress.py@a1 PS1, Line 1: > All of the individual tests in this file either have an xfail or a strip ma OK, just wanted to double check. I wasn't initially sure what run=False meant in the xfail cases -- didn't know if that was our code, or pytest code. -- To view, visit http://gerrit.cloudera.org:8080/14002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc8d948a3a95bd964a7acbe5722f01891a248f11 Gerrit-Change-Number: 14002 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 13 Aug 2019 17:26:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Clean up stress tests in core
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14002 ) Change subject: Clean up stress tests in core .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14002/1/tests/stress/test_mini_stress.py File tests/stress/test_mini_stress.py: http://gerrit.cloudera.org:8080/#/c/14002/1/tests/stress/test_mini_stress.py@a1 PS1, Line 1: > Sorry -- I'm a bit confused. We don't run these tests ever? The code commen All of the individual tests in this file either have an xfail or a strip marker. https://gerrit.cloudera.org/#/c/14002/1/tests/stress/test_ddl_stress.py is still run in exhaustive -- To view, visit http://gerrit.cloudera.org:8080/14002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc8d948a3a95bd964a7acbe5722f01891a248f11 Gerrit-Change-Number: 14002 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 13 Aug 2019 01:02:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Clean up stress tests in core
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14002 ) Change subject: Clean up stress tests in core .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14002/1/tests/stress/test_mini_stress.py File tests/stress/test_mini_stress.py: http://gerrit.cloudera.org:8080/#/c/14002/1/tests/stress/test_mini_stress.py@a1 PS1, Line 1: Sorry -- I'm a bit confused. We don't run these tests ever? The code comment made it seem like they aren't skipped in exhaustive runs, so I would have assumed this file was still needed. -- To view, visit http://gerrit.cloudera.org:8080/14002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc8d948a3a95bd964a7acbe5722f01891a248f11 Gerrit-Change-Number: 14002 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 13 Aug 2019 00:47:55 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Clean up stress tests in core
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14002 ) Change subject: Clean up stress tests in core .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4135/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc8d948a3a95bd964a7acbe5722f01891a248f11 Gerrit-Change-Number: 14002 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Mon, 05 Aug 2019 16:25:00 + Gerrit-HasComments: No
[Impala-ASF-CR] Clean up stress tests in core
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14002 Change subject: Clean up stress tests in core .. Clean up stress tests in core All stress tests in core were skipped or xfailed. Delete the tests and avoid pytest startup overhead (starting up the 64 workers took a significant amount of time) Change-Id: Icc8d948a3a95bd964a7acbe5722f01891a248f11 --- M bin/run-all-tests.sh D tests/stress/test_mini_stress.py 2 files changed, 5 insertions(+), 104 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/14002/1 -- To view, visit http://gerrit.cloudera.org:8080/14002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icc8d948a3a95bd964a7acbe5722f01891a248f11 Gerrit-Change-Number: 14002 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
