[Impala-ASF-CR] Ensure ssh config change is on its own line
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh@303 PS3, Line 303: cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys && chmod 0600 ~/.ssh/authorized_keys Is this file affected by the same issue? -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Mon, 01 Apr 2019 17:12:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2600/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 21:24:18 + Gerrit-HasComments: No
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2599/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 21:19:29 + Gerrit-HasComments: No
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2598/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 21:17:38 + Gerrit-HasComments: No
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh@304 PS3, Line 304: echo -e "\nNoHostAuthenticationForLocalhost yes" >> ~/.ssh/config && chmod 0600 ~/.ssh/config line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 20:40:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12900/2/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12900/2/bin/bootstrap_system.sh@304 PS2, Line 304: echo -e "\nNoHostAuthenticationForLocalhost yes" >> ~/.ssh/config && chmod 0600 ~/.ssh/config line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 20:39:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Ensure ssh config change is on its own line
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#3). Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end in a newline character, than the change in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/3 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Ensure ssh config change is on its own line
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#2). Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end in a newline character, than the change in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/2 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Ensure ssh config change is on its own line
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12900/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12900/1/bin/bootstrap_system.sh@304 PS1, Line 304: echo -e "\nNoHostAuthenticationForLocalhost yes" >> ~/.ssh/config && chmod 0600 ~/.ssh/config line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sun, 31 Mar 2019 20:34:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Ensure ssh config change is on its own line
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12900 Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end in a newline character, than the change in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/1 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
