[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.

2020-11-27 Thread Tim Armstrong (Code Review) 
Tim Armstrong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16778 )

Change subject: Fix for startup crash in scheduler-benchmark.
..

Fix for startup crash in scheduler-benchmark.

Updated scheduler-benchmark's main() to use the newer
impala::InitCommonRuntime() initialization methods.

Before this change the benchmark would compile properly but crash
when run.

Testing:
 * built and ran in debug and release mode.

Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Reviewed-on: http://gerrit.cloudera.org:8080/16778
Reviewed-by: Joe McDonnell 
Tested-by: Impala Public Jenkins 
---
M be/src/benchmarks/scheduler-benchmark.cc
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 3
Gerrit-Owner: Shant Hovsepian 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Shant Hovsepian 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.

2020-11-26 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16778 )

Change subject: Fix for startup crash in scheduler-benchmark.
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Shant Hovsepian 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 27 Nov 2020 02:49:26 +
Gerrit-HasComments: No

[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.

2020-11-26 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16778 )

Change subject: Fix for startup crash in scheduler-benchmark.
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6716/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Shant Hovsepian 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 26 Nov 2020 21:19:46 +
Gerrit-HasComments: No

[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.

2020-11-24 Thread Joe McDonnell (Code Review) 
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16778 )

Change subject: Fix for startup crash in scheduler-benchmark.
..


Patch Set 2: Code-Review+2

This looks good to me.

If you are looking into scheduler performance, one related JIRA is IMPALA-9221.


--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Shant Hovsepian 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 24 Nov 2020 16:34:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.

2020-11-23 Thread Shant Hovsepian (Code Review) 
Hello Aman Sinha, Tim Armstrong, Joe McDonnell, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16778

to look at the new patch set (#2).

Change subject: Fix for startup crash in scheduler-benchmark.
..

Fix for startup crash in scheduler-benchmark.

Updated scheduler-benchmark's main() to use the newer
impala::InitCommonRuntime() initialization methods.

Before this change the benchmark would compile properly but crash
when run.

Testing:
 * built and ran in debug and release mode.

Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
---
M be/src/benchmarks/scheduler-benchmark.cc
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/16778/2
--
To view, visit http://gerrit.cloudera.org:8080/16778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9fba3b97f102e41f2024a2bfaacbf0568bd4c68
Gerrit-Change-Number: 16778
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Shant Hovsepian 
Gerrit-Reviewer: Tim Armstrong