[Impala-ASF-CR] Hive 3: fix test permanent udfs.py for Hive 3 support
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG@16 PS2, Line 16: This function also : exists in Hive 2, so while it isn't necessary, I didn't bother to make : it conditional on version > Maybe create a function like describe_fn__in_hive(self, db, fn)? It could a Done http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py@507 PS2, Line 507: implemened > typo: implemented Done http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py@507 PS2, Line 507: now > not ? 'now' is correct -- they used to be 'UDF' but now they are 'GenericUDF' -- To view, visit http://gerrit.cloudera.org:8080/13236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sudhanshu Arora Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 06 May 2019 21:25:26 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Hive 3: fix test permanent udfs.py for Hive 3 support
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sudhanshu Arora Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 06 May 2019 19:55:44 + Gerrit-HasComments: No
[Impala-ASF-CR] Hive 3: fix test permanent udfs.py for Hive 3 support
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py@507 PS2, Line 507: now not ? -- To view, visit http://gerrit.cloudera.org:8080/13236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sudhanshu Arora Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 06 May 2019 15:20:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Hive 3: fix test permanent udfs.py for Hive 3 support
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG@16 PS2, Line 16: This function also : exists in Hive 2, so while it isn't necessary, I didn't bother to make : it conditional on version Maybe create a function like describe_fn__in_hive(self, db, fn)? It could also branch on IMPALA_HIVE_MAJOR_VERSION and add "RELOAD FUNCTION" only if needed. http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py@507 PS2, Line 507: implemened typo: implemented -- To view, visit http://gerrit.cloudera.org:8080/13236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sudhanshu Arora Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Mon, 06 May 2019 14:11:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Hive 3: fix test permanent udfs.py for Hive 3 support
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3070/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sudhanshu Arora Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Yongzhi Chen Gerrit-Comment-Date: Fri, 03 May 2019 23:46:21 + Gerrit-HasComments: No
[Impala-ASF-CR] Hive 3: fix test permanent udfs.py for Hive 3 support
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13236 Change subject: Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Hive 3: fix test_permanent_udfs.py for Hive 3 support This fixes two issues in test_permanent_udfs.py: - two of Hive's built-ins were ported to the new GenericUDF interface which Impala can't execute. These UDFs are now excluded from the test when running with Hive 3. - Hive 3 now caches UDFs more aggressively, so we have to run 'RELOAD FUNCTION' in Hive after changing UDFs in Impala. This function also exists in Hive 2, so while it isn't necessary, I didn't bother to make it conditional on version. Change-Id: I7f50845c7d4769d8843cad87988498e165902169 --- M tests/common/impala_test_suite.py M tests/custom_cluster/test_permanent_udfs.py 2 files changed, 24 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13236/1 -- To view, visit http://gerrit.cloudera.org:8080/13236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon