[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16297 ) Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS .. IMPALA-10043: Keep more logs when using EE_TEST_SHARDS IMPALA-9887 introduced the EE_TEST_SHARDS setting, which splits the end-to-end test into shards and restarts Impala in between. In order to keep the logs from all the shards, the value for max_log_files needs to be increased so that none get aged out. This multiplies IMPALA_MAX_LOG_FILES by the number of shards using EE_TEST_SHARDS. Testing: - Ran a test with EE_TEST_SHARDS=6 and verified that the logs are preserved. Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88 Reviewed-on: http://gerrit.cloudera.org:8080/16297 Tested-by: Impala Public Jenkins Reviewed-by: Laszlo Gaal --- M bin/run-all-tests.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Laszlo Gaal: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88 Gerrit-Change-Number: 16297 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/16297 ) Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88 Gerrit-Change-Number: 16297 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Tue, 11 Aug 2020 16:44:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16297 ) Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88 Gerrit-Change-Number: 16297 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sat, 08 Aug 2020 00:34:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16297 ) Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6249/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/16297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88 Gerrit-Change-Number: 16297 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 07 Aug 2020 19:16:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16297 ) Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6804/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88 Gerrit-Change-Number: 16297 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Thu, 06 Aug 2020 01:55:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16297 Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS .. IMPALA-10043: Keep more logs when using EE_TEST_SHARDS IMPALA-9887 introduced the EE_TEST_SHARDS setting, which splits the end-to-end test into shards and restarts Impala in between. In order to keep the logs from all the shards, the value for max_log_files needs to be increased so that none get aged out. This multiplies IMPALA_MAX_LOG_FILES by the number of shards using EE_TEST_SHARDS. Testing: - Ran a test with EE_TEST_SHARDS=6 and verified that the logs are preserved. Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88 --- M bin/run-all-tests.sh 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/16297/1 -- To view, visit http://gerrit.cloudera.org:8080/16297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88 Gerrit-Change-Number: 16297 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
