[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16382 )

Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6387/


--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 02 Sep 2020 13:14:54 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16382 )

Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/7073/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 02 Sep 2020 09:18:53 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16382 )

Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 02 Sep 2020 09:10:12 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16382 )

Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6387/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Tamas 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 02 Sep 2020 09:10:13 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Gabor Kaszab (Code Review) 
Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16382 )

Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 02 Sep 2020 09:09:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Adam Tamas (Code Review) 
Adam Tamas has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/16382 )

Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..

IMPALA-10107:(1/3)Implement ds_hll_stringify function.

This function receives a string that is a serialized Apache DataSketches
HLL sketch and returns its stringified format.

A stringified format should look like and contains the following data:

select ds_hll_stringify(ds_hll_sketch(float_col)) from
functional_parquet.alltypestiny;
++
| ds_hll_stringify(ds_hll_sketch(float_col)) |
++
| ### HLL sketch summary:|
|   Log Config K   : 12  |
|   Hll Target : HLL_4   |
|   Current Mode   : LIST|
|   LB : 2   |
|   Estimate   : 2   |
|   UB : 2.0001  |
|   OutOfOrder flag: false   |
|   Coupon count   : 2   |
| ### End HLL sketch summary |
||
++

Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
---
M be/src/exprs/datasketches-functions-ir.cc
M be/src/exprs/datasketches-functions.h
M common/function-registry/impala_functions.py
M testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test
4 files changed, 59 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/16382/2
--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Adam Tamas (Code Review) 
Adam Tamas has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16382 )

Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16382/1/be/src/exprs/datasketches-functions.h
File be/src/exprs/datasketches-functions.h:

http://gerrit.cloudera.org:8080/#/c/16382/1/be/src/exprs/datasketches-functions.h@37
PS1, Line 37:
> nit: leave an empty line before starting the comment.
Done


http://gerrit.cloudera.org:8080/#/c/16382/1/be/src/exprs/datasketches-functions.h@39
PS1, Line 39:  then the query fai
> DataSketches HLL sketch
Done



--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 02 Sep 2020 08:56:24 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Gabor Kaszab (Code Review) 
Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16382 )

Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16382/1/be/src/exprs/datasketches-functions.h
File be/src/exprs/datasketches-functions.h:

http://gerrit.cloudera.org:8080/#/c/16382/1/be/src/exprs/datasketches-functions.h@37
PS1, Line 37:   /// 'serialized_sketch' is expected as a serialized Apache 
DataSketches HLL sketch. If
nit: leave an empty line before starting the comment.


http://gerrit.cloudera.org:8080/#/c/16382/1/be/src/exprs/datasketches-functions.h@39
PS1, Line 39: DataSketches sketch
DataSketches HLL sketch



--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 02 Sep 2020 08:44:51 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-08-28 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16382 )

Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/7033/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 28 Aug 2020 14:31:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-08-28 Thread Adam Tamas (Code Review) 
Adam Tamas has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16382


Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function.
..

IMPALA-10107:(1/3)Implement ds_hll_stringify function.

This function receives a string that is a serialized Apache DataSketches
HLL sketch and returns its stringified format.

A stringified format should look like and contains the following data:

select ds_hll_stringify(ds_hll_sketch(float_col)) from
functional_parquet.alltypestiny;
++
| ds_hll_stringify(ds_hll_sketch(float_col)) |
++
| ### HLL sketch summary:|
|   Log Config K   : 12  |
|   Hll Target : HLL_4   |
|   Current Mode   : LIST|
|   LB : 2   |
|   Estimate   : 2   |
|   UB : 2.0001  |
|   OutOfOrder flag: false   |
|   Coupon count   : 2   |
| ### End HLL sketch summary |
||
++

Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
---
M be/src/exprs/datasketches-functions-ir.cc
M be/src/exprs/datasketches-functions.h
M common/function-registry/impala_functions.py
M testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test
4 files changed, 58 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/16382/1
--
To view, visit http://gerrit.cloudera.org:8080/16382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0
Gerrit-Change-Number: 16382
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas