[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-25 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16689 )

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Wed, 25 Nov 2020 13:52:04 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-25 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16689 )

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..

IMPALA-10306: [DOCS] remove TZ offset texts from the list

added an item in the list that says that TZ offset will not be included
in the output of this function even if the offset is provided as input

Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Reviewed-on: http://gerrit.cloudera.org:8080/16689
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 43 insertions(+), 110 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 6
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-25 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16689 )

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6712/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Wed, 25 Nov 2020 08:22:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-25 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16689 )

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Wed, 25 Nov 2020 08:22:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-25 Thread Gabor Kaszab (Code Review) 
Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16689 )

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Wed, 25 Nov 2020 08:21:44 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-17 Thread Tamas Mate (Code Review) 
Tamas Mate has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16689 )

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..


Patch Set 4: Code-Review+1

Thank Shajini, LGTM!


--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Tue, 17 Nov 2020 08:20:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-16 Thread Shajini Thayasingh (Code Review) 
Hello Tamas Mate, Gabor Kaszab, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16689

to look at the new patch set (#4).

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..

IMPALA-10306: [DOCS] remove TZ offset texts from the list

added an item in the list that says that TZ offset will not be included
in the output of this function even if the offset is provided as input

Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 43 insertions(+), 110 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/16689/4
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-13 Thread Tamas Mate (Code Review) 
Tamas Mate has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16689 )

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..


Patch Set 2:

(1 comment)

Thanks Shajini, more note from my end.

http://gerrit.cloudera.org:8080/#/c/16689/2/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:

http://gerrit.cloudera.org:8080/#/c/16689/2/docs/topics/impala_datetime_functions.xml@1302
PS2, Line 1302: 
This can be deleted.



--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Fri, 13 Nov 2020 13:14:03 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-12 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16689 )

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..


Patch Set 2: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/607/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Thu, 12 Nov 2020 17:46:10 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-12 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16689 )

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/607/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Thu, 12 Nov 2020 17:37:46 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-12 Thread Shajini Thayasingh (Code Review) 
Hello Tamas Mate, Gabor Kaszab, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16689

to look at the new patch set (#2).

Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list
..

IMPALA-10306: [DOCS] remove TZ offset texts from the list

added an item in the list that says that TZ offset will not be included
in the output of this function even if the offset is provided as input

Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 45 insertions(+), 88 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/16689/2
--
To view, visit http://gerrit.cloudera.org:8080/16689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1
Gerrit-Change-Number: 16689
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate