[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 11 Dec 2020 19:51:27 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..

IMPALA-10384: Make partition names consistent between BE and FE

In the BE we build partition names with the trailing char '/'. In the FE
we build partition names without a trailing char. We should make this
consistent because this causes some annoying string adjustments in
the FE and can cause hidden bugs.

This patch creates partition names without the trailing '/' both in
the BE and the FE. This follows Hive's behavior that also prints
partition names without the trailing '/'.

Testing:
 * Ran exhaustive tests

Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Reviewed-on: http://gerrit.cloudera.org:8080/16850
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M be/src/exec/hdfs-table-sink.cc
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/catalog/HdfsPartitionSdCompareTest.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M 
testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M 
testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/create-table.test
M 
testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-caching.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/insert_null.test
M testdata/workloads/functional-query/queries/QueryTest/insert_overwrite.test
M testdata/workloads/functional-query/queries/QueryTest/insert_part_key.test
M testdata/workloads/functional-query/queries/QueryTest/insert_permutation.test
M testdata/workloads/functional-query/queries/QueryTest/load.test
M 
testdata/workloads/functional-query/queries/QueryTest/multiple-filesystems.test
M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test
M testdata/workloads/tpcds-insert/queries/partitioned-insert.test
22 files changed, 740 insertions(+), 747 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6768/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 11 Dec 2020 14:22:37 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 11 Dec 2020 14:22:36 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6765/


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 11 Dec 2020 13:25:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 11 Dec 2020 07:53:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6765/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 11 Dec 2020 07:53:14 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 3: Code-Review+2

Thanks for taking care of this!


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 10 Dec 2020 17:43:27 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6754/


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 10 Dec 2020 16:05:38 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/7828/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 10 Dec 2020 13:27:57 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16850

to look at the new patch set (#3).

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..

IMPALA-10384: Make partition names consistent between BE and FE

In the BE we build partition names with the trailing char '/'. In the FE
we build partition names without a trailing char. We should make this
consistent because this causes some annoying string adjustments in
the FE and can cause hidden bugs.

This patch creates partition names without the trailing '/' both in
the BE and the FE. This follows Hive's behavior that also prints
partition names without the trailing '/'.

Testing:
 * Ran exhaustive tests

Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
---
M be/src/exec/hdfs-table-sink.cc
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/catalog/HdfsPartitionSdCompareTest.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M 
testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M 
testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/create-table.test
M 
testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-caching.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/insert_null.test
M testdata/workloads/functional-query/queries/QueryTest/insert_overwrite.test
M testdata/workloads/functional-query/queries/QueryTest/insert_part_key.test
M testdata/workloads/functional-query/queries/QueryTest/insert_permutation.test
M testdata/workloads/functional-query/queries/QueryTest/load.test
M 
testdata/workloads/functional-query/queries/QueryTest/multiple-filesystems.test
M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test
M testdata/workloads/tpcds-insert/queries/partitioned-insert.test
22 files changed, 740 insertions(+), 747 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/16850/3
--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/7823/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 10 Dec 2020 10:47:03 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/7822/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 10 Dec 2020 10:42:35 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16850 )

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6754/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 10 Dec 2020 10:33:32 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16850

to look at the new patch set (#2).

Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..

IMPALA-10384: Make partition names consistent between BE and FE

In the BE we build partition names with the trailing char '/'. In the FE
we build partition names without a trailing char. We should make this
consistent because this causes some annoying string adjustments in
the FE and can cause hidden bugs.

This patch creates partition names without the trailing '/' both in
the BE and the FE. This follows Hive's behavior that also prints
partition names without the trailing '/'.

Testing:
 * Ran exhaustive tests

Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
---
M be/src/exec/hdfs-table-sink.cc
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/catalog/HdfsPartitionSdCompareTest.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M 
testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M 
testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/create-table.test
M 
testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-caching.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/insert_null.test
M testdata/workloads/functional-query/queries/QueryTest/insert_overwrite.test
M testdata/workloads/functional-query/queries/QueryTest/insert_part_key.test
M testdata/workloads/functional-query/queries/QueryTest/insert_permutation.test
M testdata/workloads/functional-query/queries/QueryTest/load.test
M 
testdata/workloads/functional-query/queries/QueryTest/multiple-filesystems.test
M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test
M testdata/workloads/tpcds-insert/queries/partitioned-insert.test
22 files changed, 740 insertions(+), 746 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/16850/2
--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] IMPALA-10384: Make partition names consistent between BE and FE

2020-12-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16850


Change subject: IMPALA-10384: Make partition names consistent between BE and FE
..

IMPALA-10384: Make partition names consistent between BE and FE

In the BE we build partition names with the trailing char '/'. In the FE
we build partition names without a trailing char. We should make this
consistent because this causes some annoying string adjustments in
the FE and can cause hidden bugs.

This patch creates partition names without the trailing '/' both in
the BE and the FE. This follows Hive's behavior that also prints
partition names without the trailing '/'.

Testing:
 * Ran exhaustive tests

Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
---
M be/src/exec/hdfs-table-sink.cc
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/catalog/HdfsPartitionSdCompareTest.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M 
testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M 
testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/create-table.test
M 
testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test
M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-caching.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/insert_null.test
M testdata/workloads/functional-query/queries/QueryTest/insert_overwrite.test
M testdata/workloads/functional-query/queries/QueryTest/insert_part_key.test
M testdata/workloads/functional-query/queries/QueryTest/insert_permutation.test
M testdata/workloads/functional-query/queries/QueryTest/load.test
M 
testdata/workloads/functional-query/queries/QueryTest/multiple-filesystems.test
M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test
M testdata/workloads/tpcds-insert/queries/partitioned-insert.test
22 files changed, 740 insertions(+), 744 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/16850/1
--
To view, visit http://gerrit.cloudera.org:8080/16850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e40111e2d1148aeb01ebc985bbb15db7d6a6012
Gerrit-Change-Number: 16850
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy