[Impala-ASF-CR] IMPALA-10398: Altering an Iceberg table might throw NullPointerException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16882 ) Change subject: IMPALA-10398: Altering an Iceberg table might throw NullPointerException .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e8b7c68898bd13c5288b466d5bf3d258392 Gerrit-Change-Number: 16882 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 16 Dec 2020 21:59:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10398: Altering an Iceberg table might throw NullPointerException
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16882 ) Change subject: IMPALA-10398: Altering an Iceberg table might throw NullPointerException .. IMPALA-10398: Altering an Iceberg table might throw NullPointerException IcebergSchemaConverter has a static thread local member which might not have a value in the current thread when nextId() is invoked. In that case the thread local integer's get() method returns a null and we get a NullPointerException when we want to convert it to a builtin int. This patch initializes the thread local variable with an anonymous subclass of ThreadLocal that overrides the 'initialValue()' method which returns 0 instead of null. Testing * tested manually by restarting the impala cluster and issuing ALTER TABLE .. ADD COLUMNS * looped test_alter_iceberg_tables for a while Change-Id: I4e8b7c68898bd13c5288b466d5bf3d258392 Reviewed-on: http://gerrit.cloudera.org:8080/16882 Reviewed-by: Gabor Kaszab Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Gabor Kaszab: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4e8b7c68898bd13c5288b466d5bf3d258392 Gerrit-Change-Number: 16882 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10398: Altering an Iceberg table might throw NullPointerException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16882 ) Change subject: IMPALA-10398: Altering an Iceberg table might throw NullPointerException .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6786/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e8b7c68898bd13c5288b466d5bf3d258392 Gerrit-Change-Number: 16882 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 16 Dec 2020 16:29:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10398: Altering an Iceberg table might throw NullPointerException
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16882 ) Change subject: IMPALA-10398: Altering an Iceberg table might throw NullPointerException .. Patch Set 1: Code-Review+2 Nice catch! -- To view, visit http://gerrit.cloudera.org:8080/16882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e8b7c68898bd13c5288b466d5bf3d258392 Gerrit-Change-Number: 16882 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 16 Dec 2020 16:27:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10398: Altering an Iceberg table might throw NullPointerException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16882 ) Change subject: IMPALA-10398: Altering an Iceberg table might throw NullPointerException .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7865/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e8b7c68898bd13c5288b466d5bf3d258392 Gerrit-Change-Number: 16882 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 16 Dec 2020 14:29:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10398: Altering an Iceberg table might throw NullPointerException
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16882 Change subject: IMPALA-10398: Altering an Iceberg table might throw NullPointerException .. IMPALA-10398: Altering an Iceberg table might throw NullPointerException IcebergSchemaConverter has a static thread local member which might not have a value in the current thread when nextId() is invoked. In that case the thread local integer's get() method returns a null and we get a NullPointerException when we want to convert it to a builtin int. This patch initializes the thread local variable with an anonymous subclass of ThreadLocal that overrides the 'initialValue()' method which returns 0 instead of null. Testing * tested manually by restarting the impala cluster and issuing ALTER TABLE .. ADD COLUMNS * looped test_alter_iceberg_tables for a while Change-Id: I4e8b7c68898bd13c5288b466d5bf3d258392 --- M fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/16882/1 -- To view, visit http://gerrit.cloudera.org:8080/16882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4e8b7c68898bd13c5288b466d5bf3d258392 Gerrit-Change-Number: 16882 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
