[Impala-ASF-CR] IMPALA-10559: Fix flakiness in TestScratchLimit.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17182 ) Change subject: IMPALA-10559: Fix flakiness in TestScratchLimit. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe Gerrit-Change-Number: 17182 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 14 Mar 2021 22:11:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10559: Fix flakiness in TestScratchLimit.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17182 ) Change subject: IMPALA-10559: Fix flakiness in TestScratchLimit. .. IMPALA-10559: Fix flakiness in TestScratchLimit. TestScratchLimit has been flaky in ubuntu-16.04-dockerised-tests environment since results spooling is enabled by default in IMPALA-9856. A combination of result spooling, sort query, and low buffer_pool_limit in TestScratchLimit::test_with_unlimited_scratch_limit seems to reveal a memory reservation bug in BufferedTutpleStream. This patch disables result spooling for tests under TestScratchLimit until the underlying bug is found. We will investigate the bug in a separate JIRA. Testing: - Disable result spooling in all tests of TestScratchLimit before IMPALA-9856 gets in. - Run and pass TestScratchLimit locally. Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe Reviewed-on: http://gerrit.cloudera.org:8080/17182 Reviewed-by: Quanlong Huang Tested-by: Impala Public Jenkins --- M tests/query_test/test_scratch_limit.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Quanlong Huang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/17182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe Gerrit-Change-Number: 17182 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-10559: Fix flakiness in TestScratchLimit.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17182 ) Change subject: IMPALA-10559: Fix flakiness in TestScratchLimit. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe Gerrit-Change-Number: 17182 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 14 Mar 2021 13:41:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10559: Fix flakiness in TestScratchLimit.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17182 ) Change subject: IMPALA-10559: Fix flakiness in TestScratchLimit. .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6968/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe Gerrit-Change-Number: 17182 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 14 Mar 2021 08:07:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10559: Fix flakiness in TestScratchLimit.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17182 ) Change subject: IMPALA-10559: Fix flakiness in TestScratchLimit. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe Gerrit-Change-Number: 17182 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 14 Mar 2021 08:06:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10559: Fix flakiness in TestScratchLimit.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17182 ) Change subject: IMPALA-10559: Fix flakiness in TestScratchLimit. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8360/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe Gerrit-Change-Number: 17182 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 14 Mar 2021 04:05:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10559: Fix flakiness in TestScratchLimit.
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17182 Change subject: IMPALA-10559: Fix flakiness in TestScratchLimit. .. IMPALA-10559: Fix flakiness in TestScratchLimit. TestScratchLimit has been flaky in ubuntu-16.04-dockerised-tests environment since results spooling is enabled by default in IMPALA-9856. A combination of result spooling, sort query, and low buffer_pool_limit in TestScratchLimit::test_with_unlimited_scratch_limit seems to reveal a memory reservation bug in BufferedTutpleStream. This patch disables result spooling for tests under TestScratchLimit until the underlying bug is found. We will investigate the bug in a separate JIRA. Testing: - Disable result spooling in all tests of TestScratchLimit before IMPALA-9856 gets in. - Run and pass TestScratchLimit locally. Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe --- M tests/query_test/test_scratch_limit.py 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/17182/1 -- To view, visit http://gerrit.cloudera.org:8080/17182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe Gerrit-Change-Number: 17182 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto
