[Impala-ASF-CR] IMPALA-11007: Replies to HTTP HEAD requests should contain no content.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18002 ) Change subject: IMPALA-11007: Replies to HTTP HEAD requests should contain no content. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc3bf72067dfa5bc24e29fe974e5762be507952 Gerrit-Change-Number: 18002 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 08 Nov 2021 23:59:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11007: Replies to HTTP HEAD requests should contain no content.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18002 ) Change subject: IMPALA-11007: Replies to HTTP HEAD requests should contain no content. .. IMPALA-11007: Replies to HTTP HEAD requests should contain no content. If a HEAD request to Impala's webserver, for example curl -I http://localhost:25000/metrics does send content in the response then this results in ugly messages being logged on the server side when the client side closes the connection after it has read the headers in the http response. Fix this by not sending (or generating) the content in reply to the HEAD request. TESTING: Ran all end-to-end tests. Added HEAD calls to various existing tests. Change-Id: I5cc3bf72067dfa5bc24e29fe974e5762be507952 Reviewed-on: http://gerrit.cloudera.org:8080/18002 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/util/webserver.cc M tests/webserver/test_web_pages.py 2 files changed, 20 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5cc3bf72067dfa5bc24e29fe974e5762be507952 Gerrit-Change-Number: 18002 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-11007: Replies to HTTP HEAD requests should contain no content.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18002 ) Change subject: IMPALA-11007: Replies to HTTP HEAD requests should contain no content. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7604/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/18002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc3bf72067dfa5bc24e29fe974e5762be507952 Gerrit-Change-Number: 18002 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 08 Nov 2021 17:36:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11007: Replies to HTTP HEAD requests should contain no content.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18002 ) Change subject: IMPALA-11007: Replies to HTTP HEAD requests should contain no content. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc3bf72067dfa5bc24e29fe974e5762be507952 Gerrit-Change-Number: 18002 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 08 Nov 2021 17:36:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11007: Replies to HTTP HEAD requests should contain no content.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18002 ) Change subject: IMPALA-11007: Replies to HTTP HEAD requests should contain no content. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc3bf72067dfa5bc24e29fe974e5762be507952 Gerrit-Change-Number: 18002 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 08 Nov 2021 16:11:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11007: Replies to HTTP HEAD requests should contain no content.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18002 ) Change subject: IMPALA-11007: Replies to HTTP HEAD requests should contain no content. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9727/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc3bf72067dfa5bc24e29fe974e5762be507952 Gerrit-Change-Number: 18002 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 06 Nov 2021 02:22:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11007: Replies to HTTP HEAD requests should contain no content.
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18002 Change subject: IMPALA-11007: Replies to HTTP HEAD requests should contain no content. .. IMPALA-11007: Replies to HTTP HEAD requests should contain no content. If a HEAD request to Impala's webserver, for example curl -I http://localhost:25000/metrics does send content in the response then this results in ugly messages being logged on the server side when the client side closes the connection after it has read the headers in the http response. Fix this by not sending (or generating) the content in reply to the HEAD request. TESTING: Ran all end-to-end tests. Added HEAD calls to various existing tests. Change-Id: I5cc3bf72067dfa5bc24e29fe974e5762be507952 --- M be/src/util/webserver.cc M tests/webserver/test_web_pages.py 2 files changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/18002/1 -- To view, visit http://gerrit.cloudera.org:8080/18002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5cc3bf72067dfa5bc24e29fe974e5762be507952 Gerrit-Change-Number: 18002 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Abhishek Rawat
