[Impala-ASF-CR] IMPALA-12034: Use more portable filesystem client instead of hdfs client.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19672 ) Change subject: IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. .. IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. Fix an Ozone test failure where we were using 'hdfs_client', which is set to None on non-HDFS systems. Instead use 'filesystem_client' which is a generic interface for doing filesystem operations that works across all the filesystems that Impala supports. TESTING: - Ran the test on Ozone. Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 Reviewed-on: http://gerrit.cloudera.org:8080/19672 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/query_test/test_iceberg.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 Gerrit-Change-Number: 19672 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-12034: Use more portable filesystem client instead of hdfs client.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19672 ) Change subject: IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/19672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 Gerrit-Change-Number: 19672 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Sat, 01 Apr 2023 04:50:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12034: Use more portable filesystem client instead of hdfs client.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19672 ) Change subject: IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 Gerrit-Change-Number: 19672 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 31 Mar 2023 23:34:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12034: Use more portable filesystem client instead of hdfs client.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19672 ) Change subject: IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9192/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/19672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 Gerrit-Change-Number: 19672 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 31 Mar 2023 23:34:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12034: Use more portable filesystem client instead of hdfs client.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19672 ) Change subject: IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 Gerrit-Change-Number: 19672 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 31 Mar 2023 23:34:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12034: Use more portable filesystem client instead of hdfs client.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19672 ) Change subject: IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/19672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 Gerrit-Change-Number: 19672 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 31 Mar 2023 22:36:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12034: Use more portable filesystem client instead of hdfs client.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19672 ) Change subject: IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12732/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 Gerrit-Change-Number: 19672 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 31 Mar 2023 22:17:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12034: Use more portable filesystem client instead of hdfs client.
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19672 Change subject: IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. .. IMPALA-12034: Use more portable filesystem_client instead of hdfs_client. Fix an Ozone test failure where we were using 'hdfs_client', which is set to None on non-HDFS systems. Instead use 'filesystem_client' which is a generic interface for doing filesystem operations that works across all the filesystems that Impala supports. TESTING: - Ran the test on Ozone. Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 --- M tests/query_test/test_iceberg.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/19672/1 -- To view, visit http://gerrit.cloudera.org:8080/19672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib6fe961cb659c3002321f26673293e6e25b902a4 Gerrit-Change-Number: 19672 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman