[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. IMPALA-12825: Install thrift into the impala-python virtualenv impala-python currently gets its Thrift from the toolchain by adding the appropriate Thrift toolchain directories to the PYTHONPATH. This is a problem when switching to Python 3, because the toolchain Thrift was built with Python 2 and this can produce complicated bugs. In general, it is also not a good idea to get Python dependencies from the toolchain. This switches to installing Thrift into the impala-python virtualenv, which lets the different Python versions have their own copy of compiled files. Testing: - Ran a core job Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Reviewed-on: http://gerrit.cloudera.org:8080/21046 Reviewed-by: Michael Smith Reviewed-by: Wenzhe Zhou Tested-by: Impala Public Jenkins --- M README-build.md M bin/impala-config.sh M bin/set-pythonpath.sh M infra/python/deps/requirements.txt 4 files changed, 8 insertions(+), 18 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Wenzhe Zhou: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 01 Mar 2024 05:46:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15371/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 01 Mar 2024 01:33:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 3: Code-Review+2 carry +1 from Micheal -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 01 Mar 2024 00:45:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10337/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 01 Mar 2024 00:33:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 01 Mar 2024 00:27:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21046/1/infra/python/deps/requirements.txt File infra/python/deps/requirements.txt: http://gerrit.cloudera.org:8080/#/c/21046/1/infra/python/deps/requirements.txt@67 PS1, Line 67: thrift==0.16.0 > Another place to potentially update Thrift version. Do we need to keep it i Good point, changed the comment in impala-config.sh to mention updating this file. -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 01 Mar 2024 00:01:50 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Hello Wenzhe Zhou, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21046 to look at the new patch set (#2). Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. IMPALA-12825: Install thrift into the impala-python virtualenv impala-python currently gets its Thrift from the toolchain by adding the appropriate Thrift toolchain directories to the PYTHONPATH. This is a problem when switching to Python 3, because the toolchain Thrift was built with Python 2 and this can produce complicated bugs. In general, it is also not a good idea to get Python dependencies from the toolchain. This switches to installing Thrift into the impala-python virtualenv, which lets the different Python versions have their own copy of compiled files. Testing: - Ran a core job Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 --- M README-build.md M bin/impala-config.sh M bin/set-pythonpath.sh M infra/python/deps/requirements.txt 4 files changed, 8 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/21046/2 -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21046/1/infra/python/deps/requirements.txt File infra/python/deps/requirements.txt: http://gerrit.cloudera.org:8080/#/c/21046/1/infra/python/deps/requirements.txt@67 PS1, Line 67: thrift==0.16.0 Another place to potentially update Thrift version. Do we need to keep it in-sync? If so we should mention it in impala-config.sh. -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 26 Feb 2024 17:45:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 22 Feb 2024 07:59:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 21 Feb 2024 23:31:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21046 ) Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15267/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 21 Feb 2024 19:20:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12825: Install thrift into the impala-python virtualenv
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21046 Change subject: IMPALA-12825: Install thrift into the impala-python virtualenv .. IMPALA-12825: Install thrift into the impala-python virtualenv impala-python currently gets its Thrift from the toolchain by adding the appropriate Thrift toolchain directories to the PYTHONPATH. This is a problem when switching to Python 3, because the toolchain Thrift was built with Python 2 and this can produce complicated bugs. In general, it is also not a good idea to get Python dependencies from the toolchain. This switches to installing Thrift into the impala-python virtualenv, which lets the different Python versions have their own copy of compiled files. Testing: - Ran a core job Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 --- M README-build.md M bin/set-pythonpath.sh M infra/python/deps/requirements.txt 3 files changed, 2 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/21046/1 -- To view, visit http://gerrit.cloudera.org:8080/21046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib36e8a1ce8d446b69b08e81ea458f95c158e28f5 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins
