[Impala-ASF-CR] IMPALA-12930: Fix TestExtDataSources.test jdbc data source failure
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21181 ) Change subject: IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure .. IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure The patch of IMPALA-12802 added some negative test cases for altering external JDBC table. These test cases verify the error messages. One of test cases failed on some test environments due to different error message returned from Postgres server. This patch fixes the unit-test failure by checking if the error message is matching with one of two possible error messages. Testing: - Ran the unit-test on Jenkins with centos and ubuntu and verified the unit-test passed for different error messages. Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Reviewed-on: http://gerrit.cloudera.org:8080/21181 Reviewed-by: Wenzhe Zhou Tested-by: Impala Public Jenkins --- M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Wenzhe Zhou: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Gerrit-Change-Number: 21181 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-12930: Fix TestExtDataSources.test jdbc data source failure
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21181 ) Change subject: IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Gerrit-Change-Number: 21181 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 22 Mar 2024 01:11:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12930: Fix TestExtDataSources.test jdbc data source failure
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21181 ) Change subject: IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure .. Patch Set 3: Code-Review+2 Fixed typo in commit message, and Carry +2 from Abhishek -- To view, visit http://gerrit.cloudera.org:8080/21181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Gerrit-Change-Number: 21181 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 21 Mar 2024 20:17:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12930: Fix TestExtDataSources.test jdbc data source failure
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21181 ) Change subject: IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15619/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Gerrit-Change-Number: 21181 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 21 Mar 2024 20:17:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12930: Fix TestExtDataSources.test jdbc data source failure
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21181 ) Change subject: IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10406/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Gerrit-Change-Number: 21181 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 21 Mar 2024 20:16:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12930: Fix TestExtDataSources.test jdbc data source failure
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21181 ) Change subject: IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15618/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Gerrit-Change-Number: 21181 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 21 Mar 2024 20:05:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12930: Fix TestExtDataSources.test jdbc data source failure
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21181 ) Change subject: IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure .. IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure The patch of IMPALA-12802 added some negative test cases for altering external JDBC table. These test cases verify the error messages. One of test cases failed on some test environments due to different error message returned from Postgres server. This patch fixes the unit-test failure by checking if the error message is matching with one of two possible error messages. Testing: - Ran the unit-test on Jenkins with centos and ubuntu and verified the unit-test passed for different error messages. Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 --- M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/21181/2 -- To view, visit http://gerrit.cloudera.org:8080/21181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Gerrit-Change-Number: 21181 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-12930: Fix TestExtDataSources.test jdbc data source failure
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21181 ) Change subject: IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/21181/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21181/1//COMMIT_MSG@14 PS1, Line 14: This patch fixs the unit-test failure by checking if the error message typo: fixs -> fixes http://gerrit.cloudera.org:8080/#/c/21181/1//COMMIT_MSG@18 PS1, Line 18: - Ran the unit-test on Jenkis with centos and ubuntu and verified the typo: Jenkis -> Jenkins -- To view, visit http://gerrit.cloudera.org:8080/21181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Gerrit-Change-Number: 21181 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 21 Mar 2024 19:49:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12930: Fix TestExtDataSources.test jdbc data source failure
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21181 Change subject: IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure .. IMPALA-12930: Fix TestExtDataSources.test_jdbc_data_source failure The patch of IMPALA-12802 added some negative test cases for altering external JDBC table. These test cases verify the error messages. One of test cases failed on some test environments due to different error message returned from Postgres server. This patch fixs the unit-test failure by checking if the error message is matching with one of two possible error messages. Testing: - Ran the unit-test on Jenkis with centos and ubuntu and verified the unit-test passed for different error messages. Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 --- M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/21181/1 -- To view, visit http://gerrit.cloudera.org:8080/21181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I84566f67751538d72a4d17da21e7ea907e1dcdd2 Gerrit-Change-Number: 21181 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou
