[Impala-ASF-CR] IMPALA-12938: add-opens for platform.cgroupv1

2024-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21334 )

Change subject: IMPALA-12938: add-opens for platform.cgroupv1
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/21334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
Gerrit-Change-Number: 21334
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Fri, 19 Apr 2024 22:39:22 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12938: add-opens for platform.cgroupv1

2024-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/21334 )

Change subject: IMPALA-12938: add-opens for platform.cgroupv1
..

IMPALA-12938: add-opens for platform.cgroupv1

Adds '--add-opens=jdk.internal.platform.cgroupv1' for Java 11 with
ehcache, covering Impala daemons and frontend tests. Fixes
InaccessibleObjectException detected by test_banned_log_messages.py.

Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
Reviewed-on: http://gerrit.cloudera.org:8080/21334
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M be/src/common/init.cc
M bin/run-all-tests.sh
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/21334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
Gerrit-Change-Number: 21334
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-12938: add-opens for platform.cgroupv1

2024-04-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21334 )

Change subject: IMPALA-12938: add-opens for platform.cgroupv1
..


Patch Set 1:

Passed a manual Java 11 run for me.


--
To view, visit http://gerrit.cloudera.org:8080/21334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
Gerrit-Change-Number: 21334
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Fri, 19 Apr 2024 17:39:53 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12938: add-opens for platform.cgroupv1

2024-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21334 )

Change subject: IMPALA-12938: add-opens for platform.cgroupv1
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/21334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
Gerrit-Change-Number: 21334
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Fri, 19 Apr 2024 17:39:47 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12938: add-opens for platform.cgroupv1

2024-04-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21334 )

Change subject: IMPALA-12938: add-opens for platform.cgroupv1
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10561/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/21334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
Gerrit-Change-Number: 21334
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Fri, 19 Apr 2024 17:39:48 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12938: add-opens for platform.cgroupv1

2024-04-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21334 )

Change subject: IMPALA-12938: add-opens for platform.cgroupv1
..


Patch Set 1: Code-Review+2

Thanks for fixing this


--
To view, visit http://gerrit.cloudera.org:8080/21334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
Gerrit-Change-Number: 21334
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Fri, 19 Apr 2024 10:23:54 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12938: add-opens for platform.cgroupv1

2024-04-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21334 )

Change subject: IMPALA-12938: add-opens for platform.cgroupv1
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/15951/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/21334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
Gerrit-Change-Number: 21334
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 18 Apr 2024 21:25:03 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-12938: add-opens for platform.cgroupv1

2024-04-18 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21334


Change subject: IMPALA-12938: add-opens for platform.cgroupv1
..

IMPALA-12938: add-opens for platform.cgroupv1

Adds '--add-opens=jdk.internal.platform.cgroupv1' for Java 11 with
ehcache, covering Impala daemons and frontend tests. Fixes
InaccessibleObjectException detected by test_banned_log_messages.py.

Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
---
M be/src/common/init.cc
M bin/run-all-tests.sh
2 files changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/21334/1
--
To view, visit http://gerrit.cloudera.org:8080/21334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I312ae987c17c6f06e1ffe15e943b1865feef6b82
Gerrit-Change-Number: 21334
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith