[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21317 )

Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/21317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Gerrit-Change-Number: 21317
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 17 Apr 2024 23:39:23 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/21317 )

Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build
..

IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build

TestIcebergV2Table::test_metadata_tables failed in Ubuntu 20 build in a
release candidate because the file sizes in some queries didn't match
the expected ones. As Impala writes its version into the Parquet files
it writes, the file sizes can change with the release (especially as
SNAPSHOT or RELEASE is part of the full version, and their lengths
differ).

This change updates the failing tests to take regexes for the file sizes
instead of concrete values.

Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Reviewed-on: http://gerrit.cloudera.org:8080/21317
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M 
testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/21317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Gerrit-Change-Number: 21317
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21317 )

Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10552/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/21317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Gerrit-Change-Number: 21317
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 17 Apr 2024 18:32:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21317 )

Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/21317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Gerrit-Change-Number: 21317
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 17 Apr 2024 18:32:12 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21317 )

Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build
..


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10550/


--
To view, visit http://gerrit.cloudera.org:8080/21317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Gerrit-Change-Number: 21317
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 17 Apr 2024 18:17:22 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21317 )

Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build
..


Patch Set 1: Code-Review+2

Thanks for fixing this! I verified the patch on a RELEASE version.


--
To view, visit http://gerrit.cloudera.org:8080/21317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Gerrit-Change-Number: 21317
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 17 Apr 2024 15:05:26 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21317 )

Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10550/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/21317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Gerrit-Change-Number: 21317
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 17 Apr 2024 13:13:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21317 )

Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/15924/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/21317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Gerrit-Change-Number: 21317
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 17 Apr 2024 11:32:36 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21317


Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build
..

IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build

TestIcebergV2Table::test_metadata_tables failed in Ubuntu 20 build in a
release candidate because the file sizes in some queries didn't match
the expected ones. As Impala writes its version into the Parquet files
it writes, the file sizes can change with the release (especially as
SNAPSHOT or RELEASE is part of the full version, and their lengths
differ).

This change updates the failing tests to take regexes for the file sizes
instead of concrete values.

Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
---
M 
testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/21317/1
--
To view, visit http://gerrit.cloudera.org:8080/21317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad8fd0d9920034e7dbe6c605bed7579fbe3b5b1f
Gerrit-Change-Number: 21317
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker