[Impala-ASF-CR] IMPALA-13016: Fix ambiguous row regex that check for no-existence
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21333 ) Change subject: IMPALA-13016: Fix ambiguous row_regex that check for no-existence .. IMPALA-13016: Fix ambiguous row_regex that check for no-existence There are few row_regex patterns used in EE test files that are ambiguous on whether a pattern does not exist in all parts of the results/runtime profile or at least one row does not have that pattern. These were caught by grepping the following pattern: $ git grep -n "row_regex: (?\!" This patch replaces them with either with !row_regex or VERIFY_IS_NOT_IN comment. Testing: - Run and pass modified tests. Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Reviewed-on: http://gerrit.cloudera.org:8080/21333 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M testdata/workloads/functional-query/queries/QueryTest/acid-clear-statsaccurate.test M testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test M testdata/workloads/functional-query/queries/QueryTest/clear-statsaccurate.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-directed-mode.test 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Gerrit-Change-Number: 21333 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-13016: Fix ambiguous row regex that check for no-existence
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21333 ) Change subject: IMPALA-13016: Fix ambiguous row_regex that check for no-existence .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Gerrit-Change-Number: 21333 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 19 Apr 2024 21:00:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13016: Fix ambiguous row regex that check for no-existence
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21333 ) Change subject: IMPALA-13016: Fix ambiguous row_regex that check for no-existence .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10560/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Gerrit-Change-Number: 21333 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 19 Apr 2024 15:59:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13016: Fix ambiguous row regex that check for no-existence
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21333 ) Change subject: IMPALA-13016: Fix ambiguous row_regex that check for no-existence .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Gerrit-Change-Number: 21333 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 19 Apr 2024 15:58:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13016: Fix ambiguous row regex that check for no-existence
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21333 ) Change subject: IMPALA-13016: Fix ambiguous row_regex that check for no-existence .. Patch Set 2: Code-Review+2 Thanks for fixing these tests! LGTM! -- To view, visit http://gerrit.cloudera.org:8080/21333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Gerrit-Change-Number: 21333 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 19 Apr 2024 10:16:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13016: Fix ambiguous row regex that check for no-existence
Hello Gabor Kaszab, Zoltan Borok-Nagy, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21333 to look at the new patch set (#2). Change subject: IMPALA-13016: Fix ambiguous row_regex that check for no-existence .. IMPALA-13016: Fix ambiguous row_regex that check for no-existence There are few row_regex patterns used in EE test files that are ambiguous on whether a pattern does not exist in all parts of the results/runtime profile or at least one row does not have that pattern. These were caught by grepping the following pattern: $ git grep -n "row_regex: (?\!" This patch replaces them with either with !row_regex or VERIFY_IS_NOT_IN comment. Testing: - Run and pass modified tests. Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da --- M testdata/workloads/functional-query/queries/QueryTest/acid-clear-statsaccurate.test M testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test M testdata/workloads/functional-query/queries/QueryTest/clear-statsaccurate.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-directed-mode.test 4 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/21333/2 -- To view, visit http://gerrit.cloudera.org:8080/21333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Gerrit-Change-Number: 21333 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-13016: Fix ambiguous row regex that check for no-existence
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21333 ) Change subject: IMPALA-13016: Fix ambiguous row_regex that check for no-existence .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Gerrit-Change-Number: 21333 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 19 Apr 2024 00:23:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13016: Fix ambiguous row regex that check for no-existence
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21333 ) Change subject: IMPALA-13016: Fix ambiguous row_regex that check for no-existence .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15950/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Gerrit-Change-Number: 21333 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 18 Apr 2024 18:29:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13016: Fix ambiguous row regex that check for no-existence
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21333 Change subject: IMPALA-13016: Fix ambiguous row_regex that check for no-existence .. IMPALA-13016: Fix ambiguous row_regex that check for no-existence There are few row_regex pattern used in EE test files that is ambiguous on whether a parttern not exist in all parts of results/runtime filter or at least one row does not have that pattern. These were catched by grepping following pattern: $ git grep -n "row_regex: (?\!" This patch replace them with either with !row_regex or VERIFY_IS_NOT_IN comment. Testing: - Run and pass modified tests. Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da --- M testdata/workloads/functional-query/queries/QueryTest/acid-clear-statsaccurate.test M testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test M testdata/workloads/functional-query/queries/QueryTest/clear-statsaccurate.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-directed-mode.test 4 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/21333/1 -- To view, visit http://gerrit.cloudera.org:8080/21333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Gerrit-Change-Number: 21333 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto
