[Impala-ASF-CR] IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21450 ) Change subject: IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once .. IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once On importing multiple query profiles, insertion of the last query in the queue fails as no delay is provided for the insertion. This has been fixed by providing a delay after inserting the final query. On clearing all the imported queries, in some instances page reloads before clearing the IndexedDB object store. This has been fixed by triggering the page reload after clearing the object store succeeds. Change-Id: I42470fecd0cff6e193f080102575e51d86a2d562 Reviewed-on: http://gerrit.cloudera.org:8080/21450 Reviewed-by: Wenzhe Zhou Reviewed-by: Riza Suminto Tested-by: Impala Public Jenkins --- M www/queries.tmpl 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, but someone else must approve Riza Suminto: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I42470fecd0cff6e193f080102575e51d86a2d562 Gerrit-Change-Number: 21450 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21450 ) Change subject: IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42470fecd0cff6e193f080102575e51d86a2d562 Gerrit-Change-Number: 21450 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 24 May 2024 05:23:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21450 ) Change subject: IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10668/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42470fecd0cff6e193f080102575e51d86a2d562 Gerrit-Change-Number: 21450 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Fri, 24 May 2024 00:24:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21450 ) Change subject: IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once .. Patch Set 1: Code-Review+2 Looks OK in my machine as well. Tested with Chrome, Firefox, and Safari. -- To view, visit http://gerrit.cloudera.org:8080/21450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42470fecd0cff6e193f080102575e51d86a2d562 Gerrit-Change-Number: 21450 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kurt Deschler Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 23 May 2024 20:52:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21450 ) Change subject: IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once .. Patch Set 1: Code-Review+1 Ran on my local machine. It's working as expected. -- To view, visit http://gerrit.cloudera.org:8080/21450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42470fecd0cff6e193f080102575e51d86a2d562 Gerrit-Change-Number: 21450 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 22 May 2024 17:38:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21450 ) Change subject: IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16204/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42470fecd0cff6e193f080102575e51d86a2d562 Gerrit-Change-Number: 21450 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 22 May 2024 13:50:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once
Surya Hebbar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21450 Change subject: IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once .. IMPALA-13105: Fix multiple imported query profiles fail to import/clear at once On importing multiple query profiles, insertion of the last query in the queue fails as no delay is provided for the insertion. This has been fixed by providing a delay after inserting the final query. On clearing all the imported queries, in some instances page reloads before clearing the IndexedDB object store. This has been fixed by triggering the page reload after clearing the object store succeeds. Change-Id: I42470fecd0cff6e193f080102575e51d86a2d562 --- M www/queries.tmpl 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/21450/1 -- To view, visit http://gerrit.cloudera.org:8080/21450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I42470fecd0cff6e193f080102575e51d86a2d562 Gerrit-Change-Number: 21450 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar
