[Impala-ASF-CR] IMPALA-3926: part 1: bump toolchain for rpath fixes
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14274 ) Change subject: IMPALA-3926: part 1: bump toolchain for rpath fixes .. IMPALA-3926: part 1: bump toolchain for rpath fixes This bumps the toolchain to a version that sets up relative rpaths correctly, removing the need to set LD_LIBRARY_PATH when calling binaries or using shared objects from the toolchain. rpaths embedded in the binaries and shared objects take precedence over LD_LIBRARY_PATH, so the new binaries will link against the shared libraries from the toolchain, as expected. This does not attempt to clean up LD_LIBRARY_PATH yet - that would not work for developers who have older versions of the binaries on their system. We will do that later, but give devs a window to switch over to the new toolchain. Change-Id: I2abe513ebf4f459aa3e0c65c77ce7be8b8ca1221 Reviewed-on: http://gerrit.cloudera.org:8080/14274 Tested-by: Impala Public Jenkins Reviewed-by: Joe McDonnell --- M bin/impala-config.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2abe513ebf4f459aa3e0c65c77ce7be8b8ca1221 Gerrit-Change-Number: 14274 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-3926: part 1: bump toolchain for rpath fixes
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14274 ) Change subject: IMPALA-3926: part 1: bump toolchain for rpath fixes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2abe513ebf4f459aa3e0c65c77ce7be8b8ca1221 Gerrit-Change-Number: 14274 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 20 Sep 2019 21:11:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3926: part 1: bump toolchain for rpath fixes
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14274 ) Change subject: IMPALA-3926: part 1: bump toolchain for rpath fixes .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2abe513ebf4f459aa3e0c65c77ce7be8b8ca1221 Gerrit-Change-Number: 14274 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 20 Sep 2019 20:49:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3926: part 1: bump toolchain for rpath fixes
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14274 ) Change subject: IMPALA-3926: part 1: bump toolchain for rpath fixes .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4980/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2abe513ebf4f459aa3e0c65c77ce7be8b8ca1221 Gerrit-Change-Number: 14274 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 20 Sep 2019 16:38:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3926: part 1: bump toolchain for rpath fixes
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14274 ) Change subject: IMPALA-3926: part 1: bump toolchain for rpath fixes .. IMPALA-3926: part 1: bump toolchain for rpath fixes This bumps the toolchain to a version that sets up relative rpaths correctly, removing the need to set LD_LIBRARY_PATH when calling binaries or using shared objects from the toolchain. rpaths embedded in the binaries and shared objects take precedence over LD_LIBRARY_PATH, so the new binaries will link against the shared libraries from the toolchain, as expected. This does not attempt to clean up LD_LIBRARY_PATH yet - that would not work for developers who have older versions of the binaries on their system. We will do that later, but give devs a window to switch over to the new toolchain. Change-Id: I2abe513ebf4f459aa3e0c65c77ce7be8b8ca1221 --- M bin/impala-config.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/14274/2 -- To view, visit http://gerrit.cloudera.org:8080/14274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2abe513ebf4f459aa3e0c65c77ce7be8b8ca1221 Gerrit-Change-Number: 14274 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong
