[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8986 )

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 11 Jan 2018 21:49:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8986 )

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..

IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Reviewed-on: http://gerrit.cloudera.org:8080/8986
Reviewed-by: Thomas Tauber-Marshall 
Tested-by: Impala Public Jenkins
---
M docs/shared/impala_common.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_max_num_runtime_filters.xml
M docs/topics/impala_runtime_bloom_filter_size.xml
M docs/topics/impala_runtime_filter_max_size.xml
M docs/topics/impala_runtime_filter_min_size.xml
M docs/topics/impala_runtime_filtering.xml
8 files changed, 71 insertions(+), 6 deletions(-)

Approvals:
  Thomas Tauber-Marshall: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8986 )

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/185/


--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 11 Jan 2018 21:39:38 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[Thomas Tauber-Marshall (Code Review)]

Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8986 )

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 11 Jan 2018 20:59:54 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[John Russell (Code Review)]

John Russell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8986 )

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8986/2/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:

http://gerrit.cloudera.org:8080/#/c/8986/2/docs/topics/impala_runtime_filtering.xml@181
PS2, Line 181: ture representing a minimum and ma
> This is the only part I see that doesn't make sense for min-max filters, as
Done


http://gerrit.cloudera.org:8080/#/c/8986/2/docs/topics/impala_runtime_filtering.xml@203
PS2, Line 203: gher, the default for runtime filtering is the 
GLOBAL setting.
 :   
> I find this sentence confusing, as Kudu isn't identifying the matching rows
Done



--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 11 Jan 2018 20:16:51 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[John Russell (Code Review)]

Hello Thomas Tauber-Marshall, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8986

to look at the new patch set (#3).

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..

IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
---
M docs/shared/impala_common.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_max_num_runtime_filters.xml
M docs/topics/impala_runtime_bloom_filter_size.xml
M docs/topics/impala_runtime_filter_max_size.xml
M docs/topics/impala_runtime_filter_min_size.xml
M docs/topics/impala_runtime_filtering.xml
8 files changed, 71 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/8986/3
--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[Thomas Tauber-Marshall (Code Review)]

Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8986 )

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:

http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml@173
PS1, Line 173:
 : For HD
> Done. Because this paragraph is followed by info that's only relevant for B
Actually, the partitioned/broadcast and local/global discussion applies to 
min-max filters as well.

I should also add that the long term plan is to have all filter types supported 
by all scan types, so no need to separate out min-max as being a really 
specifically Kudu thing (though of course it only applies to Kudu at the 
moment).


http://gerrit.cloudera.org:8080/#/c/8986/2/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:

http://gerrit.cloudera.org:8080/#/c/8986/2/docs/topics/impala_runtime_filtering.xml@181
PS2, Line 181: a complete list of relevant values
This is the only part I see that doesn't make sense for min-max filters, as 
they're not a 'list of values', but then a bloom filter isn't a 'list of 
values' either.

Maybe rephrase it something like "A broadcast filter reflects the complete set 
of relevant values and can be immediately evaluated..." and "A partitioned 
filter reflects only the values processed by one host..." or perhaps "contains" 
instead of reflects


http://gerrit.cloudera.org:8080/#/c/8986/2/docs/topics/impala_runtime_filtering.xml@203
PS2, Line 203: These filters are used by Kudu to scan a range of values
 : for join columns when identifying matching rows within a 
join query.
I find this sentence confusing, as Kudu isn't identifying the matching rows 
(Kudu doesn't even know we're doing a join, its just scanning values for us)

Maybe say something like "These filters are passed to Kudu to reduce the number 
of rows returnrf to Impala when scanning the probe side of the join"



--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 11 Jan 2018 19:12:47 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[John Russell (Code Review)]

John Russell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8986 )

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:

http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml@173
PS1, Line 173: . (The probability-based aspects means that the
 : filter
> Maybe note here that bloom filters are only for HDFS target scans, and that
Done. Because this paragraph is followed by info that's only relevant for Bloom 
filters, I stated up front that the Bloom filters only apply to HDFS-based 
tables, then I added info about Kudu tables and min-max filters after the stuff 
about broadcast and partitioned filters.


http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml@335
PS1, Line 335:
> Note here: setting EXPLAIN_LEVEL=2 will display the type of filter in the f
Done



--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 10 Jan 2018 20:09:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[John Russell (Code Review)]

Hello Thomas Tauber-Marshall, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8986

to look at the new patch set (#2).

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..

IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
---
M docs/shared/impala_common.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_max_num_runtime_filters.xml
M docs/topics/impala_runtime_bloom_filter_size.xml
M docs/topics/impala_runtime_filter_max_size.xml
M docs/topics/impala_runtime_filter_min_size.xml
M docs/topics/impala_runtime_filtering.xml
8 files changed, 69 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/8986/2
--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8986 )

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 10 Jan 2018 02:00:27 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[Thomas Tauber-Marshall (Code Review)]

Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8986 )

Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:

http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml@173
PS1, Line 173: . (The probability-based aspects means that the
 : filter
Maybe note here that bloom filters are only for HDFS target scans, and that we 
do min-max for Kudu scans.

Of course, either type might include some non-matching values.


http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml@335
PS1, Line 335:
Note here: setting EXPLAIN_LEVEL=2 will display the type of filter in the 
format:
filter_id[type] -> table
filter_id[type] <- table
where type is either bloom or min_max



--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 09 Jan 2018 23:44:25 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

[John Russell (Code Review)]

John Russell has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8986


Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
..

IMPALA-4252: [DOCS] Document min/max filters for Kudu tables

Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
---
M docs/shared/impala_common.xml
M docs/topics/impala_disable_row_runtime_filtering.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_max_num_runtime_filters.xml
M docs/topics/impala_runtime_bloom_filter_size.xml
M docs/topics/impala_runtime_filter_max_size.xml
M docs/topics/impala_runtime_filter_min_size.xml
M docs/topics/impala_runtime_filtering.xml
8 files changed, 55 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/8986/1
--
To view, visit http://gerrit.cloudera.org:8080/8986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2
Gerrit-Change-Number: 8986
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell