[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. IMPALA-5202: Disallow PREPARE:WAIT debug action In order to simplify FIS startup, we don't allow cancellation until all FIS have finished Prepare(), so we shouldn't allow PREPARE:WAIT since there will be no way to cancel out of the loop. Make this explicit. Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Reviewed-on: http://gerrit.cloudera.org:8080/10776 Reviewed-by: Dan Hecht Tested-by: Impala Public Jenkins --- M be/src/exec/exec-node.cc M be/src/runtime/debug-options.cc M tests/failure/test_failpoints.py 3 files changed, 15 insertions(+), 6 deletions(-) Approvals: Dan Hecht: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Gerrit-Change-Number: 10776 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Gerrit-Change-Number: 10776 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 21 Jun 2018 07:18:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. Patch Set 2: Code-Review+2 Rebased onto master -- To view, visit http://gerrit.cloudera.org:8080/10776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Gerrit-Change-Number: 10776 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 21 Jun 2018 04:03:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2720/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Gerrit-Change-Number: 10776 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 21 Jun 2018 04:03:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Gerrit-Change-Number: 10776 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 21 Jun 2018 02:20:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2719/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Gerrit-Change-Number: 10776 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 20 Jun 2018 22:53:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Gerrit-Change-Number: 10776 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 20 Jun 2018 22:35:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Gerrit-Change-Number: 10776 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 20 Jun 2018 21:56:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10776 Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. IMPALA-5202: Disallow PREPARE:WAIT debug action In order to simplify FIS startup, we don't allow cancellation until all FIS have finished Prepare(), so we shouldn't allow PREPARE:WAIT since there will be no way to cancel out of the loop. Make this explicit. Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d --- M be/src/exec/exec-node.cc M be/src/runtime/debug-options.cc M tests/failure/test_failpoints.py 3 files changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/10776/1 -- To view, visit http://gerrit.cloudera.org:8080/10776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1caa4f8e6ce7f32a8a3722648e08e24f34dba35d Gerrit-Change-Number: 10776 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht
