[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:19:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..

IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Cherry-picks: not for 2.x.

Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Reviewed-on: http://gerrit.cloudera.org:8080/9996
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins 
---
M docs/topics/impala_describe.xml
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/234/


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:01:26 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:00:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Rodoni (Code Review)]

Hello Alex Behm, Impala Public Jenkins, Adam Holley,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9996

to look at the new patch set (#5).

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..

IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Cherry-picks: not for 2.x.

Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
---
M docs/topics/impala_describe.xml
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/9996/5
--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9996/4/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:

http://gerrit.cloudera.org:8080/#/c/9996/4/docs/topics/impala_describe.xml@146
PS4, Line 146:   the LOCATION field. The 
LOCATION data
Did you make the changes suggested in my last comment? This last part about 
LOCATION is not accurate.



--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:48:06 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Rodoni (Code Review)]

Hello Alex Behm, Impala Public Jenkins, Adam Holley,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9996

to look at the new patch set (#4).

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..

IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Cherry-picks: not for 2.x.

Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
---
M docs/topics/impala_describe.xml
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/9996/4
--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9996/3/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:

http://gerrit.cloudera.org:8080/#/c/9996/3/docs/topics/impala_describe.xml@146
PS3, Line 146:   the LOCATION field. The 
LOCATION data
> The LOCATION data is shown if you have any privilege on the table, the cont
Done



--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:30:34 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9996/3/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:

http://gerrit.cloudera.org:8080/#/c/9996/3/docs/topics/impala_describe.xml@146
PS3, Line 146:   the LOCATION field. The 
LOCATION data
The LOCATION data is shown if you have any privilege on the table, the 
containing database or the server.



--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 03:47:25 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Adam Holley (Code Review)]

Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 3: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 03:45:50 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Rodoni (Code Review)]

Hello Alex Behm, Impala Public Jenkins, Adam Holley,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9996

to look at the new patch set (#3).

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..

IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
---
M docs/topics/impala_describe.xml
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/9996/3
--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9996/1/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:

http://gerrit.cloudera.org:8080/#/c/9996/1/docs/topics/impala_describe.xml@137
PS1, Line 137:   in the table, DESCRIBE returns the data 
from the columns
> If you only have the SELECT privilege on a subset of the table columns and
Done


http://gerrit.cloudera.org:8080/#/c/9996/1/docs/topics/impala_describe.xml@142
PS1, Line 142:   If you have the SELECT privilege on a 
subset of columns
> Same suggestion as above
Done



--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 03:33:00 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Rodoni (Code Review)]

Hello Alex Behm, Impala Public Jenkins, Adam Holley,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9996

to look at the new patch set (#2).

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..

IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
---
M docs/topics/impala_describe.xml
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/9996/2
--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Adam Holley (Code Review)]

Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 1:

Should we add a note in the document that the "LOCATION" data for the extended 
describe will only be visible if the user has table level privileges?  It is 
not visible if they have column level privileges.


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 03:24:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9996/1/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:

http://gerrit.cloudera.org:8080/#/c/9996/1/docs/topics/impala_describe.xml@137
PS1, Line 137:   in the table, DESCRIBE returns the data 
from the columns
If you only have the SELECT privilege on a subset of the table columns and no 
other relevant table/database/server-level privileges, then ...


http://gerrit.cloudera.org:8080/#/c/9996/1/docs/topics/impala_describe.xml@142
PS1, Line 142:   If you have the SELECT privilege on a 
subset of columns
Same suggestion as above



--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 03:06:27 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 1:

I need to add this for the 2.12 / 3.0 release. Could you please 
review/comment/approve?


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 02:42:46 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9996


Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..

IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
---
M docs/topics/impala_describe.xml
1 file changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/9996/1
--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni