[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9915 )

Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..

IMPALA-6667: [DOCS] max_cached_file_handles is enabled by default

Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Reviewed-on: http://gerrit.cloudera.org:8080/9915
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_scalability.xml
1 file changed, 16 insertions(+), 16 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: John Russell 


[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9915 )

Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 21:26:24 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9915 )

Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/224/


--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 21:16:50 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9915 )

Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 21:16:11 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-04 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9915 )

Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..


Patch Set 2:

(1 comment)

Sorry I changed the wrong word. Should be fixed now.

http://gerrit.cloudera.org:8080/#/c/9915/2/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/9915/2/docs/topics/impala_scalability.xml@1050
PS2, Line 1050: 2, adjust upward if NameNode overhead is still 
significant, or
> NameNode request load
Done



--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 21:15:41 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9915 )

Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9915/2/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/9915/2/docs/topics/impala_scalability.xml@1050
PS2, Line 1050: 2, adjust upward if NameNode overhead is still 
significant, or
NameNode request load



--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 21:13:03 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-04 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9915 )

Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9915/1/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/9915/1/docs/topics/impala_scalability.xml@1047
PS1, Line 1047: The default value for the setting is 2. To change 
the value, set
> At this point in the text, the max_cached_file_handles setting has not yet
Done


http://gerrit.cloudera.org:8080/#/c/9915/1/docs/topics/impala_scalability.xml@1050
PS1, Line 1050: initial default value of 2, adjust upward if 
NameNode overhead is
> NameNode overhead -> NameNode request load
Done


http://gerrit.cloudera.org:8080/#/c/9915/1/docs/topics/impala_scalability.xml@1053
PS1, Line 1053: that caching 20,000 file handles requires up to 120 MB 
on each DataNode.
> 120 MB on each Impala executor (not DataNode)
Done



--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 21:08:53 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-04 Thread Alex Rodoni (Code Review)
Hello John Russell, Joe McDonnell, Alex Behm, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9915

to look at the new patch set (#2).

Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..

IMPALA-6667: [DOCS] max_cached_file_handles is enabled by default

Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
---
M docs/topics/impala_scalability.xml
1 file changed, 17 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/9915/2
--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: John Russell 


[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9915 )

Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9915/1/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:

http://gerrit.cloudera.org:8080/#/c/9915/1/docs/topics/impala_scalability.xml@1047
PS1, Line 1047: The default value for the setting is 2. To change 
the value, set
At this point in the text, the max_cached_file_handles setting has not yet been 
introduced, so it's not clear what "the setting" refers to.


http://gerrit.cloudera.org:8080/#/c/9915/1/docs/topics/impala_scalability.xml@1050
PS1, Line 1050: initial default value of 2, adjust upward if 
NameNode overhead is
NameNode overhead -> NameNode request load


http://gerrit.cloudera.org:8080/#/c/9915/1/docs/topics/impala_scalability.xml@1053
PS1, Line 1053: that caching 20,000 file handles requires up to 120 MB 
on each DataNode.
120 MB on each Impala executor (not DataNode)



--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: John Russell 
Gerrit-Comment-Date: Wed, 04 Apr 2018 20:48:28 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6667: [DOCS] max cached file handles is enabled by default

2018-04-03 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9915


Change subject: IMPALA-6667: [DOCS] max_cached_file_handles is enabled by 
default
..

IMPALA-6667: [DOCS] max_cached_file_handles is enabled by default

Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
---
M docs/topics/impala_scalability.xml
1 file changed, 11 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/9915/1
--
To view, visit http://gerrit.cloudera.org:8080/9915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61b1dc10c61415c673b49d339ba0d27f6a32a51e
Gerrit-Change-Number: 9915
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni