[Impala-ASF-CR] IMPALA-7048: Failed test: test write index many columns tables

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10476 )

Change subject: IMPALA-7048: Failed test: test_write_index_many_columns_tables
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd3be70fb654a49dda44309a8914fe1f2b48a1af
Gerrit-Change-Number: 10476
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 23 May 2018 15:19:26 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7048: Failed test: test write index many columns tables

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10476 )

Change subject: IMPALA-7048: Failed test: test_write_index_many_columns_tables
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2530/


--
To view, visit http://gerrit.cloudera.org:8080/10476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd3be70fb654a49dda44309a8914fe1f2b48a1af
Gerrit-Change-Number: 10476
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 23 May 2018 11:52:00 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7048: Failed test: test write index many columns tables

[Zoltan Borok-Nagy (Code Review)]

Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10476 )

Change subject: IMPALA-7048: Failed test: test_write_index_many_columns_tables
..


Patch Set 2: Code-Review+2

(1 comment)

Thanks, fixed commit message and added missing import.

Carrying +2

http://gerrit.cloudera.org:8080/#/c/10476/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10476/1//COMMIT_MSG@7
PS1, Line 7: test_write_index_many_columns_tables
> probably okay to just shorten this to 'test_write_index_many_columns_tables
Done



--
To view, visit http://gerrit.cloudera.org:8080/10476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd3be70fb654a49dda44309a8914fe1f2b48a1af
Gerrit-Change-Number: 10476
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 23 May 2018 11:50:27 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7048: Failed test: test write index many columns tables

[Zoltan Borok-Nagy (Code Review)]

Hello Thomas Marshall, Lars Volker, Dimitris Tsirogiannis,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10476

to look at the new patch set (#2).

Change subject: IMPALA-7048: Failed test: test_write_index_many_columns_tables
..

IMPALA-7048: Failed test: test_write_index_many_columns_tables

The test in the title fails when the local filesystem is used.

Looking at the error message it seems that the determined
Parquet file size is too small when the local filesystem
is used. There is already an annotation for that:
'SkipIfLocal.parquet_file_size'

I added this annotation to the TestHdfsParquetTableIndexWriter
class, therefore these tests won't be executed when the
test-warehouse directory of Impala resides on the local
filesystem.

Change-Id: Idd3be70fb654a49dda44309a8914fe1f2b48a1af
---
M tests/query_test/test_parquet_page_index.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/10476/2
--
To view, visit http://gerrit.cloudera.org:8080/10476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd3be70fb654a49dda44309a8914fe1f2b48a1af
Gerrit-Change-Number: 10476
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Marshall